Make test_list_domains pagination-safe - #210
Merged
Merged
Conversation
list_domains() returns only the first page (size 100, default sort), so once the test account holds more than a page of domains the freshly created test_domain need not appear on it and the assertion fails intermittently in CI. Sort newest-first so the just-created domain is always on the first page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/v2/test_domains.py::TestListDomains::test_list_domainsfails intermittently in CI (e.g. run 32998054983):list_domains()returns only the first page (page=0, size=100, default sort). The test account now holds more than one page of domains, so the freshly-createdtest_domainis not guaranteed to be on page 0 under the default sort, and the assertion fails.Sort
created_ondescending so the just-created domain is always on the first page — matching the SDK's documented pagination-safe idiom. Verified against the live API.This is a pre-existing test-quality issue, unrelated to any recent feature PR.