Make cross-domain list tests pagination-safe - #211
Merged
Conversation
test_list_cross_domain for features and inventories listed a single unsorted page and asserted the freshly-created fixture item was present. Once the test account holds more than a page of features/inventories the item need not appear on page 0, so the assertion fails intermittently in CI. Page through newest-first until the item is found or the pages are exhausted, mirroring the existing cross-domain grids test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #210.
TestListFeatures::test_list_cross_domainandTestListInventories::test_list_cross_domainlisted a single unsorted page (list_features()/list_inventories()) and asserted the freshly-created fixture item was in it. With more than a page (100) of features/inventories on the account, the item isn't guaranteed to be on page 0, so the assertions fail intermittently in CI (e.g. run 33013970518).Both now page through newest-first until the item is found or the pages run out — mirroring the existing
test_grids.py::test_list_cross_domainpattern. Verified against the live API.Pre-existing test-quality issue, unrelated to any feature PR.