Skip to content

Make test_list_domains pagination-safe #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amarcozzi merged 1 commit into from
Aug 26, 2026
Merged

Make test_list_domains pagination-safe #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/v2/test_domains.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,9 @@ def test_invalid_resolution(self, test_domain):

class TestListDomains:
def test_list_domains(self, test_domain):
domains = list_domains()
# Sort newest-first so the just-created domain lands on the first page
# regardless of how many domains the account already has.
domains = list_domains(sort_by="created_on", sort_order="descending")
assert test_domain.id in [domain.id for domain in domains]

def test_sorting(self, test_domain):
Expand Down
Loading