fix(crypto): support current Fulcio issuer extension - #214
Merged
Merged
Conversation
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
wolfv
force-pushed
the
fix/fulcio-issuer-v2
branch
from
September 6, 2026 13:26
16efcb4 to
cc44159
Compare
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
* fix(tsa)!: parse optional RFC 3161 status text Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(clients): bound Fulcio and TSA HTTP requests Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(verify): enforce Fulcio authority windows at signing times (#217) * fix(verify): enforce Fulcio authority windows at signing times Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(sign): reject unsatisfied TUF service requirements (#218) Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(conformance): honor staging during bundle verification (#219) * fix(sign): reject unsatisfied TUF service requirements Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(conformance): honor staging during bundle verification Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> --------- Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
wolfv
added a commit
that referenced
this pull request
Sep 22, 2026
* fix(crypto): support current Fulcio issuer extension Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(tsa)!: parse optional RFC 3161 status text (#215) Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(clients): bound Fulcio and TSA HTTP requests (#216) * fix(tsa)!: parse optional RFC 3161 status text Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(clients): bound Fulcio and TSA HTTP requests Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(verify): enforce Fulcio authority windows at signing times (#217) * fix(verify): enforce Fulcio authority windows at signing times Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(sign): reject unsatisfied TUF service requirements (#218) Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(conformance): honor staging during bundle verification (#219) * fix(sign): reject unsatisfied TUF service requirements Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(conformance): honor staging during bundle verification Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> --------- Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
wolfv
added a commit
that referenced
this pull request
Sep 22, 2026
* fix(crypto): support current Fulcio issuer extension Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(tsa)!: parse optional RFC 3161 status text (#215) Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(clients): bound Fulcio and TSA HTTP requests (#216) * fix(tsa)!: parse optional RFC 3161 status text Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(clients): bound Fulcio and TSA HTTP requests Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(verify): enforce Fulcio authority windows at signing times (#217) * fix(verify): enforce Fulcio authority windows at signing times Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(sign): reject unsatisfied TUF service requirements (#218) Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(conformance): honor staging during bundle verification (#219) * fix(sign): reject unsatisfied TUF service requirements Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(conformance): honor staging during bundle verification Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> --------- Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
baszalmstra
pushed a commit
that referenced
this pull request
Sep 23, 2026
* fix(crypto): support current Fulcio issuer extension Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(tsa)!: parse optional RFC 3161 status text (#215) Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(clients): bound Fulcio and TSA HTTP requests (#216) * fix(tsa)!: parse optional RFC 3161 status text Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(clients): bound Fulcio and TSA HTTP requests Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(verify): enforce Fulcio authority windows at signing times (#217) * fix(verify): enforce Fulcio authority windows at signing times Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(sign): reject unsatisfied TUF service requirements (#218) Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(conformance): honor staging during bundle verification (#219) * fix(sign): reject unsatisfied TUF service requirements Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(conformance): honor staging during bundle verification Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> --------- Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
baszalmstra
pushed a commit
that referenced
this pull request
Sep 23, 2026
This was referenced Sep 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.3.6.1.4.1.57264.1.8) as DER UTF8String..1.1only when the current extension is absent.Regression covers legacy/current/both/absent extensions and malformed DER.
Stack
Fix 1/6 from the crate review. Based on #212; merge the stack in order. This PR contains only its focused fix relative to its base.
Validation
cargo test --workspace --all-features --lockedpasses on the completed stack.--all-targets --all-features --locked -- -D warnings) passes for the changed crates.cargo fmt --all -- --checkandgit diff --checkpass.