Conversation
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
wolfv
force-pushed
the
fix/fulcio-issuer-v2
branch
from
September 6, 2026 13:26
16efcb4 to
cc44159
Compare
wolfv
force-pushed
the
fix/tsa-status-string
branch
from
September 6, 2026 13:26
bd16ce3 to
a35a7e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statusStringbetweenstatusandfailInfoinPkiStatusInfo.Regression covers full timestamp verification, Unicode, optional-field ordering, rejected responses, and malformed strings.
Compatibility: public
PkiStatusInfostruct literals must now specifystatus_string(typicallyNone).Stack
Fix 2/6 from the crate review. Based on #214; merge the stack in order. This PR contains only its focused fix relative to its base.
Validation
cargo test --workspace --all-features --lockedpasses on the completed stack.--all-targets --all-features --locked -- -D warnings) passes for the changed crates.cargo fmt --all -- --checkandgit diff --checkpass.