Skip to content

fix(tsa)!: parse optional RFC 3161 status text - #215

Open
wolfv wants to merge 1 commit into
fix/fulcio-issuer-v2from
fix/tsa-status-string
Open

wolfv wants to merge 1 commit into
fix/fulcio-issuer-v2from
fix/tsa-status-string

Conversation

@wolfv

@wolfv wolfv commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add optional statusString between status and failInfo in PkiStatusInfo.
  • Preserve rejection handling and validate UTF-8 through the existing DER decoder.

Regression covers full timestamp verification, Unicode, optional-field ordering, rejected responses, and malformed strings.

Compatibility: public PkiStatusInfo struct literals must now specify status_string (typically None).

Stack

Fix 2/6 from the crate review. Based on #214; merge the stack in order. This PR contains only its focused fix relative to its base.

Validation

  • Targeted regression tests pass.
  • cargo test --workspace --all-features --locked passes on the completed stack.
  • Strict Clippy (--all-targets --all-features --locked -- -D warnings) passes for the changed crates.
  • cargo fmt --all -- --check and git diff --check pass.

Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
@wolfv
wolfv force-pushed the fix/fulcio-issuer-v2 branch from 16efcb4 to cc44159 Compare September 6, 2026 13:26
@wolfv
wolfv force-pushed the fix/tsa-status-string branch from bd16ce3 to a35a7e6 Compare September 6, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant