fix!: restore fixes dropped from the pre-1.0 stack (#214–#219) - #226
Merged
Merged
Conversation
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
* fix(sign): reject unsatisfied TUF service requirements Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(conformance): honor staging during bundle verification Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> --------- Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
wolfv
changed the title
This was referenced Sep 23, 2026
baszalmstra
approved these changes
Sep 23, 2026
This was referenced Sep 23, 2026
Merged
jku
pushed a commit
that referenced
this pull request
Sep 23, 2026
…#234) * fix(sign): pass RekorApiVersion in TUF service requirement test #226 and #227 merged independently: the test from #218 still passed `Some(1)` to `from_tuf_config_with_rekor_version`, which now takes `Option<RekorApiVersion>`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(sign): drop clone of Copy ServiceSelector in test #231 made ServiceSelector Copy, so clippy's clone_on_copy fires on the test added in #226. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> * fix(sign): give the custom-instance test fixture a TSA #218 (restored in #226) requires an eligible TSA endpoint, but the custom signing config added by #227 listed none. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> --------- Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#214–#219 were reviewed and merged into stacked branches (
pre1/offline-rekor→fix/fulcio-issuer-v2→fix/signing-http-timeouts→fix/fulcio-authority-windows). Those branches never reachedmain: #212 was squash-merged from an earlier point in the stack, so v0.12.0 shipped without them. This PR brings them back by cherry-picking the original commits onto currentmain, one commit per PR.1.3.6.1.4.1.57264.1.8)The code is unchanged from what was reviewed. Every commit applied cleanly.
Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-features --no-fail-fast(no failures)Signed-off-by: Wolf Vollprecht w.vollprecht@gmail.com
🤖 Generated with Claude Code