Repository navigation
Bundle optional RomFS overlay in portable signed Mac apps - #1564
Closed
ishtiaq156 wants to merge 3 commits into
Closed
ishtiaq156 wants to merge 3 commits into
ishtiaq156 wants to merge 3 commits into
Conversation
ishtiaq156
marked this pull request as ready for review
November 6, 2026 20:27
This was referenced Nov 6, 2026
ishtiaq156
marked this pull request as draft
November 6, 2026 23:00
This was referenced Nov 7, 2026
ishtiaq156
marked this pull request as ready for review
November 8, 2026 04:39
Contributor
Author
|
Closing because the original Wonder Edition diagnostic RomFS overlay is no longer necessary. The general upstream NVN correction now works with the unmodified RESTBL and no overlay. The optional bundled-overlay feature remains independent and has not been merged. It can be considered separately if there is a future general packaging need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A Mac build using
DM_ROMFS_OVERLAYcould work in the developer's terminal yet lose the override when moved to another Mac or launched in Finder: the overlay lived outside the.app. This was encountered while reproducing a temporary diagnostic BFRES resource-size-table workaround for Super Mario Bros. Wonder Switch 2 Edition's new-game model allocations; it is not an upstream fix for that underlying allocator issue.Add opt-in
dm/mac/pack_app.py --romfs-overlay <dir>. The packer validates and bundles the directory atContents/Resources/romfs_overlay, adds its content to the existing input fingerprint/cache invalidation and free-space checks, and signs it with the app. The launcher setsDM_ROMFS_OVERLAYto the bundle-local path when it exists, leaving an explicitly supplied environment value authoritative. No change to apps without the option; no proprietary game file is included in this PR.Scope relative to Wonder Edition: The remaining clean-build BFRES model-memory failure is tracked separately in #1580. This optional overlay-packaging capability is not a prerequisite for an overlay-free Wonder port and does not correct native NVN command memory accounting.
Checked
python3 -m unittest dm.tools.tests.test_nsp_mac_app.PackReuse.test_optional_romfs_overlay_is_bundled_and_invalidates_cache dm.tools.tests.test_nsp_mac_app.App.test_bundled_romfs_overlay_is_passed_to_host_and_can_be_overridden— 2 passed (13.8 s). Checks packaging, reuse, invalidation, removal, launcher path and explicit environment override.python3 dm/tools/docs_symptoms.py;python3 -m unittest dm/tools/tests/test_docs.py— 11 passed; stagedgit diff --checkpassed.dm_vi_frame_queuedCPU test stub is already handled by upstream #1578 (060aef96/8764cdfc); our separate draft #1603 is superseded and not a prerequisite. The shader-pairoutputtest helper was incorporated upstream via5e344a87, and outstanding Xcode fixture and environment-switch checks overlap #1675 and our draft #1606. These baseline tests are unrelated to this optional overlay feature. After merging current upstream24fe1e5ainto this draft, the Mac-app test module passed 64/64 checks; the PR is now ready for independent review; no diagnostic resource-table change is included.Docs
docs/reference/packing.md, regenerateddocs/agents/symptoms.md.