Repository navigation
Stub the VI frame-history hook in the NVN suspend test - #1603
Closed
ishtiaq156 wants to merge 1 commit into
Closed
ishtiaq156 wants to merge 1 commit into
ishtiaq156 wants to merge 1 commit into
Conversation
Owner
|
Thanks for isolating the missing test symbol and documenting the upstream status. This is superseded by #1578: 060aef96 links the shared test stubs, and 8764cdfc supplies the weak Current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The CPU-only
t_gfx_suspendtest includes NVN queue/present code but does not link the guest VI layer.nvnQueuePresentTexturenow callsdm_vi_frame_queued(the real frame-history callback), so this test's standalone arm64 link fails withUndefined symbols: _dm_vi_frame_queuedon the currentmain. The same missing symbol blocked the Mac build check of #1564, unrelated to that PR's optional Mac RomFS overlay.Provide a no-op test-local
dm_vi_frame_queuedstub alongside the test's existingdm_vi_layer_cropand host stubs. The production callback, NVN implementation and game behavior are unchanged.Checked
MAKE=/usr/bin/make /usr/bin/make -C dm/gfx/tests GAME=010015100B514000 t_gfx_suspend && ./dm/gfx/tests/t_gfx_suspend— 15 checks passed, zero failures, including suspension while prepare holds the submit lock, queued submissions, drain and resume.build-logs/wonder-ci-gfx-suspend-20261106.{log,exit}in the local workspace.git diff --checkpassed; no changes to app, game profiles, source ROMs or saves.Docs