Repository navigation
test: fix baseline Xcode and shader-pair CI fixtures - #1606
Closed
ishtiaq156 wants to merge 2 commits into
Closed
ishtiaq156 wants to merge 2 commits into
ishtiaq156 wants to merge 2 commits into
Conversation
The synthetic Xcode extraction deliberately lacks a RomFS.img; mock its separate integrity check but assert that the packaging pipeline still invokes it for the selected version. Supply the fixture-backed output() dependency to vs_pad's AST-only test harness and verify that missing pixel shader outputs are ignored. Both errors reproduce unchanged on b2d46b8 (12 tests, eight errors). The two repaired modules pass 13 tests, expanded adjacent tests pass 39, and the pinned Python lint ratchet reports no new findings.
This was referenced Nov 7, 2026
# Conflicts: # dm/gfx/tests/test_dmsh_pairs.py
ishtiaq156
marked this pull request as ready for review
November 8, 2026 04:39
Contributor
Author
|
Closing this CI fixture PR as the substantive Xcode The additional missing-pixel-output regression test in this branch remains unmerged, but this PR is no longer required for the Wonder Edition integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The saved draft #1564 Tool tests log showed six
FileNotFoundErrorfailures in the Xcode preparation fixture and twoNameError: outputfailures in shader-pair tests. I reproduced all eight errors using the same two test modules on a new clean worktree atmaincommitb2d46b86; these are pre-existing generic test failures, not introduced by #1564.Changes
check_formats(the fixture createsRomFS/andExeFS/but deliberately no realRomFS.img); assert that the preparation pipeline still passes the selected extracted version to the format-check stage.output(label, name)dependency that productionvs_padobtains from its module. Verify an absent pixel shader output is skipped rather than padded.test_romfs_image.Validation
b2d46b86:python -m unittest -v dm.ios.tests.test_xcode_workflow dm.gfx.tests.test_dmsh_pairs— 12 tests, 8 errors (six Xcode subtests, two shader-pair tests).test_xcode_workflow,test_dmsh_pairs,test_dmsh_pull,test_romfs_image,test_dmsh_code_fp): 39/39 PASS.py_compileandgit diff --check: PASS.ruff==0.17.2,pyright==1.1.414ratchet usingdm/tools/lint_python.py --against b2d46b86: 371 findings / 371 baseline / 0 new / 0 fixed outstanding.Other unrelated existing CI tool-test failures appear in the saved log (
SeenShaders.test_shader_watch_counts_the_list,test_dmsh_pool_arrays). This PR does not claim the entire Tool tests job is green or alter those issues.Related observation: draft #1564's failure reproduces on unchanged main; no changes are requested to #1564.