Repository navigation
ci: fix three checks broken by new runner images - #2583
Justinwold88 wants to merge 8 commits into
Conversation
Run the MQTT test broker from the eclipse-mosquitto:2.0.18 image, build Espressif QEMU on ubuntu-24.04, and enable git long paths before cargo on Windows. Plan item 0.6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T8hca9bTB4puaeBstXR9CE
There was a problem hiding this comment.
🟡 Changes recommended
The review evidence flags a moderate, workflow-breaking ordering issue where the Windows long-path workaround runs after rust-cache triggers cargo metadata, allowing a cold-cache run to hit the same path-too-long failure before the fix is applied.
1 open issue
What changed in this PR
Fixes three CI workflows that broke on newer GitHub-hosted runner images and in cold-cache scenarios.
Changes:
- Run MQTT integration tests against a pinned
eclipse-mosquitto:2.0.18container instead of installing distro Mosquitto. - Pin the Espressif QEMU build job to
ubuntu-24.04to avoid GCC 15 build failures on newer runners. - Configure Git long-path support on Windows to prevent Cargo git dependency checkout failures.
| File | Description |
|---|---|
| .github/workflows/ruview-kernel-npm.yml | Updates the Windows kernel CI workflow to enable Git long-path support to avoid path-length failures during Cargo git dependency operations. |
| .github/workflows/mqtt-integration.yml | Switches MQTT integration tests to use a pinned Mosquitto Docker container with a mounted CI config and updated readiness/log steps. |
| .github/workflows/firmware-qemu.yml | Pins the QEMU build job runner to ubuntu-24.04 to avoid GCC 15 warnings-as-errors in the bundled dtc build on newer images. |
Review effort: Balanced
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
| - name: Allow long paths for cargo git checkouts | ||
| if: runner.os == 'Windows' | ||
| run: git config --global core.longpaths true |
|
Taking the scoped runner repair/review under Dragan's explicit request; contributor ancestry and Windows long-path fix will be preserved. Current head25d867fb45944d3c85a3291ff1c75a5da0a19301 / main13b47883. I am checking the cold-cache paths against #2513's already-qualified runner corrections. Planned follow-up on an isolated branch: reuse its digest-pinned SDK QEMU/runtime and non-root broker, preserve this PR's Windows fix, validate workflow syntax and actual affected jobs. The existing QEMU cache key otherwise still accepts old floating-source builds, and the broker tag is mutable. This copies only CI bootstrap changes, not the held server feature stack. No main merge, release or firmware/device action. Will post exact diff/head and results here before treating it ready. Owner Dragan; agent Codex; host DraganMac; session ruview-server-repairs-20261119; lease until14:25UTC. Please flag conflicting edits to the three workflow files. |
|
Updated security assessment: raw CI still fails five entries, but primary-advisory checks refute four matches against core wasmtime36.0.20. Do not infer that a major Wasmtime migration is required. Executed cargo-audit0.22.2 output from RustSec DB7133866a6b44d6d3e1994ae6a48a296553c3c3da is retained. Separate current upstream advisory HTML and repository security-advisory API readbacks show:
STATIC caller inspection: Wasmtime is default-off in homecore-plugins/homecore-server. The current host uses default Config plus fuel and Caller::get_export; no direct Caller::get_module_export call was found. Registry36.0.20 source has distinct get_export/get_module_export implementations. This is bounded source evidence, not a complete runtime reachability or shipped-binary proof. The smallest next remediation is a reviewed36.x patch/caller qualification plus correcting the four advisory package/range mismatches. No ignore, audit-threshold change, advisory database edit or major dependency migration has been introduced here. The raw audit remains failed and overall merge readiness stays held until that baseline is reconciled. The first five-entry report described scanner output; this primary-source assessment supersedes any inference that all five are actual defects in core36.0.20. |
|
NO BLOCK in the reviewed source-repair scope at Checked all changed runner workflows, same SDK digest in builder/consumers, removed stale floating-source QEMU cache, unchanged7-case QEMU matrix/fuzz budgets, pinned non-root loopback broker and cleanup, Windows long-path ordering. Real local broker startup and current-head hosted MQTT/QEMU bootstrap/fuzz/Windows kernel/audit/Semgrep pass. Remaining QEMU cases/macOS/full workspace/bench are not relabeled as passed. Current checkpoint: No main merge, helper/app replacement, plugin enablement, firmware flash or physical/customer acceptance is claimed. Reverify if head/base changes. Full current-head CI and rUv's separate review/merge decision remain the next gates. |
|
NO BLOCK in the previously reviewed repair scope; final exact-head hosted qualification is now complete. Terminal hosted qualification — 2026-11-20Exact head |
|
NO BLOCK in the reviewed Nov20 reconciliation delta at Only shared security workflow/docs change relative to the previously qualifieda93 head; pinned broker/QEMU matrices, fuzz budgets and Windows long-path ordering preserved. Native upstream audit replaces temporary reconciliation. Fresh full qualification pending. Earlier terminal CI receipts remain historical and are not relabeled as passes on this new head. Same-head duplicate push QEMU/bench and unfinished supersededb109 runs were cancelled only where an active replacement exists; completed failure evidence is retained. No main merge, installed-helper/app replacement, release or sensor operation. Maintainer review/exact-head merge authority remains separate. |

Repair cold-runner bootstrap failures without changing sensing code or weakening tests. Current head
356fafeec5906830659bb400c4c209d84a87f742, basemain; includes shared security baseline #2585 and preserves contributor history.Local actual broker execution, workflow syntax/ShellCheck, matrices/budgets, secret/diff checks passed. Previous heada93 terminal CI:40pass/5conditional skips, including full workspace, MQTT, QEMU/fuzz, Windows/macOS kernel, security and bench. The new change only simplifies the shared security workflow/docs; Rust sources are identical. Fresh current-head qualification is pending.
Landing: #2585 → this PR → #2545. Held #2513 incorporates this ancestry and preserves its focused
mqtt::selection because its long learner tests already run in full CI/Release. Preserve that selection when reconciling the lanes. No device operation, main merge, image publication, release or helper installation.