Repository navigation
Reconcile managed room-learner stack with current RuView main - #2513
proffesor-for-testing wants to merge 169 commits into
Conversation
Complete the prepared local integration of upstream a1ca023 into the companion candidate. Runtime helper provenance remains pinned to the previously verified clean source.
Move the companion pairing design to ADR-419 so upstream ADR-383 remains the HTTP request-target validation decision.
Recheck approved-device capacity under the approval lock before persistence, retaining pending requests when full. Build the exact Host allowlist entry from the prepared identity authority used by the QR, including generated and reloaded identities. Regressions reproduced the old failures and now pass. Verified actual workspace binary check, nine companion tests and the real binary authority test, plus 28 isolated module tests and independent fix-delta review. No Host wildcard or validation bypass.
Resolve Tokio 1.51.6 with its compatible Mio, socket2 and macro dependencies. Preserve the scoped companion stack and existing audit policy; no upstream vendor or framework adoption. Existing LRU unsoundness and yanked-package warnings remain separately recorded.
Preserve main archive/cache compatibility and companion socket gates. Retain the audited main dependency graph while restoring companion/MAT privacy changes.
There was a problem hiding this comment.
REMAND for final merge disposition: the qualified current-main candidate is green, while rUv review and the known standalone timing risk still need a decision. This COMMENT is not formal human approval.
Frozen tuple, refreshed November 12 at 16:00 UTC:
- PR head:
68cd04927ac503ae68313edc249c6ea8627319c2. - Main:
094e1400719ded1283c67d23b9c737f6738a3244. - GitHub merge ref:
9b8f70754d036a77900d936b93795616d2242dd5; tree2b732f00e133526b310d634a792a219aaba4d86d. - The PR remains CLEAN/MERGEABLE, with rUv requested and no submitted owner review.
EXECUTED receipts close all five original CI areas:
- MQTT on head68: 43183390004 passed feature units and actual pinned Mosquitto integration; the owned broker stopped successfully.
- QEMU and fuzz on the merge candidate: 43188188492, all 11 jobs passed, including actual fuzz testing.
- Rust workspace and downstream checks: 43188188760, SUCCESS. All 37 mandatory Release cases passed, zero selected failures or ignores. Default-48 C4C completed 48 epochs, 395 parameters and 38,373 objective evaluations under the unchanged 60,000 ms / 100,000 caps. Full lifecycle 487.68 s is not fit time.
- Bench: 43188188802, SUCCESS. Head68 also separately passed 43183609967.
- Firmware, security, forecast Rust and Python workflows also remain SUCCESS on the merge candidate.
Retained counterevidence: standalone head68 43183605678 hit the unchanged 240-second operator guard at 76/80 windows before C4C. Child938 repeated it. These failures are not erased or claimed causally fixed.
Further probes did not reproduce the failure: child diagnostic full CI8370 43232492184 passed Debug plus all 38 Release cases and downstream sockets/FANN/CIR/witness checks; direct Release0e490242 passed all 38; failure-only comparison31b15c55 passed all nine C4 cases with normal-path logging removed. Controlled segment76 and partial-row77 storage holds both resumed to 80 durable windows and completed fit/cold/evaluate. These are additional probes, not substitutes for the parent's separate 37-case receipt or hardware qualification.
Child #2527 now has test/CI-only live evidence and lazy watchdog state at56d43b5a, with current-head gates still running. Parent head68 is unchanged. No speculative capture repair or timeout/budget relaxation was introduced. Keep the intermittent standalone timing risk visible for rUv's decision; refresh qualification if either parent/main ref changes. No main merge, release or helper installation was performed by this lane.
There was a problem hiding this comment.
NO BLOCK for the reviewed code and CI at head 4f70c5eafe28a17395f1588cc15f5e64ba932d7d against main 094e1400719ded1283c67d23b9c737f6738a3244. This COMMENT is not formal human approval or merge authorization.
The current GitHub merge candidate 994e5896053579ae8e35b36f2bc8818160a37aad, tree af593d44129b957c917c14d2c1a6ad397c1dadc5, matches those exact parents. All 11 current-head workflows are terminal SUCCESS, including full CI43279683707, MQTT43279683661, QEMU/fuzz43279683678, security43279683676 and bench43279683922. Rust workspace, sockets, patched archive/cache compatibility, FANN, CIR and both witness guards passed.
The retained Release receipt is clean, has 1096 registered tests and 37 required passes with zero selected failures/ignores. C4: nine cases PASS526.41s. C4C: PASS629.70s for its full lifecycle; this is not fit duration. Test binary SHA256 fb559047d32f72eb4e1b4d859d22177954ab74ab63c3b39efd69a75407d9849b.
Root cause and repair: diagnostic211 exposed 22 final-Check preparation/restart gaps, no deferred ACK and no clock lead. The synthetic driver generated input before segment preparation completed; host latency repeatedly consumed its first-window buffer. The fixture now waits for verified preparation before generating synthetic packets, asserts no preparation credited as observation, and includes an actual five-second publication hold. Local full-journey regression also passed205.18s. All80 windows/phases/fit/cold/evaluation assertions, original240s phase wall guard, production clock/backpressure rules and default-48 training/evaluation caps are retained. Real-paced/backpressure tests are unchanged.
Opposite-assumption checks: no rows/flags are manually promoted, the wait shares the original phase-start Instant, bad/missing ACKs cannot produce success, and PR verification cannot invoke the legacy publisher/notifier. Publication/version jobs were skipped for verification, not qualified. No production capture repair, physical sensing/throughput qualification or repair of the separate historical Empty Check is claimed.
Current source/CI follow-up is complete. Ready for rUv's owner review and separate exact-head merge decision. Refresh qualification if head/main changes. No main merge, release or helper198 replacement was performed by this lane.
|
Dependency-security follow-up for the held stack: fresh November14 audit on descendant #2555 at783e69d4 found RUSTSEC-2026-0523/0524 (quinn-proto0.11.18) and RUSTSEC-2026-0538 (quinn-udp0.5.14), inherited from this parent lockfile. Prior green checks at4f70c5e do not include the new advisory result. Separate draft #2556 at ef9dd1b patches only the two lock entries and required UDP dependency edges. Local locked compile checks and the unchanged repository-policy audit pass. #2555 now stacks on that repair and its current combined-head Rust Dependency Audit passes; fresh standalone security run43602259821 also passed its Rust audit. Other hosted checks remain in progress. This parent and installed helper are unchanged. The merge hold remains; account for #2556 in the stack review before treating dependency security as current. No new audit ignores or approval/merge claim. |
|
November17 reconciliation of the held security/review state (no branch edits or merge):
Reproduce from each exact revision with working-directory |
|
Fresh-database correction to today's lockfile audit snapshot: advisory DB commit New findings: libz-sys1.1.31 / RUSTSEC-2026-0544; zip0.6.6 /0545 and0548; zip7.2.0 /0545,0546,0547,0548. These are version-based workspace findings; applicability of the existing vendored backports and actual caller paths still needs assessment. No new ignore is proposed. The checked For #2513 this refresh checked merge candidate No source edits, advisory suppressions, runtime exploitability conclusion, merge or release performed. Keep review/landing qualification separate from historical green CI. |
|
NO BLOCK in the reviewed current-main reconciliation delta at Fresh qualification is terminal: 14 workflows SUCCESS, 66 checks SUCCESS, nine conditional SKIPPED. Includes full CI44265854972, security44265854909, MQTT44265854655, QEMU/fuzz44265854985, bench44265854887. Duplicate firmware/QEMU/Python event runs are counted as separate workflows, not independent test coverage. EXECUTED source binding: full CI's merge candidate Review scope: the three conflict resolutions preserve managed room/companion plus upstream RSSI modules, registry ZIP9 through its Candle adapter and libz1.1.33. The old active ZIP7 selector is removed, the security job executes the active adapter guards, and audit policy is unchanged. Local608 bin tests/26 real socket checks and hosted workspace/Release/FANN/CIR/calibration/auth, audit, QEMU/fuzz/MQTT and bench checks all pass. No timing budget, coverage floor, security gate or production fit guard was relaxed. Limits remain explicit: local path packages require independent provenance/caller/guard evidence despite cargo-audit0.22.2's zero unresolved registry findings. Conditional skips are not executed results. This is not container publication, physical sensing, installed-helper198, dependent-PR or customer acceptance qualification. Reverify if main/head changes; do not close original PRs before actual landing and ancestry/content reconciliation. |
Run the MQTT test broker from the eclipse-mosquitto:2.0.18 image, build Espressif QEMU on ubuntu-24.04, and enable git long paths before cargo on Windows. Plan item 0.6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T8hca9bTB4puaeBstXR9CE
|
Updated security assessment: raw CI still fails five entries, but primary-advisory checks refute four matches against core wasmtime36.0.20. Do not infer that a major Wasmtime migration is required. Executed cargo-audit0.22.2 output from RustSec DB7133866a6b44d6d3e1994ae6a48a296553c3c3da is retained. Separate current upstream advisory HTML and repository security-advisory API readbacks show:
STATIC caller inspection: Wasmtime is default-off in homecore-plugins/homecore-server. The current host uses default Config plus fuel and Caller::get_export; no direct Caller::get_module_export call was found. Registry36.0.20 source has distinct get_export/get_module_export implementations. This is bounded source evidence, not a complete runtime reachability or shipped-binary proof. The smallest next remediation is a reviewed36.x patch/caller qualification plus correcting the four advisory package/range mismatches. No ignore, audit-threshold change, advisory database edit or major dependency migration has been introduced here. The raw audit remains failed and overall merge readiness stays held until that baseline is reconciled. The first five-entry report described scanner output; this primary-source assessment supersedes any inference that all five are actual defects in core36.0.20. |
|
NO BLOCK in the reviewed Nov20 reconciliation delta at Merged runner/security ancestors normally; retained full parent CI/temporal Release and focused MQTT files byte-identical to38a. Sensing-server source and audit policy unchanged;32-family-only lock update, locked metadata and45 temporal classification tests pass. Actual pinned native audit0/zero findings onDB074ea9a7. Fresh fullCI/Release/socket/archive qualification pending, not inherited from38a. Earlier terminal CI receipts remain historical and are not relabeled as passes on this new head. Same-head duplicate push QEMU/bench and unfinished supersededb109 runs were cancelled only where an active replacement exists; completed failure evidence is retained. No main merge, installed-helper/app replacement, release or sensor operation. Maintainer review/exact-head merge authority remains separate. |
Reconcile the managed pairing, companion, room-learner, recovery and temporal stack with RuView main while preserving original PR ancestry. Current head
bb2b088b90647374d54ca5a73eb25294aa75d287, targetmainat13b47883. No main merge, release or installed-helper change.Preserve managed ruview-unified, room publication, configured-topology provenance, selected-model withholding, recovery and prepared training alongside upstream FANN/RSSI/witness/forecasting changes. Retain registry ZIP9.0.5 through the private Candle adapter and libz-sys1.1.33. Archive security guards and SQLx repairs remain.
Nov20 reconciliation incorporates #2583/#2585: compatible Wasmtime36.0.21 family/cache patch, imported/re-exported host-function regression, Windows long paths and QEMU shell quoting. RustSec corrected its false range matches; the temporary reconciliation is removed. CI invokes pinned cargo-audit0.22.2 directly, with pipefail and unchanged policy. Main-push-only publisher/notification guards remain. Both merge conflicts were workflow comments/selections; the held full CI, temporal Release journeys and focused MQTT workflow are byte-identical to previous38a, as is sensing-server source.
Local Nov20:19 pre-simplification audit regressions and45 temporal classification tests pass; locked metadata, workflow syntax, secret/diff checks pass. Actual patched graph audit0.22.2 exits0 with zero native findings on DB074ea9a7; unpatched-main control exits1. Dependency changes are confined to32 Wasmtime/Cranelift/Winch/Pulley family entries. No server behavior tests are relabeled as execution on this new head.
Historical38a validation:608server tests,26 real paired-TLS/socket checks,2 Candle archive tests,4 adapter guards and45 temporal classification tests passed;14hosted workflows completed66pass/9conditional skips, with37 Release journeys. Earlier audit DB233155b4 is superseded. Fresh current-head hosted qualification is pending. Inherited advisory Docker failures/skips do not qualify image publication.
#2527/#2528/#2543/#2555/#2568 retain their own scopes/parent and qualification requirements. Separate maintainer stack review and exact-head merge authorization remain required. Installed helper198 and real sensing/customer acceptance are separate. Close superseded originals only after actual landing/content reconciliation.