Repository navigation
feat(harness): declarative node config — set up ESP32 CSI nodes from one YAML file - #2545
matthewxfz3 wants to merge 18 commits into
Conversation
Replaces the per-board esptool/provision.py chain with a declarative config applied by MAC. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
proffesor-for-testing
left a comment
There was a problem hiding this comment.
REMAND at 59cb729. Existing targeted tests pass (28/28), but three independent synthetic production-function probes expose gaps. No real serial ports, UDP listeners or devices were opened; author branch unchanged.
-
P1 — bind interactive confirmation to the displayed board/plan. EXECUTED.
harness/ruview/src/cli.js:289-299obtains an unconfirmed plan, asks permission for its MAC/node, then callsapplyBoardagain without the expected MAC/plan.node-config.js:522re-probes and adopts whatever board now occupies the path. Probe: plan MAC A/node1; replace mocked MAC with B/node2 on the same port before the confirmed call; the provisioning mock receives--node-id 2and the result isok:true. Re-identification is necessary, but a changed identity must invalidate the old confirmation. Pass an immutable expected MAC/node/plan into confirmed execution and reject mismatch before flash, registry assignment or NVS writes; test replacement between plan and confirmation. -
P1 — registry restoration can duplicate an explicitly configured node ID. EXECUTED.
harness/ruview/src/node-config.js:332-333restores the last registry ID without checking current assignments. Probe: registry MAC B has node4; YAML now assigns node4 to different MAC A;resolveNode(config, B, registry)returns B/node4, sourceregistry. Applying both boards produces the same stream identity. Reject/reconcile conflicting restored IDs against the full current config and active registry map before planning or writes; add stale-registry versus explicit-config collision controls. -
P2 — offline auto-assigned nodes disappear from status and can yield false success. EXECUTED.
harness/ruview/src/node-config.js:610-614builds registry assignments but omits their IDs from the iteration set. Probe: empty YAML node list, registrynode_assignedMAC B/node4, empty mocked capture.nodeStatusreturnsok:true,nodes:[],0/0 known nodes healthy. Include active known registry IDs in status and retain an offline/no-CSI row; test disappearance/reappearance independently of explicit YAML entries.
Applicability to the managed Mac/radar lane: this is a generic CSI CLI, not a dedicated MR60 installer. Its example aggregator UDP5005 must not be copied into the current raw55063/radar5005 split without explicit configuration. Status also competes for the live receiver port; no live status/apply qualification was attempted. No C5, signed-app, USB replacement or physical radar acceptance claim is made.
Verification: frozen Git archive of this head, including its exact YAML example; node --test --test-reporter=dot test/node-config.test.mjs test/firmware.test.mjs PASS28. Separate Node imports of production normalizeNodeConfig, resolveNode, nodeStatus, applyBoard used temporary synthetic registry/config and mocked exec/capture/fetch to reproduce the findings above. Full package suite and hardware checks were not rerun.
proffesor-for-testing
left a comment
There was a problem hiding this comment.
NO BLOCK for the three repaired review findings at 3e1af4f. This is the repair author's bounded recheck, not an independent or formal human approval.
EXECUTED: eleven new regressions; eight fail on frozen original59cb and all pass on the repair. Focused39/39; full package314pass/5existing skips/0fail with canonical TMPDIR; original default-temp hosts failures independently reproduced. Manifest65-file integrity, Gitleaks and diff checks pass. Checked the actual CLI caller passes displayed MAC/node into confirmed execution before any registry/device writes; covered same-board assignment drift, registry/config and registry/registry collisions, explicit reassignment, malformed records, offline→online status and ambiguous identity reporting.
The original REMAND remains an accurate historical verdict for59cb; its three findings are closed at this new head. CI status and original hardware/receiver qualification limits remain separate; no physical operation or merge.
proffesor-for-testing
left a comment
There was a problem hiding this comment.
NO BLOCK within the repaired findings/current-main reconciliation scope at b02ef79. Repair-author recheck; not an independent or formal human approval.
The three original findings are closed: displayed MAC/node binds confirmation before side effects; effective retained/config ownership rejects collisions; offline registry nodes remain visible/unhealthy and ambiguous IDs are explicit. Eleven new regressions include eight original-source failures and three compatibility controls. Final reconciled head:41focused PASS; full package318PASS/5existing skips/0FAIL with canonical TMPDIR; manifest65-file integrity, Gitleaks and diff checks PASS.
Normal merge of main094 resolves the original PR's existing conflicts, preserves upstream strict CSI callback evidence/C5 watchdog/security-eFuse/flash-capacity protections and package0.9.3 bounded test concurrency. GitHub mergeable=true. Hosted checks/runs are not reported yet; no hosted-CI pass or physical qualification is inferred. Main and installed app/helper/devices were not changed. Earlier reviews remain historical for their exact heads.
…d board's ID plan resolved against an empty registry, so it passed configs apply then refused, and a gone board's ID could only be freed by hand-editing devices.jsonl. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the review and the repair commits. Follow-up at 578ca7b for two gaps in the new node-ID conflict logic:
Also:
The 5 new regressions fail on b02ef79's One question on the |
|
NO BLOCK in the reviewed node-ID conflict/retirement delta at578ca7b2232a6e20441717b9bfd25d2c738dd3a3. EXECUTED:45 focused node-config/firmware tests passed; the complete harness run passed322 tests with5 skips after installing the pinned development dependencies and using canonical /private/tmp for macOS fixtures. The first full run lacked @metaharness/flywheel and hit existing /var versus /private/var fixture assumptions; those were environment/portability failures, not changes to this PR. No source changes were needed for this review. STATIC: plan now resolves against the same registry as apply; retired MACs release their retained IDs and are refused if selected again; normalized config prevents active/retired overlap; offline inventory excludes retired entries. The updated boot-banner expression still recognizes the current S3 banner. Explicit confirmation, MAC re-probe and firmware identity checks remain. No hardware, USB, flashing, Wi-Fi or live CSI acceptance performed. Hosted checks are not reported for this head. This is a scoped software review, not merge authorization or hardware qualification. |
|
Current-head CI/review reconciliation at
Next steps: approve the intended workflow executions through the repository's normal process, obtain current-head results, and refresh the maintainer review on578ca7b (or its replacement). No workflow approval, source edit, merge or device action performed in this reconciliation. |
|
CI/review reconciliation at unchanged head The old PR-event CI checks out Two newly executed failures remain actionable:
The dedicated device-e2e workflow, CSI policy and fix-marker runs passed. These are source/test checks, not physical hardware qualification. The prior code-only NO BLOCK does not mean current CI is green; formal approvals on |
|
Current-main candidate qualification completed on
The separate npm package-size and Windows assertion failures above remain open. The qualification branch's push filters do not execute those same PR-only package/flywheel jobs, so its green full CI cannot clear them. Contributor branch and reviewed size ceiling remain unchanged; no main merge/release was performed. |
Run the MQTT test broker from the eclipse-mosquitto:2.0.18 image, build Espressif QEMU on ubuntu-24.04, and enable git long paths before cargo on Windows. Plan item 0.6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T8hca9bTB4puaeBstXR9CE
|
Taking the remaining CI repairs under Dragan's selected server lane. Current contributor head578ca7b2232a6e20441717b9bfd25d2c738dd3a3 is preserved; please flag conflicting source/workflow edits. Planned normal update in an isolated worktree: incorporate current-main and #2583's shared runner repairs without a main merge; correct the existing Windows tilde-expansion test to native path semantics; propose an explicit480KiB package ceiling for the new node-config capability. Local npm pack reproduces479863bytes (468.6KiB), including44024bytes for the new runtime module; the old448KiB ceiling predates that capability. The proposed480KiB ceiling retains a hard bound with11657bytes headroom. This is an explicit feature-footprint change for review, not a claim that the old ceiling passed or an already-approved policy. Runtime node-config behavior, device-ID conflict/retirement guards and security manifests remain unchanged. Preserve full package, harness, Windows, broker/QEMU/fuzz qualification; no device flashing, contributor-history rewrite, main merge or release. Will provide new exact head, pack inventory, tests and fresh CI before treating ready. Owner Dragan; agent Codex; host DraganMac; session ruview-server-repairs-20261119; lease until14:25UTC. |
|
NO BLOCK in the reviewed source-repair scope at Checked the native path correction and explicit448→480KiB package proposal; node-config runtime/ID-conflict/retirement guards are unchanged.322local harness tests and152security tests pass with existing skips;65manifest files match. Actual pack positive/oversize/source-map controls pass/fail correctly. Fresh current Node20/22 package and Windows harness checks pass. Published harness tree equals the earlier tested736 tree. The footprint ceiling remains an explicit normal-review change. Current checkpoint: No main merge, helper/app replacement, plugin enablement, firmware flash or physical/customer acceptance is claimed. Reverify if head/base changes. Full current-head CI and rUv's separate review/merge decision remain the next gates. |
|
NO BLOCK in the previously reviewed repair scope; final exact-head hosted qualification is now complete. Terminal hosted qualification — 2026-11-20Exact head |
|
NO BLOCK in the reviewed Nov20 reconciliation delta at Also repaired the test-only collector readiness wait after actual Windows startup timeout atb109. Controlled delayed real child: old fixtureFAIL/newPASS; missing-child and never-ready negatives stillFAIL as expected with bounded cleanup/diagnostics. Full local322pass/5existing skips; manifest65PASS. Explicit test startup allowance2→10seconds; capture/session assertions and production source unchanged. Fresh Windows/full CI pending. Earlier terminal CI receipts remain historical and are not relabeled as passes on this new head. Same-head duplicate push QEMU/bench and unfinished supersededb109 runs were cancelled only where an active replacement exists; completed failure evidence is retained. No main merge, installed-helper/app replacement, release or sensor operation. Maintainer review/exact-head merge authority remains separate. |
Add declarative node configuration so users can plan/setup/inspect ESP32 CSI nodes from YAML while retaining explicit device confirmation and assignment safety. Current head
8cccbe5397a2cca1397db495cc2937b5f9801e5e, basemain; preserves the original contributor history and includes runner #2583/security #2585.Local full harness322pass/5existing skips; security152pass/3skips;65manifest entries checked. On macOS use canonical TMPDIR=/private/tmp; prior /var alias failures remain historical evidence. Actual package positive and oversize/source-map negative controls pass. Previous heada676 terminal hosted CI:57pass/8conditional skips, including Windows, Node20/22 pack, full workspace, MQTT, QEMU/fuzz/security/bench. Published harness subtree is unchanged by the current security-workflow simplification. Fresh current-head CI pending; earlier human approvals apply to an older head.
No new physical node/USB/UDP verification or main merge was performed in this repair. Existing contributor device observations do not qualify the newly integrated stack. Landing order #2585 → #2583 → this PR.
Nov20 follow-up: current combined-head Windows harness failed before capture assertions at the fixture's two-second Python startup wait (job136191916725). The fixture now waits for actual readiness with a bounded10s startup deadline, reports early child exit/stderr immediately and removes listeners/timer on completion. This deliberately changes the test-only startup allowance, not production capture timing or session/metadata/frame assertions. Controlled2.2s startup fails on the old fixture and passes on the repair; an actual missing-script child fails immediately with its Python stderr. Full local harness322pass/5existing skips and65-file manifest pass. New Windows/current-head CI remains pending; the original failure is retained.
Footprint readback: npm dry-run reports479,863bytes unpacked and158,543bytes compressed. The actual workflow compares unpackedSize against491,520bytes and rejects source maps. Test-only readiness changes are excluded from packaged content.