Repository navigation
Test project: the two meetup triggers for leaving and cancelling - #323
Conversation
Authorized by the owner on 2026-10-14, so that leaving and cancelling a meetup can be tested with many people at once on the test project: onParticipantDeleted takes a leaver off the count, and onMeetupUpdated tells everyone on the roster that the meetup is cancelled. Neither binds a secret, calls out or runs on a schedule; both only read and write Firestore. The entry now expects 41 functions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0fe0f8f061
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onParticipantDeleted: meetups.onParticipantDeleted, | ||
| onMeetupUpdated: notifications.onMeetupUpdated, |
There was a problem hiding this comment.
When the many-user scenario targets petnote-devtest, CLOUD is true and functions/scripts/scenario-many-users.mjs still unconditionally skips the participant deletion/rejoin checks at lines 639–643 and the cancellation-notification check at lines 687–690. Since skipped checks do not affect the script's exit status, a cloud run can report success without exercising either newly exported trigger, defeating the stated purpose of this change; update those cloud branches now that the functions are available.
Useful? React with 👍 / 👎.
Adds two functions to the test project's entry (
functions-testcloud/index.js). The owner authorized them on 2026-10-14, so that leaving and cancelling a meetup can be tested with many people at once.onParticipantDeletedonMeetupUpdatedThey were audited the same way as the earlier ones: neither binds a secret, calls out, or runs on a schedule, and both only read and write Firestore. The entry's guards still refuse secrets and schedules, and its expected count goes from 39 to 41.
Both are deployed to
petnote-devtestonly, with--only functions:testcloud:onParticipantDeleted,functions:testcloud:onMeetupUpdated.🤖 Generated with Claude Code