Repository navigation
Scenario: leaving and cancelling a meetup, on the test project too - #324
Conversation
The test project has onParticipantDeleted and onMeetupUpdated now (#323), so the leave count, the freed places and the cancellation notice run there as well instead of being skipped. Half the crowd joins the second meetup before it is cancelled, so the notice is checked for a roster of a hundred and not one or two. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bf8d42af3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| made.meetups.push(roomyId); | ||
| const joining = Promise.all(crowd.map((u) => call(u, "joinMeetupCallable", { meetupId: roomyId, petId: petIds[users.indexOf(u)] }))); | ||
| const joinRoomy = (u) => call(u, "joinMeetupCallable", { meetupId: roomyId, petId: petIds[users.indexOf(u)] }); | ||
| const firstIn = (await Promise.all(firstHalf.map(joinRoomy))).filter((j) => j.ok && j.result?.success !== false).length; |
There was a problem hiding this comment.
If any of these pre-cancellation joins are rejected or fail, firstIn is only reported in diagnostic text and the later notification assertion derives its recipients from the reduced roster. In the extreme case where every join fails, toTell is empty and toTell.every(...) passes vacuously, so all cancellation checks can pass without testing the large-roster fan-out this change is intended to cover. Assert that firstIn === firstHalf.length before starting the cancellation race.
Useful? React with 👍 / 👎.
The test project now has
onParticipantDeletedandonMeetupUpdated(#323), so three meetup checks infunctions/scripts/scenario-many-users.mjsrun there instead of being skipped:Half the crowd now joins the second meetup before it is cancelled. That way the notice is checked against a roster of about a hundred people, not one or two.
On the test project, 200 people, all 19 checks pass:
🤖 Generated with Claude Code