Repository navigation
Status: pet names and photos reach their copies, and organizers' names - #328
Conversation
The pet sync the owner approved (#325) and the organizer name it turned up (#326), how they were tested (#327), why no old data needed fixing, their production deploy, and the leave and cancel checks now run on the test project (#323, #324). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30006bd8a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **问题**：宠物改名或换头像以后，它以前的帖子、别人的关注列表、聚会名单和打卡记录还显示旧的名字和头像，网页版也一样。原因是这几处各存了一份，改宠物资料时不跟着改；人改名有专门的同步，宠物没有。你 10-14 晚同意修。 | ||
| - **修法（#325）**：新增 `onPetUpdated`，宠物的名字或头像一变，就把这 4 处换成新的。 |
There was a problem hiding this comment.
Check-in documents do not contain a pet-avatar field: checkInCallable stores only petId and petName, and syncPetCopies updates check-ins with only { petName: name }. Therefore an avatar-only change does not modify old check-in records, contrary to the claim here that both old names and avatars in all four locations are replaced. Distinguish the name-only check-in synchronization from the name-and-photo synchronization for posts, follow lists, and meetup rosters.
Useful? React with 👍 / 👎.
| - 测试项目上 200 人：一只有 199 个关注者的宠物被连改两次名字和头像，202 处（2 条帖子、199 份关注列表、1 份聚会名单）全是最后一次的，帖子数不变（#327）。 | ||
| - **旧数据不用补**：只读数过，正式环境里带宠物的 8 条帖子都已经是最新的；关注列表、聚会名单和打卡里还没有带宠物的记录。 | ||
| - **上线（17:39 左右，你在自己的终端里跑的）**：正式环境从 67 个函数变成 68 个。新函数 `onPetUpdated` 状态正常，`onUserUpdated` 版本号加 1、配置没变；线上代码和部署包逐字节相同，之后没有报错。 | ||
| - **退出聚会和取消聚会**：你批准把这两个函数加到测试项目上（#323）后，云端 200 人也测过了：5 人同时退出，人数从 20 变 15；185 人抢空出的 5 个名额，正好进 5 个；名单上有 101 个参加者时取消，101 人都收到通知（#324）。 |
There was a problem hiding this comment.
In the 200-user scenario, the roster count includes the organizer, but scenario-many-users.mjs explicitly removes that organizer from toTell, matching onMeetupUpdated, which never notifies the cancelling organizer. A roster of 101 therefore verifies delivery to 100 non-organizers, not 101 people; the current wording overstates the notification coverage recorded by this test.
Useful? React with 👍 / 👎.
Adds a section to
STATUS.mdfor 10-14 evening:🤖 Generated with Claude Code