Repository navigation
Conversation
…ranxianglei#7113) dsh replaces a patch row's whole config and compaction-basic defaults auto to true, so any layer applied after bili that restates id compaction-basic silently re-arms native auto-compaction; the first symptom is a landed checkpoint destroying the fold base. The gate entry now scans the composed loader tree once the loader is available (optional, never a hard dependency) and logs one loud line naming the offending row and the fix. Detection is pure and covered both ways: healthy declaration silent, dropped auto reported, stock-disabled web row silent, unrelated rows ignored.
The type is only referenced inside the module; the repo's unused-exports gate rejects exported types with no external consumer.
|
CI 修复( 本地:typecheck ✅ / 22 用例 ✅ / build ✅ / unused-exports ✅。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 查重:不重复 — 在途 [PR] 中只有本 PR 针对 #7113 / host-plane auto-false 告警;最接近的是 #5994(PR #5996,反方向:bili-native 被禁用时恢复 native compaction),方向与机制均不同。 标签: 已给 source issue #7113 补 审核结论:无阻断发现,可合(待 6 个 test 分片转绿)。 ① 方向关:issue 要求「启动时读最终 composed 的 compaction-basic,enabled 且 ② 回归关(触碰路径的既有行为逐项清点):
③ 宿主侧验证(CI 判不了的部分,对真实 dsh 宿主 v0.1.1-rc.2 逐项核对,issue 实测于 0.2.2-rc.4): ④ 测试有效性:8 用例、双向(healthy→不报 / 丢 auto→按 id 报 / config 整体被换→报 / disabled 行→不报 / 噪声输入 / 告警文本 / 软注入 wiring / 无 loader 时 service 仍发布),断言均为真(deepEqual/match),非恒真。缺口:无真实 dsh 宿主 e2e pin(PR 用 ⑤ diff 整洁度:3 文件 +158/−3,每行都与本 PR 目的相关;第二 commit 是 unused-exports 门禁的正当修复,标注清楚。代码质量(命名/死代码/重复/错误处理/魔法值/注释/风格)逐项过,达标。 非阻断发现(记录在案,留给作者裁量,未动分支):
CI(13:11 实时读镜像缓存):30 checks,0 failed,6 pending——全部 6 个是 八问
判定:可合——等 6 个 test 分片转绿即可;上述三条非阻断发现记录在案,由作者裁量。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) CI 终态更正(上一条 13:11 的读取已过时):30 checks,29 绿,1 红—— 该红为继承性失败,与本 PR diff 无关(已逐层核实):
审核结论不变:无阻断发现,该红不属于本 PR。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 收工摘要(本会话全部交付已落地,详见 floor 4 八问 review 与 floor 6 CI 更正):
本 PR 代码侧无待办,等 CI 转绿 + 人工合并。 |
唯一红是 master 侧已修的测试可移植性缺陷,本分支 base 没带上
根因在 master 侧,且 master 已经修了: 本分支的 base 停在 已处理
等新 head 的 CI。若 |
(ai: vllm-qwen/qwen3.8-27b) CI re-verified live: the PR is fully green — nothing left to fix this run.
No code changes were made this run — no pushes. Closure note posted in #4599. 八问
结论:CI 全绿(run 44254859703 success),本 PR 无 CI 阻塞,等人工合并。 |
Closes #7113.
What & why
dsh.bundle.patch.ymlkeeps native auto-compaction down with:A dsh patch replaces a row's whole
config, and@deepseek-ai/dsh-compaction-basicdefaultsautototrue. So any layer applied after bili that restates- id: compaction-basic— a hand-written profile patch, a later bundle (installs append), a partial#2474snapshot, or an innocent-lookingthresholdRatiotweak — silently re-arms native compaction. The first symptom is usually a landed checkpoint that destroys the fold base; nothing warns in between.Measured on a headless profile (
--dump-config, bili at master, dsh0.2.2-rc.4):Web profiles are unaffected (that row is
disabled: truebydsh-web-appitself), so the exposure is headless / acp / sdk.Fix
The gate entry scans the composed loader tree once a loader is available and logs one line when the override is gone:
hostPlaneRowsMissingAutoFalse(entries)— pure: reports enabledcompaction-basicrows whoseconfig.auto !== false, keyed by entry id; stock-disabled rows, unrelated rows and non-object configs are ignored.hostPlaneOverrideLostWarning(ids)— the one-line alarm: names the row, says a later patch layer replaced the config, and gives the fix (restateauto: falsein the last row that touches that id).dsh-compaction-gate.tscalls it fromctx.inject(['loader'], …)— deliberately optional: a hardloaderdependency would restore the [dsh] Disabling the plugin permanently bricks dsh session creation - the bundle patch inject gate has no fallback (0.1.199 / dsh 0.2.1-rc.2) #3662 failure mode (this entry pends, the four presets wait forever on the service it never publishes).No self-heal on purpose: rewriting a user's patch row at boot would fight the "patches replace config" design, and this issue is about the silence, not about overriding the operator.
Tests
tests/issue7113-auto-false-boot-check.test.ts(8 cases, both directions per the gate discipline):auto:false→ not reported; droppedauto→ reported by id; config replaced entirely → reported;auto: falsefix;applyinjects['loader']softly (not as a hard dependency),hostPlaneWarningForis silent without a loader and on a healthy tree, and non-null on a dropped override;Pre-flight
npm run typechecknode --import tsx --test(issue7113+issue3354+issue3662)npm run builddist-import-annotations: OK,dist-external: OK)Scope
No config-surface change, no version bump. Docs untouched: the mechanism (
auto: falsein the bundle patch) is unchanged; this only reports when it was lost.