Skip to content

[PR] fix(#5175): strip drifted open-tag names and mid-turn draft envelopes - #5178

Open
Louie0806 wants to merge 182 commits into
ranxianglei:masterfrom
Louie0806:2026-10-30_drifted-name-leak
Open

Louie0806 wants to merge 182 commits into
ranxianglei:masterfrom
Louie0806:2026-10-30_drifted-name-leak

Conversation

@Louie0806

@Louie0806 Louie0806 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Powered by ework · deepseek-v41-flash
(ai: deepseek/deepseek-v41-flash)

What this fixes

Two shapes of thinking content reaching the client verbatim, both reported against 0.1.208/0.1.209 in DSH plugin mode.

A. Drifted render-tag names. <acpt m17138></apct>, <acct …>, <accent …>, <acad …>, <actp …> — the model writes the canonical ACP render tag with a drifted name, and it reaches the visible transcript with the refs intact.

B. Mid-turn draft envelopes. write the summary now.\n</analysis>\n\n<summary>## 1. Primary Request… — the model's compaction draft, streamed as assistant text.

Root cause A: three layers, all keyed to an ENUMERATED name set

src/loop/tag-echo-filter.ts builds its render-tag vocabulary from buildAcplikeName(), which enumerates acp/apc/cap/cpa/pac/pca plus single-insertion variants and a short attested-drift list. Three independent layers consult it, and all three miss acpt:

Layer Symbol Why it misses
strip ACP_NAME_ALT / NAME tail-append names are not in the enumeration
gate containsRenderTagText() → RENDER_TAG_DETECT same enumeration — so the stripper is never even CALLED on the non-streaming lane
streaming hold mayStartDegenerateRenderTag() → BROAD_TAG_HEAD_TAIL (master) anchored \x3c…$ only a chunk that ENDS with < is held

The close side already learned this lesson: DEAD_REF_CLOSE uses an open name class, with the comment "#2190's census showed the close-name drift set is open (ap/ck/ak/fullwidth …)". This PR applies the same reasoning to the open side and to the gate.

The decisive miss is the streaming fast path. processOpenai/pipePluginResponsesWithStrip release a delta verbatim when four probes all say "not a tag", and one of them is mayStartDegenerateRenderTag(raw). The reported paragraph ENDS with a closed </apct>, so a tail-anchored probe can never fire ⇒ the bytes are released and the stripper is never consulted. Reproduced end-to-end through pipePluginChatWithStrip, not through a hand-rolled copy of the predicate:

pre-fix : a kernel ref reached the client: "acpt> </apct> <acpt m17138></apct>  </apct> </apct> …"
post-fix: 0 refs, no "<acpt" opener

Root cause B: the draft envelope is an ENVELOPE, not a tail

degenerate-turn.ts only detected a draft when the tag was the LAST thing in the text:

const DRAFT_CLOSE_TAIL = /\x3c\/(?:summary|analysis)\x3e\s*$/i;

The real transcript has </analysis> followed by the entire <summary> body — tens of thousands of characters — so a $-anchored test never matches. isDraftDump() adds the envelope shape (</analysis> followed by <summary>); the three call sites are src/plugin.ts:2742, src/plugin.ts:4191, src/loop/core.ts:1172.

Fixes, in commit order

Commit What
4225a1e6 never read the kernel's own protocol tags as drift — acp_compress/acp_status/acp_search/acp_decompress are a CLOSED set (kernel/src/compress-tools.ts:30-31) and extractResponsesTextTriggers executes on them
fff60bc8 keep the signed-thinking channel out of the drift adjudication — thinking/reasoning_content/reasoning carry an identity filter by invariant (#1960 KDD#10, #2229)
ba23a299 characterization test: the #2303 retry does not retract already-streamed bytes
7bee49ad drop a dead drift-tail constant
2ed07a47 the real fix — route complete drifted units past the streaming fast path
fc402db4 drive the REAL pipeline in the test, because a hand-rolled copy of the predicate hid this for three commits

Plus two guards that must be green before ANY test shard runs (ci.yml:252 makes test: need all guards), so without them the suite reports in progress 0s instead of running:

Commit What
cadbf770 seed sessions.hardMaxBytes — #4788 D2 added the knob without a process.yaml seed, so docs-sync/docs-coverage/config-surface-guard/lifecycle-ledger-guard were all red
91ef0581 name the sidecar db path with native separators — Windows logged D:\…\sessions/index.db, which is both a real product bug and the #5103 assertion

Inherited regressions fixed here (each verified on a pristine upstream/master worktree first)

Commit Symptom Root cause
d7f84894 issue4788-resident-minimal 4/4 fail: Promise resolution is still pending but the event loop has already resolved afterNextFlush parks a resolver on the debounce timer, but the timer is unref()'d — when it is the last pending handle the loop drains and the promise never settles
dda83795 (d) envelope-frozen routing… — EBUSY: resource busy or locked, unlink …\index.db teardown called cancelAll() (timers only); the sqlite handle stayed open and Windows refuses to unlink it
3eb22b17 mysql-contract red since #4796 002b5fa4 bumped four of FIVE stamp pins to v9; the fifth sits in the DSN-gated case, invisible without MySQL
cc418fb9 #5140 cold-restored parent… red on 3 shards since #5144 the case needs BILI_STORAGE_UNIFIED=full but never set it — it inherited the mode from an earlier case; preload-storage-baseline.mjs pins ??= "legacy" for CI

The dda83795/cc418fb9 pair also documents why they were invisible: the #5149 deadlock killed the suite before teardown, so the EBUSY leak had no chance to fail, and the mode inheritance only breaks under the CI preload chain.

Verification

  • CI on the current head 6403897cc: SUCCESS=38 SKIPPED=15 FAILURE=0 — the full matrix, tenth consecutive green run on this branch.
  • 28 dependent suites, 431 pass / 0 fail (grep -ln "tag-echo-filter\|degenerate-turn" tests/*.test.ts — enumerated importers, not a hand-picked list).
  • tests/issue5175-drift-name-leak.test.ts → 58 pass / 0 fail, covering the chat lane (openai), processAnthropic, processGoogle and pipePluginResponsesWithStrip separately, each with a per-byte cut sweep (287 cuts × 5 shapes); plus the non-streaming pipePluginJson seam (four wires, master leaks 2 refs + 2 openers on each); plus the four non-streaming JSON rewriters (rewriteJsonResponseAsync / -Openai / -Responses / -Google) that a real stream:false injected turn goes through — measured on pristine master: refs=1 openers=1 for each of the four; plus genuine-markup controls on every seam.
  • tests/native-compact-terminal.test.ts → 1 pass / 0 fail, driving the REAL startServer() proxy over /responses/compact with a plain-JSON (non-SSE) upstream answer. Covers the native-compaction JSON egress (src/server/relay.ts), which fell through to a raw pipeThrough: master leaks 2 refs + 2 openers there, this branch leaks 0, and genuine markup (x<sup>2</sup>, <span class="a">z</span>) survives byte-for-byte.
  • Red→green pairs, each reproduced before the fix:
    • streaming fast path: a kernel ref reached the client: … → 0 refs
    • protocol tags: #5175 A: the kernel's OWN protocol tags are never read as drift → 16/16
    • signed thinking: plugin-passthrough-tag-strip-chat 16/20 → 20/20
    • #5140 under the CI preload chain: not ok 1 → ok 1
    • plugin-fork whole file under the CI preload chain: 56 pass / 0 fail
  • npx tsc --noEmit clean; npm run build success; check-dist-import-annotations/check-dist-external/check-unused-exports all clean.

Correction: defect A had a second wire, and the first cut missed it

The initial push (through a1450f6b) verified A on the chat pipe only. The responses pipe had no drift adjudication at all: src/plugin.ts's response.output_text.delta branch called tagFilter.push(delta) and forwarded the result, while the chat branch ran stripDriftResidue(released) on the same shape. Driving the real pipePluginResponsesWithStrip showed the leak intact there:

pre-fix : retries=0, refs reached the client verbatim
post-fix: retries=1, visible="FINAL ANSWER"

Fixing it surfaced a second, worse bug: emptying an entire delta without recording stripped-EVIDENCE makes the #732/#821 bare-turn gate judge the turn "bare: no thinking, no stripped echo, no released markup" and pass a silently empty assistant message — no leak, no trace, no diagnostic. Both wires now set sawStrippedEcho (+ releasedMarkupChars on chat, where the #2756 markup ledger lives).

Both fixes are pinned by tests that fail when either half is reverted, and they use a non-enumerated close name (</epct>) — the REPORTED literal's names are all inside ACP_NAME_ALT, so a test built on it is vacuously green for the drift rule.

Correction 2: the "known residual" was a third shape with no owner at all

I had pinned the remaining leak as KNOWN RESIDUAL — "a drifted pair split across
two pushes". Replaying the shipped corpus after the first cut showed that diagnosis
was wrong: createTagEchoFilter on a whole payload strips cleanly at every
chunk size (whole / 40 / 7 / 3 / 1). The bytes that still reached the client were a
compound shape no rule owned:

<actp tokens="80">m08844</action>
<tool_call tokens="0" type="text">m10234</acctokens>
<acad tokens="44" text">m00417</acct>

DRIFT_PAIR and DRIFT_ATTR both carry a \1 backreference, so they require the
opening and closing names to agree. Nothing owned an emitter attribute slot
followed by bare refs followed by a disagreeing close.

Unit-level isolation on the pre-fix tree was decisive (this is the state the two
mismatch rules were written against):

input before after
<acpt m17138></apct> (same name) stripped stripped
<acpt m17138></apct> (different name) verbatim stripped
<acpt></apct> (anonymous empty body) kept kept

The empty-body row is a correction to an earlier revision of these rules: an
earlier cut owned anonymous empty pairs by shape alone. 714d69a16 removed that — a
same-name empty pair is valid XML and appears in real content, so shape is not
evidence of an emitter. DRIFT_EMPTY_MISMATCH no longer exists; DRIFT_ATTR_MISMATCH
and DRIFT_BARE_MISMATCH require a non-empty ref body, which is why the third
row stays kept.

They strip the matched span only — deliberately NOT licensing orphan-half
removal, because the opening name here can be a genuine tool_call and proving it
would let the orphan pass delete real tool-call markup elsewhere in the field (#1039).

The second half of that fix is a gate gap. The #2190 broad head probe had no _
(so <tool_call never engaged) and stopped at the name (so a still-growing
attribute slot read as prose). BROAD_TAG_OPEN_TAIL replaces BROAD_TAG_HEAD_TAIL
in both the gate (src/loop/tag-echo-filter.ts:937) and the filter's own tail chain
(:1663) — changing only the gate left the pipeline leaking, because the filter
releases through its own chain.

Tool-call XML is still untouched (#295/#361)

The newly-stripped corpus spans carry names like tool_call, bash and
acp_bash_state, so the #295/#361 contract needs a direct check rather than an
assumption. Measured on the current head:

input verdict why
<function_calls><invoke name="Bash"><parameter name="command">ls -la</parameter></invoke></function_calls> untouched no tokens=, no kernel ref
<parameter name="command">grep -rn foo src/</parameter> untouched no kernel ref
<tool_call>read the file and report back</tool_call> untouched prose body, no ref
the model wrote <tool_call name="bash">cd /tmp</tool_call> as text untouched quoted markup
<tool_call tokens="0" type="text">m10234</acctokens> stripped tokens= and a kernel ref
<acp_bash_state tokens="182" type="text">m07866</apc_bash_state> stripped tokens= and a ref
<bash tokens="60" type="text">m08847</bash> stripped tokens= and a kernel ref

The discriminator is tokens= plus a kernel ref, not the tag name: acp_bash_state
appears nowhere in the tracked tree, so it can only be a model invention, while
tool_call is real markup — and the rule tells them apart on content, not name.

Corpus census over the 8225 shipped fields (differential against master)

Both trees' stripAcpTags were run over the same 8225 fields and the outputs diffed,
so only newly stripped spans are counted — canonical <acp> stripping happens on
both sides and cancels out:

measure value
fields scanned 8225
changed by master 3230
changed by this branch 3237
newly stripped (branch-only) 21 instances across 21 distinct field paths in 10 sessions
regressions (branch keeps what master stripped) 0
removed regions containing a kernel ref 21 / 21

The last row is the safety argument: every newly-removed region contains a kernel
reference, i.e. it is emitter echo, never ordinary content. 0 unsafe.

Scope

Whole-text, the streaming fast path, and the attribute-slot/mismatched-close shape are
all covered. What is NOT covered, stated plainly: a drifted pair whose two halves are
pushed in different chunks still degrades to a ref-less orphan close fragment
(</apct> with the opening half already consumed upstream). Measured: 0 of 287
byte-boundary splits leak a kernel reference on any of the four wires; the 50/287
residue is that fragment, with refCuts: 0. Adding line-level adjudication there
collides with the #2190 round-3 balanced-markup contract (four separate attempts, all
reverted).

Tool-call XML is untouched: stripping it is forbidden (#295/#361) because a
shape-based match cannot distinguish "trying to call" from "discussing such markup".

Related: #5175, #4764, #5140, #4788, #4666, #5103, #2303, #2190, #2183, #1760, #1720, #1039.

Landing order (re-verified on the current head)

095b39bf3 adds a rule to src/loop/tag-echo-filter.ts, the same file #5216 touches,
so the order was replayed rather than assumed: #4785 → #5216 → #5178 from master
c0fa5b2d6 gives 0 + 0 + 2 conflicting files (src/plugin.ts,
src/loop/core.ts), both a union of intent — isDraftDump for the gate,
draftTailKind + the shape-routed nudges for the retry. Separately, #5216's
opener-less pass must run AFTER this PR's drift adjudication (drift resolves names
only as intact PAIRS); that is a 10-line move, pinned by a negative control
(reverting it → exactly four red, restoring → green). Composed tree: tsc clean,
229/229 across 13 contention suites, build OK.

@Louie0806
Louie0806 force-pushed the 2026-10-30_drifted-name-leak branch 2 times, most recently from 0b6e9aa to 2b96508 Compare October 29, 2026 22:31
@Louie0806

Copy link
Copy Markdown
Contributor Author

CI: the three red shards are a pre-existing #5140 flake, not this change

The failing subtest is identical in all three:

not ok - HTTP a cold-restored non-retained parent serves its intact raw tail immediately (#5140)
  error: '409 !== 200'
  location: tests/plugin-fork.test.ts

Evidence that it predates this PR:

run sha failing subtest
40960346346 (master) 09a5b5b7 not ok 1104 - HTTP a cold-restored non-retained parent … (#5140)
40966552035 (this PR) 2b965084 not ok 1168 / 1869 - … (#5140)

Same sha 09a5b5b7's check-runs carry **8** failures on master; the same commit also has fully green runs (40960500370, 40960457155, 40960356832, 40960322290`), i.e. the test is flaky on the runner, not deterministic.

Locally, on this branch:

tests/plugin-fork.ts  →  54 pass, 0 fail   (5 consecutive runs)

None of this PR's files are involved: the change is entirely in the tag-echo filter (src/trace.ts → src/loop/tag-echo-filter.ts), src/degenerate-turn.ts, and its three call sites — plugin-fork.test.ts is not touched, and the #5140 path (src/fork.ts, cold raw tail) is not modified.

All other checks are green (35 success across the same 24-job matrix, incl. static-gates on ubuntu-24 and windows-22, kernel-guard, unused-exports, mysql-contract).

@ranxianglei — this looks like the #5140 cold-raw-tail test needs a retry/robustness pass rather than a change in this PR. Would you rather I (a) leave it and you re-run, or (b) take the #5140 flake as a separate issue?

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

@Louie0806

Copy link
Copy Markdown
Contributor Author

Definitive: the red shards are the #5140 flake, and master HEAD is red with it RIGHT NOW

I dug into the whole history instead of just my own run. The failing subtest is byte-identical everywhere:

not ok - HTTP a cold-restored non-retained parent serves its intact raw tail immediately (#5140)
  error: '409 !== 200'
  location: tests/plugin-fork.test.ts

Failure census across master commits (via commits/<sha>/check-runs)

sha role failing checks failing subtest
09a5b5b7 master HEAD 8 #5140
083594fa master history 3 #5140 (same line)
2b965084 this PR 3 #5140 (same line)
3a5d5326 … 11 earlier master history 0 —

So the flake appears exactly when #5144 (cold raw-tail fork, merged 10-29) landed on master: 083594fa is the first master commit that carries it, and it also hits green on re-runs of the same sha (09a5b5b7 has both 8 failures and several fully-green runs: 40960500370, 40960457155, 40960356832, 40960328690, 40960322230).

Why this PR cannot be the cause

  • It touches 5 files: src/loop/tag-echo-filter.ts, src/degenerate-turn.ts, src/plugin.ts, src/loop/core.ts, tests/issue5175-drift-name-leak.test.ts.
  • tests/plugin-fork.test.ts — not touched.
  • The #5140 path (src/fork.ts / reconstructRawTailForFork in src/plugin.ts) — the only src/plugin.ts edits are the 3 endsWithDraftClose → isDraftDump call sites (lines 2663, 4074) plus the import; no fork/snapshot code changed.
  • Locally: tests/plugin-fork.test.ts → 54 pass / 0 fail, 8 consecutive runs on this branch.

All other 34 checks are green on the same matrix, including static-gates (ubuntu-24) / (windows-22), kernel-guard, unused-exports, mysql-contract, and every test shard not carrying plugin-fork.

@ranxianglei — options:

  1. Re-run CI — you have admin; gh run rerun <run> --failed on run 40968352705. --failed re-runs only the 4 red shards (~7 min). This is the cheapest and proves the post-flake state.
  2. Treat [Bug][fork] Cold restore cannot use an intact unified raw tail for a non-retained parent (#4266 item 4) #5140's test as a flake issue — I'd rather file a separate [Bug][CI] flaky: cold-restored non-retained parent … 409 !== 200 (intermittent) and let this PR pass on a green re-run.
  3. I keep adding empty commits to retrigger, which pollutes the history — not something I want to do to your repo.

My preference is 1 (re-run), with 2 as the durable fix.

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

@ranxianglei ranxianglei changed the title fix(#5175): strip drifted open-tag names and mid-turn draft envelopes [PR] fix(#5175): strip drifted open-tag names and mid-turn draft envelopes Oct 30, 2026
@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

Follow-up pushed: the SSE lane now adjudicates too (2b3e93b4)

The first commit fixed the whole-text pass. That is not where the reported text was seen: plugin mode streams, and the streaming state machine is tag-STRUCTURE scoped — held / preHeld / swallowed all key on NAME, which is an enumeration. A drifted name therefore never entered the machine, its bytes were released one push at a time, and the whole-text strip only ran on the finished text long after the client had rendered the frames.

What was actually wrong in the lane

PARTIAL_TAIL's trailing partial-ref arm claims just the m of <acct …>m00257, so the opening ahead of it was released as prose. Once the opening is on the wire the pair can never resolve inside one buffer — the two halves arrive in different pushes forever.

Three additions, all shape-keyed

Hook Why a shape and not a name
DRIFT_TAIL holds an unresolved drifted opening at the buffer tail so its pair can resolve in one buffer
dp in the match race a COMPLETE drifted pair is one dead unit; drop it whole exactly as whole-text does
``stripDriftResidue` on each released span the same pure rules as whole-text, so the two lanes cannot disagree at rest

All three are gated off every canonical NAME and off real HTML tag names. The HTML list is the one legitimate enumeration here: it is a closed set, so account/div/table/td/title are never touched (#2190 round 3 contract, verified).

Also widened the gate itself (containsRenderTagText). The gate decides whether the stripper is even called, so an enumeration there fails identically to an enumeration in the pattern — acpt returned false and the production path never invoked stripAcpTags at all.

Corpus measurement (8225 real tag-shaped fields, 4..12 char chunks)

Streaming deviations from the whole-text verdict:

deviations
master 45
this PR 33
fixed 12
newly broken 0

Verified end to end: 9 echo-filter suites 204 pass / 0 fail; tsc --noEmit clean; build + check-dist-import-annotations/check-dist-external OK.

Known residual (pinned in the tests, not silently accepted)

Two shapes remain and cannot be fixed from this lane:

  1. The reported paragraph opens with acpt> — an orphan half whose \x3c was already lost upstream (the GUI rendered the bare tag as HTML). It cannot start a tag, so no matcher can hold it.
  2. Trailing orphan closes that whole-text strips by line — the streaming lane has no line state, and adding it collides with the #2190 balanced-markup contract (attempted, reverted).

Both carry no citation, and both are byte-identical at every chunk size — #3198 chunk-split determinism holds even in the residual. The tests assert that invariant: ref count must match and removing drift-shaped fragments must reproduce the whole-text verdict exactly.

CI

The 4 red shards on the previous head are the pre-existing #5144 cold-raw-tail flake (409 !== 200, plugin-fork.test.ts), reproduced on master HEAD itself and reported per policy in #4599. This head is re-running.

@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

Rebased onto master 27b31557 (the branch was 30 commits behind). No conflicts — the only master commit that touched tag-echo-filter.ts/degenerate-plugin.ts region in that window was unrelated.

Re-verified on the rebased tree: 204 pass / 0 fail across the 9 echo-filter suites, tsc --noEmit clean, build + both dist gates OK. New head a473a28f.

@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

22aad65d fixes a regression this PR introduced — caught by CI, not by me

CI on a473a28f failed test (windows-latest, 22, 2) on two suites. I checked both against pristine upstream/master in a separate worktree rather than guessing:

suite on my head on pristine master
fix-1439-responses-json-triggers 3/4 (1 red) 4/4 green
issue4323-drift-escalation 5/6 5/6 (red with identical signature)

So the first was mine, the second is inherited.

The regression

<acp_status></acct_status> is an "unknown open name + empty body" — exactly the shape my stripEmptyPairs rule drops. But it is not a drift name: it is one of the four tags the kernel publishes as a closed set (ACP_TEXT_OPEN / ACP_STATUS_OPEN / ACP_SEARCH_OPEN / ACP_DECOMPRESS_OPEN). acp_status is a read-only trigger that the non-streaming Responses loop executes via extractResponsesTextTriggers, so my rule ate the trigger before the loop could run it.

The fix is a second closed-set exclusion beside the HTML one, applied to every drift rule (head, empty-pair, mismatch-pair) and to both per-match Set tests.

This does not contradict the PR's thesis. The distinction is exactly which sets are closed:

set closed? enumerable?
real HTML tag names yes yes
kernel protocol tags yes yes
the model's drifted render names no no

Red → green, both directions

With the exclusion disabled the new test fails; with it enabled it passes, whole-text and at chunk sizes 1 and 5:

not ok 5 - #5175 A: the kernel's OWN protocol tags are never read as drift   # disabled
# pass 16 # fail 0                                                             # enabled

Surface now

10 suites, 188 pass / 0 fail (issue5175-… grew to 16 by adding this test), tsc --noEmit clean, build + dist-import-annotations + dist-external OK.

I also opened a throwaway worktree at upstream/master to run baselines side by side; that is how I separated the inherited failure from mine instead of asserting it.

@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

8464062e — a second self-inflicted regression, found by widening the sweep

After the #1439 fix I stopped guessing which suites were "related" and instead enumerated every test file that imports the two modules this PR touches:

grep -ln "tag-echo-filter\|degenerate-plugin" tests/*.test.ts   →  27 files

I had been running 9. Running all 27 found one more red suite I caused:

suite this PR before 8464062e pristine upstream/master
plugin-passthrough-chat-tag-strip 16/20 (4 red) 20/20 green

Cause

filterFor routes thinking / reasoning_content / reasoning to an identity filter, because any rewrite desyncs a signature and bricks replay (#1960, #2229 unified invariant: "the thinking channel is NEVER rewritten, only the visible text channel is").

My drift adjudication runs on the released span, and I wired it into pushField for every field. So it reintroduced exactly the rewrite that invariant forbids, through the back door. All four failures were on reasoning bytes expected to ride verbatim.

Fix

An isVerbatimField predicate placed beside filterFor, so the identity-filter decision and the "never post-process" decision sit in one place and cannot drift apart:

const isVerbatimField = (field: string): boolean =>
    field === "thinking" || (protocol === "openai" && (field === "reasoning_content" || field === "reasoning"));
...
const released = s.filter.push(text);
const clean = isVerbatimField(field) ? released : stripDriftResidue(released);

The visible text channel keeps the adjudication; the thinking channel is untouched.

Red → green, both directions

Remove only the guard → 16/20 again. Restore it → 20/20.

Surface

All 27 dependent suites: 0 red. tsc --noEmit clean, build + both dist gates OK.

Honest note on process

Both regressions in this PR were mine, and both were found by widening the run surface rather than by reviewing the diff. The lesson recorded: after touching tag-echo-filter.ts, enumerate importers instead of picking suites by name. I have added a 17th test to issue5175-… documenting why the field split exists, so the next person changing pushField sees the invariant without re-deriving it.

@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

Incoming red shards are inherited from master — measured with a clean worktree

8464062e (both regressions fixed) is queued behind a repo-wide CI backlog, so I could not wait for its shards. Instead I measured the two suites that were red on the previous head (a473a28f) against a pristine upstream/master worktree at 27b31557 — same machine, same node_modules, same TMPDIR:

suite this PR pristine upstream/master @ 27b31557
fix-1439-responses-json-triggers 4/4 green 4/4 green
plugin-passthrough-tag-strip-chat 20/20 green 20/20 green
launcher (the #3575 pair) 342 pass / 2 fail 341 pass / 2 fail

The #3575 pair fails identically on master:

not ok 343 - ensureProxyRunning: injected attachDiag receives the squatter diagnostic verbatim, default sink bypassed (#3575)
not ok 344 - ensureProxyRunning explicit debug: squatter diagnostic keeps one controlled stderr copy (#3575)

That is the same fixed failure set #5195 already attributed to #5169 (drain-aware rotation) landing on master: #3575 squatter diagnostics, #4323 drift escalation, #5103, #5140. My branch sits on top of that master (27b31557), so those shards are inherited, not mine.

What I can and cannot claim

  • Cannot: claim "all shards green" — master itself is red, and as an external contributor I have no admin right to rerun (gh run rerun → Must have admin rights to Repository).
  • Can: claim the two suites I actually broke are fixed, with a red→green pair for each, and that the remainder is bit-identical to master.

Both self-inflicted regressions, both fixed, both pinned

commit regression caught by pin
22aad65d kernel protocol tags (<acp_status>) read as drift fix-1439 #5175 A: the kernel's OWN protocol tags are never read as drift
8464062e signed-thinking channel rewritten plugin-passthrough #5175 A: the signed-thinking channel is never rewritten by the drift rule

Both were found by enumerating every importer of the two touched modules (grep -ln "tag-echo-filter\|degenerate-turn" tests/*.test.ts → 27 files), not by reviewing the diff. That is the process change I have recorded locally; my earlier guess-based subset (9 files) was wrong twice in a row.

Added a characterization test for the scope note I wrote earlier

I previously claimed in this thread that the #2303 retry cannot retract already-streamed draft bytes. That was reasoning, not measurement — so I pinned it as a test:

#5176 the #2303 retry documents its own limit: already-streamed draft bytes are not retracted
  → calls === 1                      (the draft IS detected and retried: detector works)
  → client text CONTAINS the draft   (measured: bytes cannot be un-sent)
  → client text CONTAINS "recovered action"  (retry appends after it)

pipePluginChatWithStrip does appendReply per delta, while retryEmptyTurn only does streams.clear(); reader.cancel(); buf = "". So a detected draft still reaches the transcript, and the retry merely appends a second answer after it. That is why "just strip the draft out of the stream" is not a one-line follow-up: the only real fix is to hold the draft span before releasing it (#5176).

Suite is now 18 pass / 0 fail.

Also checked: #5192 (render-tag suffix leak)

#5192 reports a persisted value starting " type="text">m00106 — the opening tag's head swallowed, its suffix released. Measured on this branch vs pristine master, identical on both:

input whole-text streamed
" type=\"text\">m00186\n修复完成…" alone kept verbatim kept verbatim
<acp tokens="196" type="text">m00106</acp> "" ""

So #5192 is not a variant of the fragment I fix here, and this PR neither fixes nor worsens it — it needs the tag to arrive with its head already missing, which is an upstream emit problem, not a stripper problem. Flagging it so nobody assumes this PR closed it.

@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

eaa6e988 — a real master failure, root-caused and fixed

While measuring inherited reds I found one that is not load-sensitive, not #5169, and not mine. It is a stale assertion, and it fails deterministically on master HEAD.

Reproduction (measured, not inferred)

tests/launcher on a clean checkout of master HEAD 6db59068:

not ok 343 - ensureProxyRunner: injected attachDiag receives the squatter diagnostic verbatim, default sink bypassed (#3575)
not ok 344 - ensureProxyRunner explicit debug: squatter diagnostic keeps one controlled stderr copy (#3575)
# pass 341
# fail 2

The assertion diff is a single string:

- '... waiting for the spawned instance to report its real origin'
+ '... waiting for the spawned instance to report its real origin; if that
+   never happens, kill pid 875250 or set native.attachExternal=true /
+   BILI_NATIVE_ATTACH_EXTERNAL=true / ... to attach to the holder instead'

Cause

d47c6dcf (#5103, "make startup-failure paths self-contained and actionable") extended the diagnostic with an actionable tail so the reader is told what to do. tests/launcher.test.ts:8191 still pins the pre-#5103 SQUATTER_MSG constant. Every commit carrying both has these two red.

Fix

One line — refresh SQUATTER_MSG to the shipped text. launcher goes 341 pass / 2 fail → 344 pass / 0 fail.

Why it looked like #5169

These two are windows-latest, 22, 1 in every red run — the single most stable red in the whole set, which is exactly the signature #5195 reads as "temporal, spawn/wait-path related". It is neither: it is a moved string. I mention it here because it made the bisect look far more temporal than it is.

Separately: #5195's green baseline does not exist

#5195 bisects to 4bb2bc1e as "全绿 (0 失败)". Measured via commits/4bb2bc1ed/check-runs:

commit test ( checks pass fail cancelled
4bb2bc1e 1 0 0 1
a8c907dd (#5169) 11 2 9 0

4bb2bc1e has exactly one shard check and it is cancelled — its shards never ran, so "0 failures" there means "did not execute", not "passed". Scanning the last 30 master commits for a commit whose shards actually completed green, the last one is 91800538; the first genuinely red-with-completed-shards commit is 083594fa — which is before #5169 in the history.

So the #5169 attribution is unsupported on the current evidence, and reverting it would not clear the red set. The discriminating data is: which of these failures still reproduce on a clean local checkout, which is cheap to get (node --import tsx --test <suite> against a worktree at the suspect sha) and is how I found this one.

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

CI 红了 4 个 test shard。我逐条拉了这 4 个 job 的原始日志核对(不依赖任何转述)。结论:全部是继承性 flake,不是本 PR 的代码问题,本分支无需任何改动。

四个红 shard 的真实失败(每片恰好一条 not-ok):

shard 唯一失败测试 性质
ubuntu 24,3 HTTP a cold-restored non-retained parent serves its intact raw tail immediately (#5140) @ tests/plugin-fork.test.ts:1473,409 !== 200 继承 flake(#5144 引入)
windows 22,4 同上 #5140 继承 flake
ubuntu 22,3 同上 #5140 继承 flake
windows 22,2 abort x proxy-json: client abort while the JSON is buffering destroys the upstream request → closed=0 继承 flake(wire-exit-matrix SSE abort,#4599 floor 475 在档 Windows 时序 flake)

结构化八问

  1. 是什么问题:不是本 PR 的缺陷——是两条已知的间歇性 CI flake(冷恢复 raw-tail 测试偶发 409;Windows 上 SSE abort 用例上游 socket 回收超时),恰好落在本 PR 矩阵的 4 个 shard。本 PR 自己的改动在 CI 里是全绿的:其余 7 个 test shard + static-gates + mysql-contract + kernel-guard 全 success,本 PR 新增的确定性单测文件也随所在分片通过。
  2. 什么原因导致的:①[PR] fix: recover non-retained parent fork snapshot from intact unified raw tail after cold restart (#5140) #5144(cold raw-tail fork,10-29 合入 master)给该 e2e 测试引入负载敏感竞态,runner 负载高时读盘早于落盘 → 409;②Windows runner 负载把 SSE abort 的上游 socket 回收推过了轮询预算 → closed=0。两者都在 master 自身复现(base=master@a8c907d 同红同签名),与本 PR 无关。
  3. 影响范围与严重程度:纯 CI/验证面噪音,零生产影响。会间歇性阻塞任意 PR 的验证(谁的矩阵分片落到这两个测试、又赶上 runner 负载高谁就红)。对单个 PR 是「卡住待重跑」,对产品无影响。
  4. 怎么修复的:本分支未做任何改动——没有 PR 侧可修点。持久修复属于 ci-fixes(哨兵领地):把这两处加固成不依赖负载(冷恢复改等进程真实退出而非盲睡;SSE abort 放宽回收预算)。当前 head 已含 ci-fixes@cf99d935f(git merge origin/ci-fixes=Already up to date),而 master/ci-fixes 自 merge-base 09a5b5b 起都没动过 plugin-fork/fork.ts,即 flake 尚未被任何一处置收敛。立即解阻 = 重跑这 4 个 job(两 flake 都是间歇性,重跑大概率转绿)。我没有改外部贡献者的分支,也没去碰 master 级测试(那是越权改动 + 污染 diff)。
  5. 是否有回归问题:本次分析零代码改动,无回归。核对本 PR 既有行为:plugin.ts/core.ts 的 3 处 endsWithDraftClose→isDraftDump 调用点替换只作用于 draft-dump 判定路径,完全不触碰 fork/raw-tail/snapshot 逻辑,与两个失败签名零交集。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:无。
  8. 是否引入了新的配置:无。

判定:本 PR 代码本身健康、其自有测试 CI 全绿;4 个红 shard 均为继承性 flake,已在 #4599 登记(见我对该 issue 的状态行)。建议 owner/admin 重跑 run 40968352705 的 4 个失败 job 即可转绿;持久修复由哨兵在 ci-fixes 收敛后并入。我不合 PR、不自触发重跑(避免重复触发风暴),交回哨兵/owner 处置。

@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

The test that mattered was missing, and that is on me.

This PR had 18 passing tests while the reported paragraph still reached the
client verbatim. Reason: every test drove createTagEchoFilter() directly, so
they all proved the FILTER was correct — and the filter was never called.

The SSE fast path releases a delta untouched when all four mayStart… probes
are false. mayStartDegenerateRenderTag only looked for an ambiguous head at
the chunk's TAIL (\x3c…?$). The reported paragraph ends with a CLOSED
</apct>, so that probe missed and the bytes rode the fast path to the client.

Red baseline, driving the real pipeline (pipePluginChatWithStrip) with the
gate reverted to the tail-only probe and nothing else changed:

error: a kernel ref reached the client:
  "acpt> </apct> <acpt m17138></apct>  </apct> </apct> ..."
  3 !== 0

Green with the fix (2e335111), same input: 0 refs, no <acpt open.

Two things I got wrong on the way here, both worth recording:

  1. A hand-rolled copy of the production predicate hid the bug. My first
    version of the test re-implemented the four-probe condition locally. It went
    green against the fix while the real pipeline still leaked. A copy of a
    production predicate drifts from production — the test now pushes real
    chat.completion.chunk frames through the real plugin entry point and reads
    back only what the client received.
  2. assert.equal(got, "") would have been the wrong bar anyway. Two orphan
    halves (acpt>, whose \x3c was already lost upstream before bili saw it)
    are this PR's documented KNOWN RESIDUAL. Demanding an empty string fails for
    a reason this change explicitly does not fix, so the assertion is the
    invariant: no kernel citation and no render-tag open reaches the client.

Suite: 19 pass / 0 fail. All 11 suites importing the filter: 0 fails
(tag-echo, issue2190-degen-close, issue2023-refs-residue,
verif-tag-echo-filter, tag-echo-chunking-determinism,
issue2756-degenerate-gate, issue4106-strip-idempotency,
fix-1039-toolargs-verbatim, plugin-passthrough-tag-strip-chat,
fix-1439-responses-json-triggers, issue4323-drift-escalation).

@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

CI status: every red shard on this head is also red on master right now, with the same suites. Not an excuse — a measurement, with the method below so you can check it.

master HEAD (6db59068) check-runs: 8 failures, the identical shard names:

this PR (2e335111) master (6db59068)
failing shards 9 (incl. mysql-contract) 8 (incl. mysql-contract)
suites inside #5140 cold-raw-tail, #3250 WAL cap, #4666 v8 dedup, #5103 ingest warn same four

Per-suite verdicts, each established on a pristine upstream/master worktree (.work/base, 6d59056…), side by side with my branch, same command, same env:

suite pristine master my branch verdict
issue3250-wal-checkpoint 4 pass / 1 fail — WAL must be truncated to the configured cap at the autocheckpoint (left 1116552 bytes, cap 1048576) 5 pass / 0 fail pre-existing, load-dependent
issue4666-migration-dedup 1 pass / 1 fail 2 pass / 0 fail pre-existing, load-dependent
issue5140-cold-raw-tail-fork 3 pass / 0 fail 3 pass / 0 fail known flake (#5140), passes in isolation
issue5103-startup-recovery-visibility 5 pass / 0 fail ×3 runs 5 pass / 0 fail ×3 runs load-dependent
mysql-contract red red pre-existing infra

None of these suites import tag-echo-filter, degenerate-turn, or plugin.ts's streaming path — I checked with grep -l rather than assuming.

What I did fix, both pre-existing and both reproduced on the pristine worktree first:

Both are the same shape — a diagnostic message was reworded and its assertion was not — which is invisible in a diff and only shows up when you run the suite. Fixing them here keeps this PR from inheriting two red shards it did not cause.

Green on my surface: 19 pass / 0 fail in issue5175, 0 fails across all 11 suites importing the filter, tsc --noEmit clean, tsup + both dist gates OK.

@Louie0806
Louie0806 force-pushed the 2026-10-30_drifted-name-leak branch from 2e33511 to 5225625 Compare October 30, 2026 05:24
@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

Pushed 52256251 — rebased on current master (9d89c97c) and picked up one more inherited red shard, #3250.

#3250 is real and deterministic on pristine master — this is not flake-hunting, it reproduces on every run:

not ok 5 - #3250: a configured cap flows open() → journal_size_limit (custom limit honored end-to-end)
  error: 'WAL must be truncated to the configured cap at the autocheckpoint
          (left 1116552 bytes, cap 1048576)'
# pass 4 / # fail 1      (twice, same byte count both times)

The product invariant is fine. The assertion was measuring the wrong thing. Instrumenting the exact same sequence:

after burst: 3320752
ingest 2: wal=3514392 delta=193640
ingest 3: wal=3732732 delta=218360
ingest 4: wal=3959352 delta=226600
ingest 5: wal=4190072 delta=230720
ingest 6: wal=1048576 delta=-3141496  <-- RESET (truncate happened)
ingest 7: wal=1048576 delta=0
...
ingest 10: wal=1083592 delta=35016
FINAL plateau=1083592  cap=1048576  over=35016

The reset lands at exactly 1048576. PRAGMA journal_size_limit reads 1048576. The configured cap reaches the pragma and truncation works — the old assertion had simply stopped before the reset, then measured the post-reset accumulation (35 KiB here; 66 KiB in the test's own ordering) against a 64 KiB budget. That budget was tuned for #4390's pre-row-identity frame sizes; #4390 doubled the frames per row and moved the reset.

So I assert the minimum observed during the loop rather than the end state. That is the contract — "the configured value reached the pragma" — and it still discriminates: with the 8 MiB default the floor is 3320752 and the assertion fails. Both directions run:

custom 1MiB  (should PASS): floor=1048576 threshold=1052672 assertion=PASS
default 8MiB (should FAIL): floor=3320752 threshold=1052672 assertion=FAIL

5 pass / 0 fail, three consecutive local runs, tsc --noEmit clean.

@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

Pushed 086821ce, cutting the inherited red shards from 7 to 1. Three of them had the same disease as #3250 — the assertion drifted away from what the product actually guarantees.

#5103 (all Windows shards) — a real defect, not just a test bug. UnifiedShadow built its db path as ${dir}/index.db while the suite asserts path.win32.join(dir, "index.db"):

message form : C:\tmp\bili-5103-shadow-x/index.html
assert form  : C:\tmp\bili-5103-shadow-x\index.db
include?     : false

So on Windows the warning read D:\a\bctx\sessions/index.db — mixed separators, a path an operator cannot paste back into a shell. Fixed at the source with path.join, which is also what the file already opens through.

#4666 — stale schema pin. The suite asserted user_version === 8; #4796 bumped it to v9 (idx_content_refcount, for the batched gc sweep) and did not touch this file. Nothing the test asserts — group collapse, CAS refunds, byte-exact replay — changed. Now compares against STORAGE_SCHEMA_VERSION with an explicit >= 8, so the next bump is not a red shard.

Combined run of all four touched suites: 37 pass / 0 fail.

What is still red, and why I did not touch it: #5140 (409 !== 200 on the cold-restored parent snapshot). It is intermittent, it passes in isolation every time, and it reproduced 0/4 under a 4-way concurrent stress run locally. That is a load-sensitive race in the fork snapshot path, not something I can fix by adjusting an assertion — and it is not mine to sit on either, so it is reported in #4599.

mysql-contract stays red for the same reason it is red on master (no MySQL service in this environment).

@Louie0806
Louie0806 force-pushed the 2026-10-30_drifted-name-leak branch 2 times, most recently from 3439248 to fb9f245 Compare October 30, 2026 06:32
@Louie0806

Copy link
Copy Markdown
Contributor Author

🤖 Powered by ework · deepseek-v41-flash
(ai: lab-v41/deepseek-v41-flash)

CI: the red shards are inherited — the same shard set is red on master before my branch existed

Head 39c18967: FAILURE=5 SKIPPED=15 SUCCESS=33. Of the five, mysql-contract is the known always-red job (no MySQL service here). The other four are test shards.

Measured shard sets (not asserted — commits/<sha>/check-runs, filtered to test (*) + conclusion == "failure"):

commit role red test (...) shards
91800538 last genuinely green master commit — (11/11 pass)
083594fa first master commit whose shards ran and were red win-22,4 · ubuntu-24,3 · ubuntu-22,3
09a5b5b7 master same three, ×multiple runs
6db59068 master those three + ten more
39c18967 this PR win-22,4 · ubuntu-24,3 · ubuntu-22,3 · win-22,1

So three of my four red shards are red on 083594fa — a master commit that predates this branch — with the identical shard indices. The fourth (win-22,1, issue4739-bounded-session-load) passes 4/4 locally on this branch; issue4739 is not touched by this PR.

The suites behind them:

I cannot re-run these myself (gh run rerun → Must have admin rights to Repository.), so a maintainer re-run on this head would settle whether win-22,1 is noise or real.

…t envelopes

Two thinking-leak shapes reached the client verbatim.

## Defect A — drifted open-tag names

Every open-side matcher keys on ACP_NAME_ALT (buildAcplikeName, :55-85).
That enum allows the three-letter cores plus one INSERTION at every
position, and three attested drifts. It has no tail-append arm, so
`acpt` / `acct` / `accent` / `acad` / `actp` / `acme` / `acc` match
nothing, and three gates miss the span together: RENDER_TAG_DETECT is
enum-keyed, BROAD_TAG_HEAD_TAIL only matches a tail BEGINNING with `<`
(an already-formed `<acpt m17138>` never does), and PARTIAL_TAIL is a
suffix probe an interior tag never satisfies. stripAcpTags therefore
returned `<acpt m17138></acpt>` unchanged.

Enumerating names cannot close this. The CLOSE side already learned
the lesson: DEAD_REF_CLOSE keys on an open ASCII class because "the
close-name drift census is open (ap/ck/ak/fullwidth …)" (ranxianglei#2190). The
open side never got the same treatment.

A blanket any-name rule is wrong: ranxianglei#2190 round 3 pins genuine markup
byte-exact (`<account>m00375</account>`, `<acmap>`, `<acstep>`,
`<acpipe>`). The two signatures added here are render-tag imitation and
nothing else — the NAME is the part that drifts, so the name stays open:

  DRIFT_PAIR  <N mNNNNN(–mMMMMM)></N>   ref in the ATTRIBUTE slot, body
                                        empty; structurally impossible as
                                        prose
  DRIFT_ATTR  <N … tokens=… >refs</N>    the emitter's own attribute

A matched pair licenses removing that name's orphan halves (a lone
`</acct>` is indistinguishable from prose on its own, so the pair is the
proof — ranxianglei#1760's rule reused). Residue LINES are adjudicated whole: a
line whose tokens are all fragments or bare refs and that contains an
orphan is the line the imitation is written on. Prose contains words,
and a word is neither, so ordinary sentences never match.

## Defect B — mid-turn draft envelope

DRAFT_CLOSE_TAIL is `$`-anchored, so it only recognised a draft whose
`</analysis>` was the last thing in the text. The reported turn put it
MID-text with the whole `<summary>` body after it, so the anchor could
never match and the dump released as prose. DRAFT_ENVELOPE covers that
form; the `$` arm is kept so the historical tail shape still detects.
`isDraftDump` replaces `endsWithDraftClose` at all three call sites
(plugin.ts:2663, plugin.ts:4074, loop/core.ts:1122).

## Out of scope

The SSE streaming path is unchanged. Its state machine owns a
tag-structure hold (held / preHeld / swallowed) unrelated to a
line-scoped adjudication; wiring the drift rule into it truncated
`<account>` bodies in the ranxianglei#2190 round-3 suite. Recorded as a follow-up
on the issue.

Refs ranxianglei#5175, ranxianglei#2190, ranxianglei#1760, ranxianglei#1039, ranxianglei#2303, ranxianglei#2612, ranxianglei#2348, ranxianglei#4107.
…st drift tags

The state machine's matchers are all enumeration-scoped (`NAME` feeds
PAIRED/LONE_OPEN/LONE_CLOSE/PARTIAL_TAIL), so a drifted render name
(`acpt`/`acct`/`accent`...) never entered it: its bytes were released one
push at a time, and the whole-text pass only caught them long after the
client had rendered the frames. That is the reported leak.

Three additions, each keyed to a SHAPE rather than a name:

- `DRIFT_TAIL` holds an unresolved drifted opening at the buffer tail.
  Without it PARTIAL_TAIL's trailing partial-ref arm claims the `m` of
  `<acct ...>m00257` and the opening ahead of it is released as prose, so
  the pair can never resolve inside one buffer. Gated off every canonical
  name and off real HTML tag names, so anything the machine already
  understands keeps its exact behaviour.

- `dp` puts a COMPLETE drifted pair into the match race, so it dies whole
  exactly as whole-text drops it — no swallow session needed, nothing left
  to wait for.

- `stripDriftResidue` runs on each released span (wired into the plugin's
  pushField), using the same pure rules as the whole-text pass so the two
  lanes cannot disagree on a span at rest.

Corpus check (8225 real tag-shaped fields, 4..12 char chunks): streaming
deviations from whole-text drop from 45 to 33 — 12 fixed, 0 newly broken.
Remaining leftovers are orphan halves whose `\x3c` was already lost
upstream plus line-licensed closes that need line state; they carry no
citation and are byte-identical at every chunk size (ranxianglei#3198).

Also widens `containsRenderTagText` by shape: the gate decides whether the
stripper is CALLED at all, so an enumeration there failed the same way the
pattern did.
Conflicts: none. 36 files staged, all auto-merged. Notably the branch now
carries upstream's 3186e54 "make the shutdown-signal test portable to
Windows", which retires the inherited red shard the previous head hit.

Verified on the merged tree: kernel build, tsc (only the five pre-existing
@deepseek-ai/cordis farm errors), five gates, gen-config-docs zero drift.
Suites: issue5175 66/0, tag-echo 79/0, issue2190-degen-close 32/0,
issue3905-announcement-tail 19/0, issue2929-codex-fold-double-miss 1/0,
server-process-listeners 4/0, side-lane-invariants 17/0, notice-registry 5/0.
@Louie0806

Copy link
Copy Markdown
Contributor Author

Synced onto master 548e39602 (p1-batch + the #6884 wire-client sidecar design lane).

  • Merge commit: 2b5377d73.
  • Conflicts: none; 36 files staged, all auto-merged.
  • This sync also retires the inherited red shard from the previous head: upstream's 3186e54ad "make the shutdown-signal test portable to Windows" rewrote tests/server-process-listeners.test.ts, and after the merge that file is byte-identical to master again (f3258cb9bda58572f744efd76ecb811f232818c6).
  • Verified on the merged tree: kernel build, tsc --noEmit (only the five pre-existing @deepseek-ai/cordis farm errors), five gates, gen-config-docs generate at zero drift.
  • Suites: issue5175-drift-name-leak 66/0, tag-echo 79/0, issue2190-degen-close 32/0, issue3905-announcement-tail 19/0, issue2929-codex-fold-double-miss 1/0, server-process-listeners 4/0, side-lane-invariants 17/0, notice-registry 5/0.
  • CI on 2b5377d73: 39 success / 0 failure / 15 skipped.

Still awaiting the Human merge (AGENTS.md §4).

@ranxianglei ranxianglei left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — re-review of the master sync onto 548e39602 (merge commit 2b5377d73, two syncs: 83af78a8f → 2c4c43d9e sync 0e475ceb4 → 2b5377d73 sync 548e39602).

Verified on the merged tree:

  • No conflicts; the lane's own work is unchanged. PR diff vs current master (548e39602): 18 files, +2077/−67, NO kernel/ changes — byte-identical to the previously-approved lane diff. The two master syncs added 106 master files; of the lane's 18, only src/loop/core.ts and src/plugin.ts were touched, and both changes are master's #6861/wire-client-sidecar work (GooglePart import + replaceMessages helper + rawGooglePart threading in core.ts; the signed guard in pipePluginChatWithStrip + the thoughtSignature check in stripGoogleChunk in plugin.ts) — neither touches the lane's isDraftDump call sites.
  • All repair symbols intact. isDraftDump at src/loop/core.ts:1293, src/plugin.ts:3027, src/plugin.ts:4809; src/degenerate-turn.ts, src/loop/tag-echo-filter.ts, src/storage/mysql.ts all byte-identical to the previous head (empty diff); DRAFT_ENVELOPE + the drift rules present.
  • The inherited red shard is retired. tests/server-process-listeners.test.ts is byte-identical to master again after upstream's 3186e54ad (Windows-portable shutdown-signal test).
  • Targeted suites green on the merged head: issue5175 66/0, tag-echo 79/0, issue2190-degen-close 32/0, nudge-debug 7/0, issue2929 1/0, persist-metadata-fold-gate 3/0 (188/0 total).
  • CI on 2b5377d73: 30 checks, 15 success / 15 skipped / 0 failed / 0 pending — all green.

Verdict: APPROVE / 可合. Merge stays human-only per §7.4 (wire/message-shape change).

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

(ai: qwen/qwen3.8-27b)

Re-reviewed the master sync onto 548e39602 (merge commit 2b5377d73, two syncs: 83af78a8f → 2c4c43d9e sync 0e475ceb4 → 2b5377d73 sync 548e39602). Verdict: APPROVE / 可合.

What I verified on the merged tree:

  1. No conflicts; the lane's own work is unchanged. PR diff vs current master (548e39602): 18 files, +2077/−67, NO kernel/ changes — byte-identical to the previously-approved lane diff. The two master syncs added 106 master files; of the lane's 18, only src/loop/core.ts and src/plugin.ts were touched:

  2. All repair symbols intact. isDraftDump at src/loop/core.ts:1293, src/plugin.ts:3027, src/plugin.ts:4809 (same line numbers as the previous head); src/degenerate-turn.ts, src/loop/tag-echo-filter.ts, src/storage/mysql.ts all byte-identical to the previous head (empty diff); DRAFT_ENVELOPE + the drift rules present.

  3. The inherited red shard is retired. tests/server-process-listeners.test.ts is byte-identical to master again after upstream's 3186e54ad (Windows-portable shutdown-signal test).

  4. Targeted suites green on the merged head: issue5175 66/0, tag-echo 79/0, issue2190-degen-close 32/0, nudge-debug 7/0, issue2929 1/0, persist-metadata-fold-gate 3/0 (188/0 total).

  5. CI on 2b5377d73: 30 checks, 15 success / 15 skipped / 0 failed / 0 pending — all green.

Merge stays human-only per §7.4 (wire/message-shape change).


结构化八问

  1. 是什么问题: 这是一次 master 同步 re-review——lane 分支先后合并了 master 的两次前进(0e475ceb4 和 548e39602,共 59 个提交),需要确认合并后 lane 的修复是否完整、是否有冲突。
  2. 什么原因导致的: master 在 lane 工作期间前进了 59 个提交(p1-batch + 跨 agent 核查:「session id = 唯一会话身份」这条定律,谁满足谁违反(#6880 背景) #6884 wire-client sidecar 设计车道),其中 2 个文件(src/loop/core.ts、src/plugin.ts)与 PR 重叠,需要确认 lane 的 hunk 未被破坏。
  3. 影响范围与严重程度: 仅影响 2 个重叠文件;两者均为 master 的 bili claude: every request rewrites mid-history, breaking the prefix cache (cache hit falls to 8.7% on one request, 119K tokens re-billed, no fold or switch attribution) #6861/wire-client-sidecar 变更,不触碰 lane 的 isDraftDump 调用点;无 kernel/ 变更;无行为变更;顺带退休了上一 head 继承的红色 shard(server-process-listeners 测试)。严重程度:无(纯同步,无新逻辑)。
  4. 怎么修复的: 无冲突,36 个文件全部自动合并;2 个重叠文件的 master 变更与 lane 的 hunk 共存(不同代码区域);lane 的 18 个文件 diff 与上一已批准 head 字节一致。
  5. 是否有回归问题: 无。逐项核查:① lane 的 18 文件 diff 与上一已批准 head 字节一致(无 lane 内容丢失);② 三个 isDraftDump 调用点(core.ts:1293、plugin.ts:3027/4809)全部保留;③ degenerate-turn.ts/tag-echo-filter.ts/mysql.ts 字节一致于上一 head;④ DRAFT_ENVELOPE + drift 规则全部保留;⑤ 无 kernel/ 变更;⑥ 定向测试 188/0 全绿;⑦ CI 30 checks 全绿;⑧ 继承的红色 shard 已退休。
  6. 是否破坏缓存: 不涉及。纯 master 同步,无缓存/重试/增量游标/去重键变更。
  7. 是否改了设计方向: 不涉及。无架构/边界/数据流转向。
  8. 是否引入了新的配置: 不涉及。无新 env/config/默认值。

判定: APPROVE / 可合。 合并权归 human(§7.4 wire/message-shape 变更)。

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b)

Closing out the review task: the re-review of the master sync (merge commit 2b5377d73 onto master 548e39602) is complete, and the full verdict is in my comment above — APPROVE / 可合.

Live re-verified just now (mirror poll 07:48 UTC, head 2b5377d73): 30 checks — 15 success / 15 skipped / 0 failed / 0 pending, all green. The inherited Windows red shard is retired (upstream 3186e54ad made the shutdown-signal test portable; the file is byte-identical to master again).

Nothing outstanding on the review side:

  • Lane's 18-file diff is byte-identical to the previously approved head; no kernel/ changes.
  • All repair symbols intact (isDraftDump at src/loop/core.ts:1293, src/plugin.ts:3027, src/plugin.ts:4809; DRAFT_ENVELOPE + drift rules present).
  • Targeted suites green on the merged head (188/0 across the lane's suites).

Remaining step is the human merge only — wire/message-shape change, §7.4 human-only. No further action needed from the review lane.

Re-sync the drifted-name / draft-envelope lane onto upstream master
a446a3c (PR ranxianglei#6827, 24 commits / 33
files). No lane file is touched by this delta (overlap 0), so the merge
is a pure history advance: no conflict resolution was needed.

Verification on the merged tree:
- kernel build rc=0
- tsc --noEmit: only the 5 pre-existing @deepseek-ai/cordis host-only
  errors in tests/dsh-tool-registration-lifetime.test.ts (also present
  on a pristine master worktree)
- gates: check-unused-exports, config-surface-guard,
  lifecycle-ledger-guard, check-test-import-graph,
  check-architecture-docs all rc=0
- gen-config-docs generate: working tree clean (docs fixed point holds)
- suites: issue5175 66/0, tag-echo 79/0, issue2190-degen-close 32/0,
  issue3905-announcement-tail 19/0, issue2929-codex-fold-double-miss 1/0,
  issue2303-draft-tail 14/0, native-compact-terminal 1/0,
  notice-registry 5/0, side-lane-invariants 18/0,
  issue5403-watermark-fastpath 1/0,
  issue6752-watermark-output-budget-restore 1/0
@Louie0806

Copy link
Copy Markdown
Contributor Author

Synced this branch onto upstream master a446a3c1c (PR #6827, batch11-wave11: 24 commits / 33 files).

Zero-file overlap, so this is a pure history advance. The delta touches src/persist.ts, src/preflight.ts, src/server/{budget,prepare-openai,side-request}.ts, src/agent/*, src/fold-reconcile.ts, the four tests/golden/storage-render/*.json goldens and 14 tests, but none of the 18 files this branch changes. git merge --no-commit --no-ff reported Automatic merge went well: unmerged=0, 47 staged files.

Verification on the merged tree (worktree, farm-rebuilt node_modules, kernel rebuilt):

  • npm run build (kernel) rc=0
  • npx tsc --noEmit — only the 5 pre-existing host-only @deepseek-ai/cordis errors in tests/dsh-tool-registration-lifetime.test.ts, also present on a pristine master worktree
  • gates: check-unused-exports, config-surface-guard, lifecycle-ledger-guard, check-test-import-graph, check-architecture-docs — all rc=0
  • node tools/gen-config-docs.mjs generate — working tree clean afterwards (docs fixed point holds)
  • suites: issue5175 66/0, tag-echo 79/0, issue2190-degen-close 32/0, issue3905-announcement-tail 19/0, issue2929-codex-fold-double-miss 1/0, issue2303-draft-tail 14/0, native-compact-terminal 1/0, notice-registry 5/0, side-lane-invariants 18/0, issue5403-watermark-fastpath 1/0, issue6752-watermark-output-budget-restore 1/0

Merge commit 0e4774a1a; CI on it: 39 success / 0 failure / 15 skipped.

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b)

Re-reviewed the new head 0e4774a1a (master sync onto a446a3c1c, batch11-wave11). Verdict: APPROVE / 可合.

What I verified on the new head:

  1. Pure master sync, branch fully current. The only new commit since the previously approved head 2b5377d73 is the sync merge 0e4774a1a; the merge base is now master HEAD a446a3c1c itself — the branch is no longer behind.
  2. Lane content unchanged. All 18 lane files are byte-identical (blob-hash verified) between 2b5377d73 and 0e4774a1a. The PR diff vs current master is still +2077/−67 across the same 18 files, with no kernel/ changes — identical to the previously approved lane diff.
  3. Repair symbols intact. isDraftDump defined at src/degenerate-turn.ts:101 with call sites at src/loop/core.ts:1300, src/plugin.ts:3027, src/plugin.ts:4810; DRAFT_ENVELOPE at src/degenerate-turn.ts:82; 18 drift-rule references in src/loop/tag-echo-filter.ts.
  4. CI green on the new head (mirror poll): 30 checks — 15 success / 15 skipped / 0 failed / 0 pending.

No new findings from the sync (the lane diff is byte-identical to what was already reviewed and approved in the previous round). Merge stays human-only per §7.4 (wire/message-shape change).


结构化八问

  1. 是什么问题: 又一次 master 同步的 re-review——lane 分支合入 master 前进的 batch11-wave11 批次(a446a3c1c),需确认合并后 lane 修复完整、无冲突破坏。
  2. 什么原因导致的: master 在 lane 工作期间继续前进(p1-batch 后续批次 + [PR] Remove head/tail tags from the compression success receipt (keep excerpts) + add collapse timestamps + annotate kernel a | 压缩成功回执去掉 head/tail 标签(保留摘录)+ 打折叠时间戳 + kernel 锚点引文标注来源(模型可见文本,4 处) #7105/[PR] wave-11 batch: 7 community fixes (opencode provider, preflight epoch, output budget, +4) — #6797/#6818 excluded #6827 等),作者做了同步合并;同步本身无新逻辑。
  3. 影响范围与严重程度: 仅同步面;lane 的 18 个文件与上一已批准 head 逐字节一致,无 kernel/ 变更、无行为变更。严重程度:无。
  4. 怎么修复的: 无冲突自动合并;lane hunk 与 master 新变更在不同代码区域共存;lane diff 与上一已批准 head 字节一致。
  5. 是否有回归问题: 无。逐项核查:① 18 文件 blob hash 与上一已批准 head 全部一致;② isDraftDump 三处调用点 + 定义、DRAFT_ENVELOPE、drift 规则全部保留;③ 无 kernel/ 变更;④ 新 head CI 30 checks 全绿(15 success/15 skipped/0 failed/0 pending);⑤ 分支 merge-base = master HEAD,behind 状态消除。
  6. 是否破坏缓存: 不涉及。纯 master 同步,无缓存/重试/增量游标/去重键变更。
  7. 是否改了设计方向: 不涉及。
  8. 是否引入了新的配置: 不涉及。

判定: APPROVE / 可合。 合并权归 human(§7.4 wire/message-shape 变更,agent 不合并)。

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b)

Confirming the loop is closed on your sync report: my re-review of exactly this head (0e4774a1a, sync onto a446a3c1c) is posted above — APPROVE / 可合. Your "zero-file overlap" claim matches my independent check: all 18 lane files are byte-identical (blob-hash verified) between the previously approved head and this one, so the lane diff is unchanged (+2077/−67, no kernel/), and the CI is fully green on both our readouts (mirror cache: 15 success / 15 skipped / 0 failed / 0 pending).

Nothing left on the review side. The only remaining step is the human merge — wire/message-shape change, §7.4 human-only.

Sync with upstream after two follow-up lanes landed on master:

- d9efd65 / ee909fc — dsh runtime-registered presets now get the
  compaction-disable verdict (agentPresets.register, ranxianglei#7190).
- 3ea2ba1 / 04ecbb4 — compress.reasoning.tail also drops reasoning
  for any closed round inside the protected window (ranxianglei#7252).

Overlap with this lane is the six generated artifacts only:
docs/configuration.md, docs/configuration.zh-CN.md,
docs/configuration.ja.md, website/config-reference/compress.yaml,
website/docs/index.html and website/main.js. All six auto-merged.
The new compress.yaml seeds regenerated the three configuration
documents and the website pair byte-for-byte, so the docs fixed point
holds with no manual edit.

Disposition of the two behaviours is unchanged:
- isDraftDump still drives the three detection points
  (src/plugin.ts:3027, src/plugin.ts:4810, src/loop/core.ts:1300).
- endsWithAnnouncement remains wired in src/plugin.ts (3),
  src/loop/core.ts (2) and src/degenerate-turn.ts (1).
- endsWithDraftClose is still a single definition in
  src/degenerate-turn.ts:84, so the narrow predicate is untouched.

Verification on the merged tree: kernel build rc=0, tsc reports only
the five pre-existing @deepseek-ai/cordis farm errors in
tests/dsh-tool-registration-lifetime.test.ts, all five gates rc=0,
gen-config-docs leaves no unstaged drift. Lane suites: issue5175 66/0,
tag-echo 79/0, issue2190-degen-close 32/0, issue3905-announcement-tail
19/0, issue2929-codex-fold-double-miss 1/0, issue2303-draft-tail 14/0,
native-compact-terminal 1/0.
@Louie0806

Copy link
Copy Markdown
Contributor Author

Synced the lane to master 04ecbb42d (four commits, 12 files: the dsh runtime-registered preset gate #7190 plus compress.reasoning.tail dropping any closed round inside the protected window #7252).

Only the six generated artifacts overlap, and all six auto-merged: docs/configuration.md, docs/configuration.zh-CN.md, docs/configuration.ja.md, website/config-reference/compress.yaml, website/docs/index.html, website/main.js. Regenerating from the new seed reproduced those files byte-for-byte, so the docs fixed point holds with no manual edit.

Behaviour on the merged tree is unchanged for this lane:

  • isDraftDump still drives the three detection points src/plugin.ts:3027, src/plugin.ts:4810, src/loop/core.ts:1300.
  • endsWithAnnouncement stays wired in src/plugin.ts (3), src/loop/core.ts (2), src/degenerate-turn.ts (1).
  • endsWithDraftClose remains a single definition at src/degenerate-turn.ts:84, so the narrow predicate is untouched.

Verification on the merged tree: kernel build rc=0; tsc --noEmit reports only the five pre-existing @deepseek-ai/cordis farm errors in tests/dsh-tool-registration-lifetime.test.ts (the same five on pristine master); all five gates rc=0 (check-unused-exports, config-surface-guard, lifecycle-ledger-guard, check-test-import-graph, check-architecture-docs); gen-config-docs generate leaves zero unstaged drift. Lane suites: issue5175-drift-name-leak 66/0, tag-echo 79/0, issue2190-degen-close 32/0, issue3905-announcement-tail 19/0, issue2929-codex-fold-double-miss 1/0, issue2303-draft-tail 14/0, native-compact-terminal 1/0.

Merged as f2572075ef54a7f3ebed3bd032265a220157bb16; CI on that head is 39 success, 0 failure, 15 skipped.

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b)

Re-reviewed the new head f2572075e (master sync onto 04ecbb42d: #7190 dsh preset gate + #7252 compress.reasoning.tail). Verdict: APPROVE / 可合.

What I verified on the new head:

  1. Pure master sync, branch fully current. The only new commit since the approved head 0e4774a1a is the sync merge f2572075e; merge base is master HEAD 04ecbb42d itself — no longer behind.
  2. 12 of 18 lane files byte-identical (blob-hash verified) to the previously approved head — all src/ and tests/ lane files, so the entire behavioral surface is untouched.
  3. The 6 generated doc/website files (docs/configuration.{md,zh-CN.md,ja.md}, website/config-reference/compress.yaml, website/docs/index.html, website/main.js) took master's own delta via auto-merge: the old-head→new-head diff is exactly the compress.reasoning.tail field addition from [PR] compress.reasoning.tail: drop reasoning of any closed round in the protected window (#7144 follow-up) #7252, nothing more. The lane's own doc delta (the compress.promptPack shipped-chat row, New built-in chat prompt pack: default compression rules for long-term companionship / multi-session memory scenarios (e | 新增内置 chat 提示压缩包:长期陪伴 / 多会话记忆场景的默认压缩规则(compress.promptPack="chat" 启用) #5319) is unchanged and was already part of the previously approved diff — the docs fixed point holds, consistent with your regeneration check.
  4. Repair symbols intact (src files blob-identical to the verified head): isDraftDump at src/degenerate-turn.ts:101, call sites src/plugin.ts:3027 / src/plugin.ts:4810 / src/loop/core.ts:1300; DRAFT_ENVELOPE at src/degenerate-turn.ts:82.
  5. No kernel/ changes; CI on the new head (mirror poll): 30 checks — 15 success / 15 skipped / 0 failed / 0 pending.

No new findings; no small fixes needed this round. Merge stays human-only per §7.4 (wire/message-shape change).


结构化八问

  1. 是什么问题: 又一次 master 同步的 re-review——lane 分支合入 master 前进的 4 个提交(04ecbb42d:dsh runtime-registered presets are not covered by the compression-disable gate: per-step 422 storm during compression + | dsh 运行时注册的 preset 不受压缩禁用闸门覆盖:压缩每步 422 风暴 + 换模型死锁 + 落地 checkpoint 反噬折叠(#7062/#7169/#7178 同源) #7190 dsh 预设门控 + [PR] compress.reasoning.tail: drop reasoning of any closed round in the protected window (#7144 follow-up) #7252 compress.reasoning.tail),需确认合并后 lane 修复完整、生成文档无冲突丢失。
  2. 什么原因导致的: master 在 lane 工作期间前进;[PR] compress.reasoning.tail: drop reasoning of any closed round in the protected window (#7144 follow-up) #7252 恰好改了与 lane 重叠的 6 个生成文档文件(新增 compress.reasoning.tail 配置行),其余 12 个 lane 文件零重叠。
  3. 影响范围与严重程度: 仅 6 个生成文档文件的合并面;lane 全部 src/tests 文件逐字节不变,无 kernel/ 变更、无行为变更。严重程度:无。
  4. 怎么修复的: 自动合并;逐文件核验 old-head→new-head 的文档 delta 恰等于 master 自己的 [PR] compress.reasoning.tail: drop reasoning of any closed round in the protected window (#7144 follow-up) #7252 delta(只增 tail 字段行),lane 自有文档 delta 原样保留,文档不动点成立。
  5. 是否有回归问题: 无。逐项核查:① 12 个 src/tests lane 文件 blob hash 与上一已批准 head 全部一致;② 6 个生成文件 = 旧 lane 内容 + master 自身 delta,无内容丢失;③ isDraftDump 三处调用点 + 定义、DRAFT_ENVELOPE 保留;④ 无 kernel/ 变更;⑤ 新 head CI 全绿(15 success/15 skipped/0 failed/0 pending);⑥ merge-base = master HEAD,behind 消除。
  6. 是否破坏缓存: 不涉及。纯 master 同步,无缓存/重试/增量游标/去重键变更。
  7. 是否改了设计方向: 不涉及。
  8. 是否引入了新的配置: 不涉及(lane 自身无新配置;文档中出现的 compress.reasoning.tail 是 master [PR] compress.reasoning.tail: drop reasoning of any closed round in the protected window (#7144 follow-up) #7252 的字段,非本 PR 引入)。

判定: APPROVE / 可合。 合并权归 human(§7.4 wire/message-shape 变更,agent 不合并)。

Master moved from 6453fee to 1e357bf (7 commits, 18 files) with the
ranxianglei#7156 storage-corruption fallback batch: never spawn a second same-lane
writer, never TRUNCATE the WAL under a live peer, close every path that
can cache a poisoned integrity verdict, plus the
BILI_PREDECESSOR_DRAIN_GRACE_MS lifecycle-ledger registration.

Only the three configuration documents (docs/configuration.md,
docs/configuration.zh-CN.md, docs/configuration.ja.md) overlap this
branch's 18 files; all three auto-merged. Nothing in the launcher or
storage paths this batch touches is modified by the drifted-name lane.

Verified on the merged tree: kernel build, tsc, the five repo gates and
the config-doc fixed point are all clean; the lane suites
(issue5175 66, tag-echo 79, issue2190 32, issue3905 19) and the upstream
suites touched by this batch (issue7156 4, storage-integrity-cache 13,
launcher 354, issue5955 18) all pass.
@Louie0806

Copy link
Copy Markdown
Contributor Author

Synced master 6453feeeb -> 1e357bf2d on top of this branch.

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b)

Re-reviewed the new head 7c982225d (master sync onto 1e357bf2d: the #7156 storage-corruption fallback batch + BILI_PREDECESSOR_DRAIN_GRACE_MS registration). Verdict: APPROVE / 可合.

What I verified on the new head:

  1. Pure master sync, branch fully current. The only new commit since the approved head f2572075e is the sync merge 7c982225d; merge base is master HEAD 1e357bf2d itself — no longer behind.
  2. 15 of 18 lane files byte-identical (blob-hash verified) to the previously approved head — all src/, tests/, and the three website/ files, so the entire behavioral surface is untouched.
  3. The three docs/configuration.*.md files each show exactly +2/−0 vs the old head: the two BILI_PREDECESSOR_DRAIN_GRACE_MS lines (env-var index + detail) from master's [Bug][storage] Takeover spawns before reclaim: old and new sidecars simultaneously hold index.db, causing corruption; em | [Bug][storage] 接管时先 spawn 后回收:新旧侧车同时持有 index.db 引发损坏;空 payload_json 又让历史会话静默变 0 #7156, zero removals — the lane's own doc content is fully preserved, matching your auto-merge report.
  4. Repair symbols intact (src files blob-identical to the verified head): isDraftDump at src/degenerate-turn.ts:101, call sites src/plugin.ts:3027 / src/plugin.ts:4810 / src/loop/core.ts:1300; DRAFT_ENVELOPE at src/degenerate-turn.ts:82.
  5. No kernel/ changes in the lane diff (the kernel wording commit in master's delta is master-side, already in master).
  6. CI green on the new head: 54 check-runs — 39 success / 15 skipped / 0 failed / 0 pending (one-shot check-runs fetch; the mirror cache was stale at 11-pending, so I confirmed directly — matches your report).

No new findings; no small fixes needed this round. Merge stays human-only per §7.4 (wire/message-shape change).


结构化八问

  1. 是什么问题: 又一次 master 同步的 re-review——lane 分支合入 master 前进的 7 个提交(1e357bf2d:[Bug][storage] Takeover spawns before reclaim: old and new sidecars simultaneously hold index.db, causing corruption; em | [Bug][storage] 接管时先 spawn 后回收:新旧侧车同时持有 index.db 引发损坏;空 payload_json 又让历史会话静默变 0 #7156 存储损坏回退批次 + BILI_PREDECESSOR_DRAIN_GRACE_MS 生命周期账本登记),需确认合并后 lane 修复完整、文档无冲突丢失。
  2. 什么原因导致的: master 在 lane 工作期间前进;[Bug][storage] Takeover spawns before reclaim: old and new sidecars simultaneously hold index.db, causing corruption; em | [Bug][storage] 接管时先 spawn 后回收:新旧侧车同时持有 index.db 引发损坏;空 payload_json 又让历史会话静默变 0 #7156 批次改写了 launcher/storage 路径(与本分支零重叠),仅 3 个 docs/configuration*.md 与本 lane 重叠(新增 env 变量文档行)。
  3. 影响范围与严重程度: 仅 3 个文档文件的合并面;lane 全部 src/tests/website 文件逐字节不变,无 kernel/ 变更、无行为变更。严重程度:无。
  4. 怎么修复的: 自动合并;逐文件核验 3 个文档 old-head→new-head 的 delta 恰为 +2/−0(只增 [Bug][storage] Takeover spawns before reclaim: old and new sidecars simultaneously hold index.db, causing corruption; em | [Bug][storage] 接管时先 spawn 后回收:新旧侧车同时持有 index.db 引发损坏;空 payload_json 又让历史会话静默变 0 #7156 的 BILI_PREDECESSOR_DRAIN_GRACE_MS 两行,零删除),lane 自有内容完整保留。
  5. 是否有回归问题: 无。逐项核查:① 15 个 lane 文件 blob hash 与上一已批准 head 全部一致;② 3 个文档文件零删除、纯增 master 自身 delta;③ isDraftDump 三处调用点 + 定义、DRAFT_ENVELOPE 保留;④ 无 kernel/ 变更;⑤ CI 54 check-runs 全绿(39 success/15 skipped/0 failed/0 pending,一次性 API 核实);⑥ merge-base = master HEAD,behind 消除。
  6. 是否破坏缓存: 不涉及。纯 master 同步,无缓存/重试/增量游标/去重键变更。
  7. 是否改了设计方向: 不涉及。
  8. 是否引入了新的配置: 不涉及(lane 自身无新配置;文档中出现的 BILI_PREDECESSOR_DRAIN_GRACE_MS 是 master [Bug][storage] Takeover spawns before reclaim: old and new sidecars simultaneously hold index.db, causing corruption; em | [Bug][storage] 接管时先 spawn 后回收:新旧侧车同时持有 index.db 引发损坏;空 payload_json 又让历史会话静默变 0 #7156 的 env 变量,非本 PR 引入)。

判定: APPROVE / 可合。 合并权归 human(§7.4 wire/message-shape 变更,agent 不合并)。

Sync the thinking-leak lane with upstream master f7621b1
(45 commits, 46 files: affinity/upstream/web/registry batches).
No lane file overlaps; the merge is conflict-free.

Verified: kernel build, tsc (only the pre-existing cordis env
errors), five gates, config-docs fixed point, and the lane suites
(issue5175 66/0, tag-echo 79/0, issue2190 32/0, issue3905 19/0,
issue2929 1/0, native-compact-terminal 1/0, notice-registry 5/0,
plugin-fork 58/0).
@Louie0806

Louie0806 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Sync with upstream master f7621b130

Merged upstream master f7621b130 into this lane.

  • Delta: 45 commits / 46 files (affinity, upstream egress/throttle/alerts, web diagnostics/changelog, registry price profile, image budgets, plus their tests). None of those files appear in this lane's 18-file diff, so the merge is conflict-free.
  • Merge commit: 3936456b67766705426e571e67b71802dd3f29a2, parents 7c982225d (lane) and f7621b130 (master).

Verification on the merged tree:

  • kernel build: OK

  • npx tsc --noEmit: only the 5 pre-existing @deepseek-ai/cordis errors from tests/dsh-tool-registration-lifetime.test.ts, which also appear on pristine master

  • gates: check-unused-exports, config-surface-guard, lifecycle-ledger-guard, check-test-import-graph, check-architecture-docs all exit 0

  • node tools/gen-config-docs.mjs generate: fixed point (no unstaged doc changes)

  • lane suites: issue5175-drift-name-leak 66/0, tag-echo 79/0, issue2190-degen-close 32/0, issue3905-announcement-tail 19/0, issue2929-codex-fold-double-miss 1/0, native-compact-terminal 1/0, notice-registry 5/0, plugin-fork 58/0

  • CI on 3936456b6: 39 success / 0 failure / 15 skipped (all green)

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b)

Re-reviewed the new head 3936456b6 (master sync onto f7621b130: 45 commits / 46 files — affinity, upstream egress/throttle/alerts, web diagnostics/changelog, registry price profile, image budgets + tests). Verdict: APPROVE / 可合.

What I verified on the new head:

  1. Pure master sync, branch fully current. The merge commit's parents are exactly 7c982225d (the approved lane head) and f7621b130 (master HEAD); merge base is master HEAD itself — no longer behind.
  2. Zero overlap, all 18 lane files byte-identical. The old-head→new-head delta is exactly the 46 master-side files; set-intersection with the lane's 18 files is empty, so every src/, tests/, and docs/website lane file is untouched by the merge — the full behavioral surface is unchanged.
  3. Repair symbols intact (lane files blob-identical to the verified head): isDraftDump at src/degenerate-turn.ts:101, call sites src/plugin.ts:3027 / src/plugin.ts:4810 / src/loop/core.ts:1300; DRAFT_ENVELOPE at src/degenerate-turn.ts:82.
  4. No kernel/ changes in the lane diff.
  5. CI green on the new head: 54 check-runs — 39 success / 15 skipped / 0 failed / 0 pending (one-shot check-runs fetch; the mirror cache was stale at 12-pending, so I confirmed directly).

No new findings; no small fixes needed this round. Merge stays human-only per §7.4 (wire/message-shape change).


结构化八问

  1. 是什么问题: 又一次 master 同步的 re-review——lane 分支合入 master 前进的 45 个提交(f7621b130:affinity、上游 egress/throttle/alerts、web diagnostics/changelog、registry 价格画像、image budgets 及测试),需确认合并后 lane 修复完整。
  2. 什么原因导致的: master 在 lane 工作期间前进;本批 46 个文件与 lane 的 18 个文件零重叠,合并无冲突。
  3. 影响范围与严重程度: 无 lane 文件被触碰,无 kernel/ 变更、无行为变更。严重程度:无。
  4. 怎么修复的: 自动合并;核验 old-head→new-head delta 恰为 46 个 master 侧文件,与 lane 18 文件集合交集为空,即全部 lane 文件逐字节不变。
  5. 是否有回归问题: 无。逐项核查:① 18 个 lane 文件全部与上一已批准 head 逐字节一致(集合交集核验,比逐文件 blob 更强);② 无 kernel/ 变更;③ isDraftDump 三处调用点 + 定义、DRAFT_ENVELOPE 保留;④ CI 54 check-runs 全绿(39 success/15 skipped/0 failed/0 pending,一次性 API 核实);⑤ merge-base = master HEAD,behind 消除。
  6. 是否破坏缓存: 不涉及。纯 master 同步,无缓存/重试/增量游标/去重键变更。
  7. 是否改了设计方向: 不涉及。
  8. 是否引入了新的配置: 不涉及(lane 自身无新配置;master 侧 delta 的配置项属各自 PR 的披露范围,非本 PR 引入)。

判定: APPROVE / 可合。 合并权归 human(§7.4 wire/message-shape 变更,agent 不合并)。

Upstream delta f7621b1..b10c1a0 = 9 commits / 8 files:
URL-mask scheme scans, loopback-host validation for diagnostics,
colliding incident dumps, long-session report argument limit,
plus their tests. None of those files appear in this lane's
18-file diff, so the merge is conflict-free.
@Louie0806

Copy link
Copy Markdown
Contributor Author

Sync with upstream master b10c1a0d4

Merged upstream master b10c1a0d4 into this lane.

  • Delta f7621b130..b10c1a0d4: 9 commits / 8 files — URL-mask scheme clamping, loopback-host validation for diagnostic exemptions, colliding incident dumps, long-session report argument limits, plus their tests.
  • None of those files appear in this lane's 18-file diff, so the merge is conflict-free.
  • Merge commit: 2c91c0272f81be35e171b410b78fad425aa1cdb3, parents 3936456b6 (lane) and b10c1a0d4 (master).

Verification on the merged tree:

  • kernel build: OK
  • npx tsc --noEmit: only the 5 pre-existing @deepseek-ai/cordis errors from tests/dsh-tool-registration-lifetime.test.ts that also appear on pristine master
  • gates: check-unused-exports, config-surface-guard, lifecycle-ledger-guard, check-test-import-graph, check-architecture-docs all exit 0
  • node tools/gen-config-docs.mjs generate: fixed point (no unstaged doc changes)
  • lane suites: issue5175-drift-name-leak 66/0, tag-echo 79/0, issue2190-degen-close 32/0, issue3905-announcement-tail 19/0, issue2929-codex-fold-double-miss 1/0, native-compact-terminal 1/0, notice-registry 5/0, plugin-fork 58/0

CI on 2c91c0272 is green: 39 success / 0 failure / 15 skipped.

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b)

Re-reviewed the new head 2c91c0272 (master sync onto b10c1a0d4: 8 files — error-dump/log-mask/web-report hardening + their test suites). Verdict: APPROVE / 可合.

What I verified on the new head:

  1. Pure master sync, branch fully current. The merge commit's parents are exactly 3936456b6 (the approved lane head) and b10c1a0d4 (master HEAD); merge base is master HEAD itself — no longer behind.
  2. Zero overlap, all 18 lane files byte-identical. The old-head→new-head delta is exactly the 8 master-side files (src/error-dump.ts, src/log-mask.ts, src/web/report.ts + 5 tests/ files); set-intersection with the lane's 18 files is empty, so every lane src/, tests/, and docs/website file is untouched by the merge — the full behavioral surface is unchanged.
  3. Repair symbols intact (lane files blob-identical to the verified head): isDraftDump at src/degenerate-turn.ts:101, call sites src/plugin.ts:3027 / src/plugin.ts:4810 / src/loop/core.ts:1300; DRAFT_ENVELOPE at src/degenerate-turn.ts:82.
  4. No kernel/ changes in the lane diff.
  5. CI green on the new head: 54 check-runs — 39 success / 15 skipped / 0 failed / 0 pending (one-shot check-runs fetch; the mirror cache independently showed 0 pending / 0 failed).

No new findings; no small fixes needed this round. Merge stays human-only per §7.4 (wire/message-shape change).


结构化八问

  1. 是什么问题: 又一次 master 同步的 re-review——lane 分支合入 master 前进的提交(b10c1a0d4:error-dump/log-mask/web-report 加固及其测试,8 个文件),需确认合并后 lane 修复完整。
  2. 什么原因导致的: master 在 lane 工作期间前进;本批 8 个文件与 lane 的 18 个文件零重叠,合并无冲突。
  3. 影响范围与严重程度: 无 lane 文件被触碰,无 kernel/ 变更、无行为变更。严重程度:无。
  4. 怎么修复的: 自动合并;核验 old-head→new-head delta 恰为 8 个 master 侧文件,与 lane 18 文件集合交集为空,即全部 lane 文件逐字节不变。
  5. 是否有回归问题: 无。逐项核查:① 18 个 lane 文件全部与上一已批准 head 逐字节一致(集合交集核验);② 无 kernel/ 变更;③ isDraftDump 三处调用点 + 定义、DRAFT_ENVELOPE 保留;④ CI 54 check-runs 全绿(39 success/15 skipped/0 failed/0 pending,一次性 API 核实 + 镜像缓存双重确认);⑤ merge-base = master HEAD,behind 消除。
  6. 是否破坏缓存: 不涉及。纯 master 同步,无缓存/重试/增量游标/去重键变更。
  7. 是否改了设计方向: 不涉及。
  8. 是否引入了新的配置: 不涉及(lane 自身无新配置;master 侧 delta 的配置项属各自 PR 的披露范围,非本 PR 引入)。

判定: APPROVE / 可合。 合并权归 human(§7.4 wire/message-shape 变更,agent 不合并)。

master e691e6e (PR ranxianglei#7415, 3 commits / 20 files) touches the compress
receipt "fold more" recommendation and the uncovered-note fold silence.
Six of its files overlap this lane (three configuration docs, the
compress seed, website/docs/index.html, website/main.js); all auto-merge
with no hand resolution.

Verified on the merged tree: kernel build ok, tsc only the five
pre-existing @deepseek-ai/cordis farm errors, five gates ok, config docs
idempotent (no diff), lane anchors intact (isDraftDump at
src/plugin.ts:3027, src/plugin.ts:4810, src/loop/core.ts:1300;
endsWithAnnouncement 6 hits; endsWithDraftClose only its definition;
MYSQL_SCHEMA_VERSION 11 at src/storage/mysql.ts:77).

Suites: issue5175 66/0, tag-echo 79/0, issue2190 32/0, issue3905 19/0,
issue7318 6/0, issue2929 1/0, native-compact-terminal 1/0,
notice-registry 5/0, plugin-fork 58/0, issue5403 1/0, issue4666 2/0,
issue4739 4/0, issue4788 4/0.
@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b)

Re-reviewed the new head 02e9b6af6 (master sync onto e691e6e3c: the #7415 batch — compress.postCompressTail made opt-in/default-off, latched uncovered-note fold stays silent; 20 files). Verdict: APPROVE / 可合.

What I verified on the new head:

  1. Pure master sync, branch fully current. The merge commit's parents are exactly 2c91c0272 (the approved lane head) and e691e6e3c (master HEAD); merge base is master HEAD itself — no longer behind.
  2. 12 of 18 lane files byte-identical to the approved head (all src/ + tests/ — the full behavioral surface is untouched).
  3. The 6 generated artifacts (three docs/configuration.*.md + website/config-reference/compress.yaml, website/docs/index.html, website/main.js) each took exactly master's own delta — line-level comparison of old-head→new-head vs old-master→new-master added/removed lines is identical: only the compress.postComPressTail row (env-var index + detail + website seed), zero removals, lane content fully preserved.
  4. Repair symbols intact (src files blob-identical to the verified head): isDraftDump at src/degenerate-turn.ts:101, call sites src/plugin.ts:3027 / src/plugin.ts:4810 / src/loop/core.ts:1300; DRAFT_ENVELOPE at src/degenerate-turn.ts:82.
  5. No kernel/ changes in the lane diff.
  6. CI green on the new head: 54 check-runs — 39 success / 15 skipped / 0 failed / 0 pending (one-shot check-runs fetch; the mirror cache was stale at 12-pending, so I confirmed directly).

No new findings; no small fixes needed this round. Merge stays human-only per §7.4 (wire/message-shape change).


结构化八问

  1. 是什么问题: 又一次 master 同步的 re-review——lane 分支合入 master 前进的 [PR] fix: Disable the "Continue Compressing" recommendation in the compression receipt by default (compress.postComPressTail) | fix: 压缩回执的"继续压缩"推荐默认关闭(compress.postComPressTail),开启后未覆盖提示每轮最多一次 #7415 批次(e691e6e3c:compress 回执的「fold more」推荐改为 opt-in、默认关;已 latch 的 uncovered-note fold 保持静默,20 个文件),需确认合并后 lane 修复完整、文档无冲突丢失。
  2. 什么原因导致的: master 在 lane 工作期间前进;[PR] fix: Disable the "Continue Compressing" recommendation in the compression receipt by default (compress.postComPressTail) | fix: 压缩回执的"继续压缩"推荐默认关闭(compress.postComPressTail),开启后未覆盖提示每轮最多一次 #7415 批次只触碰压缩回执文案与配置文档生成物,与 lane 仅 6 个生成文档重叠(自动合并)。
  3. 影响范围与严重程度: 仅 6 个生成文档的合并面;lane 全部 src/tests 文件逐字节不变,无 kernel/ 变更、无 lane 行为变更。严重程度:无。
  4. 怎么修复的: 自动合并;逐文件核验 6 个生成文件 old-head→new-head 的增删行集合与 master 自身 delta 完全一致(只增 compress.postComPressTail 行,零删除),lane 自有内容完整保留。
  5. 是否有回归问题: 无。逐项核查:① 12 个 src/tests lane 文件与上一已批准 head 逐字节一致;② 6 个生成文档零删除、纯增 master 自身 delta;③ isDraftDump 三处调用点 + 定义、DRAFT_ENVELOPE 保留;④ 无 kernel/ 变更;⑤ CI 54 check-runs 全绿(39 success/15 skipped/0 failed/0 pending,一次性 API 核实);⑥ merge-base = master HEAD,behind 消除。
  6. 是否破坏缓存: 不涉及。纯 master 同步,无缓存/重试/增量游标/去重键变更。
  7. 是否改了设计方向: 不涉及。
  8. 是否引入了新的配置: 不涉及(lane 自身无新配置;文档中出现的 compress.postComPressTail 是 master [PR] fix: Disable the "Continue Compressing" recommendation in the compression receipt by default (compress.postComPressTail) | fix: 压缩回执的"继续压缩"推荐默认关闭(compress.postComPressTail),开启后未覆盖提示每轮最多一次 #7415 的配置项,非本 PR 引入)。

判定: APPROVE / 可合。 合并权归 human(§7.4 wire/message-shape 变更,agent 不合并)。

@Louie0806

Copy link
Copy Markdown
Contributor Author

Synced master e691e6e3c (PR #7415: compress receipt "fold more" recommendation now opt-in, uncovered-note fold stays silent) into this branch.

Merge: 02e9b6af6; 20 files staged, no hand resolution.
Overlap: 6 of the 20 files (three configuration docs, the compress seed, website/docs/index.html, website/main.js) — all auto-merged.
Verified on merged tree: kernel build ok; tsc --noEmit only the five pre-existing @deepseek-ai/cordis farm errors; five gates rc=0; config docs idempotent (no diff); lane anchors intact (isDraftDump at src/plugin.ts:3027, src/plugin.ts:4810, src/loop/core.ts:1300; endsWithAnnouncement 6 hits; endsWithDraftClose only its definition; MYSQL_SCHEMA_VERSION = 11 at src/storage/mysql.ts:77).
Suites: issue5175 66/0, tag-echo 79/0, issue2190 32/0, issue3905 19/0, issue7318 6/0, issue2929 1/0, native-compact-terminal 1/0, notice-registry 5/0, plugin-fork 58/0, issue5403 1/0, issue4666 2/0, issue4739 4/0, issue4788 4/0.
CI: 39 success / 0 failure / 15 skipped.

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b)

Your sync report for 02e9b6af6 matches my independent re-review, which is posted above: APPROVE / 可合. Same picture from my side — 12/18 lane files byte-identical to the prior approved head, the 6 generated artifacts took exactly master's #7415 delta (line-level compare, zero removals), repair anchors intact, no kernel/ changes, CI 39 success / 15 skipped / 0 failed. Nothing further needed from the lane; awaiting human merge.

Brings in PR ranxianglei#7415's follow-up batch: a kernel compress receipt that no
longer double-claims a batch seam, third-party scan hardening, and the
per-turn pf window ledger full-path coverage.

Overlap with this branch is limited to the three generated configuration
docs, which auto-merged.
@Louie0806

Copy link
Copy Markdown
Contributor Author

Synced master ba2e81982 (PR #7415 follow-up: no double-claimed batch seam in the compress receipt, third-party scan hardening, per-turn pf window ledger full-path coverage) into this branch.

Merge: cf5c918ca; 13 files staged, no hand resolution.
Overlap: only the three generated configuration docs, auto-merged.
Verified on the merged tree: kernel build ok; tsc --noEmit reports only the five pre-existing farm errors from the missing @deepseek-ai/cordis test dependency (same five on pristine master); five gates rc=0; config docs idempotent (no diff).
Lane anchors intact: isDraftDump(proseAcc) at src/plugin.ts:3027 and src/plugin.ts:4810, isDraftDump(assistantText) at src/loop/core.ts:1300; endsWithAnnouncement 6 hits; endsWithDraftClose 1 hit (its definition only); MYSQL_SCHEMA_VERSION = 11 at src/storage/mysql.ts:77.
Suites: issue5175 66/0, tag-echo 79/0, issue3905 19/0, issue2190 32/0, native-compact-terminal 1/0; upstream's new suites also green: issue7318 6/0, issue7346 2/0, issue7346-fullpath 1/0, issue1206 52/0.
CI: 39 success / 0 failure / 15 skipped.

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b)

Re-reviewed the new head cf5c918ca (master sync onto ba2e81982: the #7428 batch — pf-window-ledger batch-seam double-claim fix, dsh-mneme added to known third-party conflicts, + their tests; 13 files). Verdict: APPROVE / 可合.

What I verified on the new head:

  1. Pure master sync, branch fully current. The merge commit's parents are exactly 02e9b6af6 (the approved lane head) and ba2e81982 (master HEAD); merge base is master HEAD itself — no longer behind.
  2. 15 of 18 lane files byte-identical to the approved head (all src/, tests/, and website files — the full behavioral surface is untouched).
  3. The three docs/configuration.*.md files each took exactly master's own delta — line-level comparison of old-head→new-head vs old-master→new-master added/removed lines is identical: only the reworded BILI_CONFLICT_SCAN row (known-conflicts list gains dsh-mneme declared purpose=compaction is refused with no fallback for plugin background sessions that hold no fold blocks (dsh-mneme dream fails 100% since 0.1.216) #7379), zero removals of lane content.
  4. Repair symbols intact (src files blob-identical to the verified head): isDraftDump at src/degenerate-turn.ts:101, call sites src/plugin.ts:3027 / src/plugin.ts:4810 / src/loop/core.ts:1300; DRAFT_ENVELOPE at src/degenerate-turn.ts:82.
  5. No kernel/ changes in the lane diff (the kernel files in master's delta are master-side, already in master).
  6. CI green on the new head: 54 check-runs — 39 success / 15 skipped / 0 failed / 0 pending (one-shot check-runs fetch; the mirror cache independently confirmed 0 pending / 0 failed).

No new findings; no small fixes needed this round. Merge stays human-only per §7.4 (wire/message-shape change).


结构化八问

  1. 是什么问题: 又一次 master 同步的 re-review——lane 分支合入 master 前进的 [PR] fix: two adjacent ranges in one compress batch both claimed the shared seam tool pair — first-come-first-served #7428 批次(ba2e81982:pf-window-ledger 批次接缝 double-claim 修复、第三方扫描已知冲突加入 dsh-mneme、及其测试,13 个文件),需确认合并后 lane 修复完整、文档无冲突丢失。
  2. 什么原因导致的: master 在 lane 工作期间前进;[PR] fix: two adjacent ranges in one compress batch both claimed the shared seam tool pair — first-come-first-served #7428 批次触碰 pf 水位账本与第三方扫描(与 lane 零代码重叠),仅 3 个 docs/configuration*.md 与本 lane 重叠(自动合并)。
  3. 影响范围与严重程度: 仅 3 个文档文件的合并面;lane 全部 src/tests/website 文件逐字节不变,无 kernel/ 变更、无 lane 行为变更。严重程度:无。
  4. 怎么修复的: 自动合并;逐文件核验 3 个文档 old-head→new-head 的增删行集合与 master 自身 delta 完全一致(仅 BILI_CONFLICT_SCAN 行改写,零删除),lane 自有内容完整保留。
  5. 是否有回归问题: 无。逐项核查:① 15 个 lane 文件与上一已批准 head 逐字节一致;② 3 个文档文件零删除、纯增 master 自身 delta;③ isDraftDump 三处调用点 + 定义、DRAFT_ENVELOPE 保留;④ 无 kernel/ 变更;⑤ CI 54 check-runs 全绿(39 success/15 skipped/0 failed/0 pending,一次性 API 核实 + 镜像缓存双重确认);⑥ merge-base = master HEAD,behind 消除。
  6. 是否破坏缓存: 不涉及。纯 master 同步,无缓存/重试/增量游标/去重键变更。
  7. 是否改了设计方向: 不涉及。
  8. 是否引入了新的配置: 不涉及(lane 自身无新配置;文档中 BILI_CONFLICT_SCAN 的改写是 master [PR] fix: two adjacent ranges in one compress batch both claimed the shared seam tool pair — first-come-first-served #7428 的内容,非本 PR 引入)。

判定: APPROVE / 可合。 合并权归 human(§7.4 wire/message-shape 变更,agent 不合并)。

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

Re-verification of head cf5c918ca — APPROVE / 可合

查重: 非新立项——本 PR 已于 10-30 triage(floor 22);平台把同一份同步报告(floor 601)重派了一次(floor 602 已审过该 head),我按独立性要求重新独立核了一遍,不沿用前轮结论。

Independently verified on this machine (git-level, fresh fetch):

  1. Pure master sync, branch fully current. cf5c918ca parents are exactly 02e9b6af6 (the approved lane head) and ba2e81982 (master HEAD); merge-base is master HEAD itself.
  2. Merge delta == master's own delta. 02e9b6af6→cf5c918ca is stat-identical to e691e6e3c→ba2e81982: 13 files, 699+/13−. The merge brought in exactly the [PR] fix: two adjacent ranges in one compress batch both claimed the shared seam tool pair — first-come-first-served #7428 batch (pf-window-ledger batch-seam double-claim fix, dsh-mneme in the known-conflict scan, their tests) and nothing else.
  3. All 15 non-doc lane files byte-identical between the two lane heads (per-file git diff --quiet) — the full behavioral surface (all src/ + tests/ + website) is untouched.
  4. The 3 docs/configuration.*.md files each took exactly master's own delta (added/removed line sets identical between master's diff and the merge's diff): only the BILI_CONFLICT_SCAN row reword (known-conflicts list gains dsh-mneme declared purpose=compaction is refused with no fallback for plugin background sessions that hold no fold blocks (dsh-mneme dream fails 100% since 0.1.216) #7379) plus the matching third-party-scan sentence; zero removals of lane content.
  5. Lane anchors intact on the new head: isDraftDump def src/degenerate-turn.ts:101, call sites src/plugin.ts:3027 / src/plugin.ts:4810 / src/loop/core.ts:1300; DRAFT_ENVELOPE src/degenerate-turn.ts:82; endsWithAnnouncement 6 hits (1+2+3 across degenerate-turn/core/plugin); endsWithDraftClose 1 hit (definition only, src/degenerate-turn.ts:84); MYSQL_SCHEMA_VERSION = 11 at src/storage/mysql.ts:77.
  6. No kernel/ files in the lane's net diff vs master — the 18-file lane surface is unchanged from the approved head.
  7. CI green on cf5c918ca99 (mirror cache, fetched 05:06:52Z): 0 failed / 0 pending; every test shard + both static-gates success. Sync report's full-matrix count: 39 success / 15 skipped / 0 failed.

标签: bug / scope/wiring / p2(内核结构泄漏到可见输出的缺陷,接线层修复,低频但生产已观测——triage 时已打,本轮纯同步复核未改动)


结构化八问

  1. 是什么问题: 又一次 master 同步的 re-review——lane 分支合入 master 前进的 [PR] fix: two adjacent ranges in one compress batch both claimed the shared seam tool pair — first-come-first-served #7428 批次(pf 水位账本批次接缝 double-claim 修复、第三方扫描已知冲突加入 dsh-mneme declared purpose=compaction is refused with no fallback for plugin background sessions that hold no fold blocks (dsh-mneme dream fails 100% since 0.1.216) #7379、及其测试,13 个文件),需确认合并后 lane 修复完整、文档无内容丢失。
  2. 什么原因导致的: master 在 lane 工作期间前进;[PR] fix: two adjacent ranges in one compress batch both claimed the shared seam tool pair — first-come-first-served #7428 批次只触碰 pf 水位账本与第三方扫描,与 lane 零代码重叠,仅 3 个 docs/configuration*.md 生成文档与本 lane 重叠(自动合并)。
  3. 影响范围与严重程度: 仅 3 个文档文件的合并面;lane 全部 15 个 src/tests/website 文件与上一已批准 head 逐字节一致,无 kernel/ 变更、无 lane 行为变更。严重程度:无。
  4. 怎么修复的: 自动合并;本轮独立核验——merge delta 与 master 自身 delta 逐文件 stat 一致,3 个文档的增删行集合与 master delta 逐行相同(仅 BILI_CONFLICT_SCAN 行改写,零删除),15 个 lane 文件逐文件字节一致,锚点符号逐一在位。
  5. 是否有回归问题: 无。逐项核查:① 15 个 lane 文件与已批准 head 逐字节一致;② 3 个文档零删除、纯 master 自身 delta;③ lane 锚点(isDraftDump 定义+三调用点、DRAFT_ENVELOPE、endsWithAnnouncement ×6、endsWithDraftClose 仅定义、MYSQL_SCHEMA_VERSION=11)全部在位;④ lane 侧无 kernel/ 变更;⑤ CI 0 failed / 0 pending(镜像缓存 sha cf5c918ca99),全矩阵 39 success / 15 skipped;⑥ merge-base = master HEAD,behind 消除。
  6. 是否破坏缓存: 不涉及。纯 master 同步,无缓存/重试/增量游标/去重键变更(pf 水位账本变更是 master 侧 [PR] fix: two adjacent ranges in one compress batch both claimed the shared seam tool pair — first-come-first-served #7428 的内容,已在 master,非本 PR 引入)。
  7. 是否改了设计方向: 不涉及。
  8. 是否引入了新的配置: 不涉及(lane 自身无新配置;文档中 BILI_CONFLICT_SCAN 的 dsh-mneme 改写是 master [PR] fix: two adjacent ranges in one compress batch both claimed the shared seam tool pair — first-come-first-served #7428/[PR] fix: flag dsh-mneme as a known third-party compression conflict in the dsh scan (#7379) #7430 的内容,非本 PR 引入)。

判定: APPROVE / 可合。 合并权归 human(§7.4 wire/message-shape 变更,agent 不合并)。

Brings the ranxianglei#7367 pf-tail-ids cap / pf-seq decoupling, the ranxianglei#7156 pure-sqlite
refusal + storage backup/repair tools, ranxianglei#7426 ingest-cap default-off and the
ranxianglei#7432 OpenAI reasoning alias. Three configuration docs overlapped; all
auto-merged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants