You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug][dsh] a later patch row silently re-arms native compaction: compaction-basic.auto:false is dropped by whole-config replacement, with no boot check #7113
Activity
ranxianglei commentedon Nov 18, 2026
[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)
查重:不重复(已有在途 PR)
本 issue 已有在途 PR:#7116
fix(dsh): alarm when the host-plane compaction-basic override is gone (#7113),由 @resec 提交,分支2026-11-18_dsh-auto-false-boot-check(head9d75e7cb)。审核结论
方向正确,修法合理,测试双向覆盖。 具体:
dsh-compaction-gate.ts)在apply()时通过ctx.inject(["loader"], …)拿到宿主 loader,扫描合成后的 entry 树(hostPlaneRowsMissingAutoFalse),找出compaction-basic行 enabled 但auto !== false的情况。loader 是 optional 依赖(inject回调内取,不硬依赖),不恢复 [dsh] Disabling the plugin permanently bricks dsh session creation - the bundle patch inject gate has no fallback (0.1.199 / dsh 0.2.1-rc.2) #3662 的 pend 失败模式。logHostEvent("warn", "bili-compaction-gate", …)打一条持久化日志,点名违规行 + 修法("Restateauto: falsein the LAST patch row")。warn-only,不自愈——与 issue 约束一致(不新增配置键、不与 patch 整体替换语义冲突)。tests/issue7113-auto-false-boot-check.test.ts,8 个 case):auto: false在位 → 不报;disabled: true(web profile 正常态)→ 不报;无 loader → 静默;无行 → 静默。auto缺失(patch 整体替换丢掉)→ 报;config 被完全替换 → 报;auto: true→ 报。inject依赖["loader"]、service 仍正常发布。static-gates× 2、mysql-contract、lifecycle-ledger-guard、kernel-guard、architecture-docs、config-surface-guard);test lanes 仍在跑(11 pending)。状态
PR 可合并性取决于 test lanes 结果。当前
mergeable_state: behind(分支落后 master),合并前需 rebase。结论:PR #7116 方向正确、实现完整、测试双向覆盖,等 CI 全绿 + rebase 后可合并。