Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) 审核结论先行:方向正确、修到根因、测试有牙,可合入;但按 §7.4 不能自动合并——需 owner 人工批准(理由见第 5/7 问与末尾)。无阻塞项,仅两处非阻塞小提醒。 查重:不重复。 同作者相邻的 #6147(把 Gemini 工具响应里的图计入预算/摘要,方向是"多算进去")与 #6109(downscale 缓存键带上声明的 mime)机制不同、且都不碰 结构化八问1. 是什么问题 2. 什么原因导致的 3. 影响范围与严重程度 4. 怎么修复的 5. 是否有回归问题
6. 是否破坏缓存 7. 是否改了设计方向 8. 是否引入了新的配置 为什么不能自动合并(§7.4)diff 干净、单模块、纯 fix、带回归测试、引用
非阻塞小提醒(可不改)
判定LGTM,可合入;需 owner 人工批准(不可自动合并)。 修法打到根因、范围收敛、测试有牙、无重复无竞争、无意外回归;唯一要 owner 点头的是"去掉 image/png 兜底 + 非图/未知内容改为保留"这一产品取舍。CI 绿后即可合。 |
|
Landed via batch PR #6439 (merged) — closing as superseded. |
(ai: vllm-qwen/qwen3.8-27b) Confirmed, and verified live before acknowledging:
So the fix is fully landed via #6439 and closing #6184 as superseded loses nothing. My earlier "not auto-mergeable / needs owner approval" note is now moot — your merge of #6439 is that approval. No further action from me. |
Fixes #6176
Problem
The Google collector treats every inlineData part as an image. Gemini also carries audio, video and documents in that field, so a byte or image-count limit can replace those parts with an image-omitted note. Undeclared media is likewise assumed to be PNG without evidence.
Changes
Collect Google inlineData only when its declared MIME type is image/*. Preserve non-image and unknown media in both byte and count shedding; image archiving and protected-tail behavior continue as before.
Google's Part/Blob schema documents these non-image media types: https://ai.google.dev/api/generate-content#Blob
Validation
e3220adc0f5412af83163666ca70a6afa05e3247(package version0.1.213). The intervening [PR] thirdparty-scan: flag dsh-live-compact as a known conflict (#5984) #6166 changes only third-party plugin detection, its tests, announcements and configuration docs; none of this patch's source or test files changed. The complete patch is byte-identical to the locally validated patch on33104b1f9545caeb0344193009917ceef9969682and applies cleanly.33104b1f9545caeb0344193009917ceef9969682: 8 new regression cases still fail before the production fix.33104b1f9545caeb0344193009917ceef9969682(5f3c2d54180ecacc9a5f664a970e236caa0d25d5): 30/30 focused tests passed, with no failures, skips or cancellations.npm run buildpassed on the temporary integration treee186774d3428c85e2a4974c6e609b2a7381d6153containing the seven independently submitted fixes on33104b1f9545caeb0344193009917ceef9969682. The repository compiler options and include set are unchanged.git diff --checkpassed. Local runtime: Node.js 24.22.1 on Linux. Full cross-platform remote CI remains pending.This change filters the wire collector and is independent of the image encode-cache MIME key in #6109. No configuration or kernel changes.