Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) Duplicate screening: not a duplicate. Searched open AND closed issues/PRs for this mechanism ("archived prefix exhausts the downscale worklist"): #6177 → this PR (#6185) is the only thread touching it. The sibling image-shedding PRs from the same author are distinct symptoms with distinct mechanisms and non-overlapping hunks — #6184 (google-lane non-image inline media must not be archived; touches only Labels: applied Review status (in progress):
CI: static gates all green; 9 cross-platform |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Review verdict: APPROVE — correct root-cause fix, fully verified locally, auto-merge eligible (§7.4: all 8 conditions met). The merge itself stays human-only. What was verifiedRoot cause (confirmed in code, not taken on faith). Rung B computed its 64-image worklist before Rung A archived old images ( Fix. Selection moved after archiving, filtered to live occurrences ( Local runs at PR head
Code quality (external-strict bar): naming, dead code, comment accuracy, magic numbers, style consistency, dependencies — all pass. The test asserts the exact archive count (64), a real width shrink via Jimp round-trip (width < 1024), and input-array non-mutation. No refactor needed. Duplicate screening: not a duplicate — #6177→#6185 is the only thread on this mechanism (open+closed searched). Sibling PRs #6184/#6187 are different symptoms/mechanisms with non-overlapping hunks. Labels: bug/p1/scope/wiring applied, judged from this PR's own diff (hard availability failure under the stated trigger conditions). Live state check (verified minutes ago, not from memory)
In progress now: rebasing the PR branch onto current master 结构化八问
判定:可合并(auto-merge eligible;合并动作按规由人执行)。 |
fe435e9 to
7f27769
Compare
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Rebase done — PR head is now Verified on the rebased head, locally:
One environment note for transparency: the first post-rebase test run failed 7/7 with GitHub is recomputing mergeability after the head update (transiently showing |
|
Landed via batch PR #6439 (merged) — closing as superseded. |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Confirmed live: the fix landed on master via the batch — commit My review verdict (APPROVE) applies to exactly this content: the batch preserved the same single commit I rebased and verified — 65/65 targeted egress-shed suites, independently reproduced negative control, typecheck and full build clean on the rebased head. One transparency note: my session was force-restarted (~23:51) while waiting on the fresh CI test shards on |
Fixes #6177
Problem
Rung B chooses its 64-image worklist before Rung A archives old images. With 64 archived images at the front, every selected entry is already detached, so the downscale pass does no work even when a protected recent image alone exceeds the byte budget. The proxy then sends an oversized request although resizing that image would make it fit.
Changes
Select the bounded downscale worklist from the remaining live images after archiving. Keep the 64-image decode/re-encode cap, dimension ladder and protected-tail policy.
Validation
e3220adc0f5412af83163666ca70a6afa05e3247(package version0.1.213). The intervening [PR] thirdparty-scan: flag dsh-live-compact as a known conflict (#5984) #6166 changes only third-party plugin detection, its tests, announcements and configuration docs; none of this patch's source or test files changed. The complete patch is byte-identical to the locally validated patch on33104b1f9545caeb0344193009917ceef9969682and applies cleanly.33104b1f9545caeb0344193009917ceef9969682: 1 new regression case still fails before the production fix.33104b1f9545caeb0344193009917ceef9969682(b6c2d9de830918c30013bd84d58c871833a585e8): 4/4 focused tests passed, with no failures, skips or cancellations.npm run buildpassed on the temporary integration treee186774d3428c85e2a4974c6e609b2a7381d6153containing the seven independently submitted fixes on33104b1f9545caeb0344193009917ceef9969682. The repository compiler options and include set are unchanged.git diff --checkpassed. Local runtime: Node.js 24.22.1 on Linux. Full cross-platform remote CI remains pending.#5754 fixed Rung A’s archive traversal past the old cap. This addresses the independent selection of Rung B’s surviving-image worklist. No configuration or kernel changes.