Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复。 Searched open+closed issues/PRs for the error-body-swallow mechanism — the only items are #6133 (source issue) and this PR #6134. The prior retry work you cite (#190/#1351/#1454/#1693/#5947) are different failure domains (pre-response transport deaths / the original retry policy), not this post-header body-read path, so they're related infrastructure, not duplicates of this fix. Review — PR #6134 (external contributor)What I verified (evidence, not "should work"):
① Direction (original issue #6133): Correct root cause, correctly layered. The defect is that a body-read failure after headers arrive is disguised as a complete transient HTTP error, so 503 gets replayed and the transport cause is lost. Your fix removes the producer (the blanket catch) rather than masking the symptom downstream. Notably the function's own doc comment ( ② Regression review — pre-existing behaviors I checked, with verdicts:
③ Code review: Minimal and correct. ④ Test validity: Real assertions with teeth (identity check ⑤/⑤b Diff cleanliness & code-quality hard bar: 2 files, +88/−2, single commit, every line on-topic; no unrelated churn, no whitespace noise, no lock/generated changes. Passes the external-submission strict bar. Intended behavior change (must flag — Deliverables #4):
结构化八问
判定: 可合。 修法正确、测试有牙、diff 干净、方向对路。唯一动作项:PR 落后当前 master ~52 个提交(但 master 未触碰 src/fetch-util.ts,GitHub 已标 mergeable,无冲突)——合并前 routine rebase 到 master 即可。按规则我不执行合并,请 owner 自行合并: #6134 |
(ai: vllm-qwen/qwen3.8-27b) Status update — my full structured review is already up in this thread (verdict unchanged); this is a live CI re-check that found the picture moved since my first pass. CI (verified live against PR head Net: the code-review verdict stands — 可合 (see the review above) — but this head currently has no clean full-suite pass: the ubuntu test matrix never completed. Two prerequisites before merge:
If you want the mid-flight cancellation itself root-caused (manual cancel vs runner issue), that's CI-infra territory — a line in the CI coordination thread #4599 beats chasing it inside this PR. I did not chase it here; it does not affect the code-review verdict. Per repo rules I don't merge — owner merges when ready: #6134 |
255ab4e to
70f175b
Compare
|
Rebased the unchanged two-file fix onto current Validation on the rebased tree: all 14 tests in |
(ai: vllm-qwen/qwen3.8-27b) Verified your rebase live — thanks. Current state: Rebase (checked locally against git): head is now Fresh CI (run 42960469014, read live): fully terminal and green — 18 success / 12 skipped / 0 failed / 0 cancelled / 0 pending. All 11 test-matrix shards actually ran and passed (ubuntu 22×1–3, ubuntu 24×1–3, windows 22×1–5); static-gates (both OS), mysql-contract, docs-coverage, gate, test-import-graph, unused-exports all green. The 12 skips are the default-gated zero-token e2e lanes + On your Windows-24 full-matrix note: understood — that lane (and Verdict: unchanged — 可合. Both prerequisites from my last note are now satisfied (clean rebase onto current master + fresh CI green). Ready for owner merge whenever. Per repo rules I don't merge — owner merges when ready: #6134 结构化八问(本轮增量,代码级答案与上轮一致)
合并前置项现状: ① rebase → ✅ 已干净落在当前 master;② 新鲜 CI → ✅ 标准套件全绿。仅剩 owner 合并(可选:触发 |
|
Landed via batch PR #6439 (merged) — closing as superseded. |
Problem
fetchWithRetry replaces every HTTP error-body read failure with "upstream error". For HTTP 503, body timeouts and client cancellation become retryable HTTP verdicts, replaying requests and hiding the transport cause.
Changes
Read the complete error body before HTTP retry classification. Propagate failed reads unchanged and clear the request watchdog in finally. Complete transient error responses retain bounded retries.
Validation
Checked prior retry work #190/#1351/#1454/#1693/#5947 and Afloat16 history. This concerns errors after response headers arrive.
Base: e1e33a9.
Closes #6133