Repository navigation
Conversation
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Independent review — I re-ran the verification myself rather than re-reading the issue's conclusions. What I verified
Behavior changes (disclosed, old → new)
Non-blocking follow-up found in review §7.4 gate check: all 8 conditions hold — single module, regression test reproduces the bug (13 fails on master), green on the rebased head, no config/persistence/wire/kernel change, pure Remaining gate the author lists: the four real-model e2e phases have not run (configured upstream on port 8199 unreachable). Per the PR body this is a before-merge gate; the full-suite verdict is the remote CI, which is green. 8问(结构化结论)
Verdict: mergeable. All §7.4 auto-merge conditions hold; CI green on the pushed head; the only remaining gate is the real-model 4-phase e2e the author could not run (upstream unreachable) — run it (or accept the CI verdict + the new real-HTTP integration test) before merge. The |
Fixes #7200.
Problem
Compression replay requests read every rejected response with
response.text()before deciding whether to retry. A real HTTP fixture retains all 8 MiB in eitherUpstreamHttpError.bodyor the retry callback. A continuously extended error response can also postpone the decision indefinitely because incoming chunks rearm the idle watchdog.Changes
Read at most 1 MiB of response-body bytes into the replay diagnostic. Once overflow is confirmed, cancel the unread tail without awaiting cancellation, and prefix the diagnostic with an explicit truncation marker. Streaming UTF-8 decoding preserves split characters; a code point intentionally cut at the byte boundary is left out rather than replaced.
Complete error bodies at or below the limit keep their existing decoding. Read failures and aborts retain their original errors, and the existing
finallystill clears the watchdog. Success streams, the main passthrough transport, attempt limits/backoff, and Retry-After handling are unchanged.This intentionally stops inspecting prose retry markers beyond the byte budget. A marked prefix is not presented as a complete JSON envelope. The limit concerns retained source bytes, not a claim about transport chunk size or total process memory. No config, kernel, or persistence change.
Validation
acp_statusloop receives a 503 body exceeding the cap with no EOF. The original waits until the test's external abort; the fix cancels that body, retries, and returns the supplier's final answer. Both attempts carry the identical executed tool receipt.npm run typecheck,npm run build, import-graph check, and whitespace check pass on current mastera446a3c1.The Codex preflight finds the CLI and built artifact, but the configured real-model upstream on port 8199 is unreachable. The required four real-model phases have not run; this remains a before-merge gate. Full regression is the remote CI verdict on the pushed head.
Duplicate check
All 270 fork heads and 279 upstream file-history commits were checked. The earlier error-identity changes in #6134/#6159 and declaration-parser bound in #3610 do not cap this read. The body cleanup in #7171 belongs to
makeContinuationRefetch, which discards a response entirely; this change bounds diagnostic consumption in a different replay path.