Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) Duplicate screening: not a duplicate. Related open thread is #6127 / PR #6128 ("preserve runaway guard frame boundaries across chunks") — same subsystem ( Review in progress: verifying the reported RangeError reproduces on unchanged master source, running the targeted runaway-guard suites, then a structured review follows in this thread. |
Reviewer alignment for PR ranxianglei#6131 (fixes ranxianglei#6130): test-only, no behavior change. The four original cases passed under every leaf permutation, so the one named "preserves text order" pinned no ordering; renamed it to what it actually asserts (mixed array/object visitation plus cross-leaf run continuity) and added one positive and one negative wire-order case (separated vs contiguous 150-runs against the 200 default threshold). Both new cases fail against a forward-push (reversed-order) variant of the walker and pass on this implementation.
(ai: vllm-qwen/qwen3.8-27b) Review complete — recommendation: mergeable. (The merge itself stays human.) Duplicate screening was done in my first comment here: not a duplicate; #6127/PR #6128 is the same subsystem but a different failure domain (chunk framing vs traversal depth). Verification evidenceRepro confirmed on unchanged master: the three new deep-nesting cases fail with Fix equivalence: the new iterative walker is an exact preorder DFS — children are pushed in reverse and popped LIFO, so visit order is identical to the old recursion; exclusion semantics are preserved (the old sticky Local evidence on the rebased head (current master + this PR, clean rebase): typecheck clean, production build OK including dist import/external checks, 45/45 targeted tests green (runaway-deep-json ×6, issue3260-text-run-guard + runaway-guard ×39). CI: cached check runs for the previous head showed no failures (the test matrix jobs were skipped under fork gating); the new head gets fresh runs — the full-suite verdict stays with CI. Reviewer alignment commit pushed: 5aa1d6bOne finding I fixed directly rather than leaving as a note: test 4's name ("preserves text order") overclaimed. Leaf feed order IS observable through the run tracker (the max-run statistic changes when the feed sequence is reversed), yet all four original cases pass under every leaf permutation — that test pinned nothing about order. Since Regression audit (existing behaviors carried by the touched paths)
Notes
结构化八问
合并判定:建议可合——复现已验证、修法语义等价、回归审计干净、测试经对齐提交(5aa1d6bdf6)增强后本地定向 45/45 全绿;等新 head 的 CI 结果后由人工合并。 |
(ai: vllm-qwen/qwen3.8-27b) Status note: the full structured review for this PR was already posted (verified live on the upstream PR #6131 thread, 2026-11-10 23:22 UTC) — if it does not render below, that is a mirror-sync lag, not missing work. Compact outcome:
|
|
Landed via batch PR #6439 (merged) — closing as superseded. |
Reviewer alignment for PR ranxianglei#6131 (fixes ranxianglei#6130): test-only, no behavior change. The four original cases passed under every leaf permutation, so the one named "preserves text order" pinned no ordering; renamed it to what it actually asserts (mixed array/object visitation plus cross-leaf run continuity) and added one positive and one negative wire-order case (separated vs contiguous 150-runs against the 200 default threshold). Both new cases fail against a forward-push (reversed-order) variant of the walker and pass on this implementation. (cherry picked from commit 5aa1d6b)
(ai: vllm-qwen/qwen3.8-27b) Acknowledged — supersede verified live, nothing outstanding on my side.
Final state: fix + order-pinning tests live on master via #6439; this PR superseded; thread ready for you to close. |
(ai: vllm-qwen/qwen3.8-27b) Re-trigger received — re-verified live, state unchanged, no action taken.
Nothing outstanding — this thread needs no further work from me. |
Problem
The runaway observer recursively visits parsed provider JSON, including excluded branches. Valid deep nesting can overflow the call stack and fail an otherwise normal response stream.
Changes
Use an explicit depth-first stack. Push children in reverse order to preserve text ordering and skip excluded branches before visiting children. Deep model text still participates in detection; excluded tool payloads remain byte-exact passthrough.
Validation
Checked runaway-guard history and previous Afloat16 PRs. This fixes parsed-event traversal independently of framing and prior media traversal work.
Base: e1e33a9.
Closes #6130