Repository navigation
Conversation
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Review started on PR #6128 (mirror #6131). Duplicate screening: not a duplicate. Searched open+closed issues and PRs for runaway-guard framing topics. Prior text-run work #3289 (lane introduction, #3260) and Google tool-argument exclusions #3357/#3362/#3358 are all closed and cover different mechanisms (lane creation / argument exclusion) — this PR's frame-boundary defects (stale SSE separator cursor, NDJSON tail loss + mode forgetting) are distinct, as the author states. One sibling in flight: PR #6131 ("avoid recursive runaway guard traversal", issue #6130) touches the same file but a different function ( Labels: bug, scope/wiring, p2 (kept existing pr) — defect in the proxy-side upstream-stream wiring (not compression kernel logic); severity p2 because a missed trip wastes tokens/latency until manual cutoff but the session stays usable (no data loss, no cache/storage growth). Verification so far (targeted local runs): the 3 claimed regression cases genuinely fail on unchanged upstream e1e33a9 (batched SSE LF, batched SSE CRLF, split NDJSON event) and all 7 new tests pass on the PR head; CI shows 0 failures with 3 windows shards still running. Full review verdict follows after I finish checking one test-coverage gap I found in the new NDJSON gate. |
The existing split-SSE case passes on unpatched source too (its large
frame carries no trip-worthy run), so the /^[{\[]/ gate added alongside
the frame-boundary fix had no regression coverage. This frame is a single
>=64KB SSE event whose pretty-printed payload spans many data: lines and
ends in a 200-codepoint run: without the gate the NDJSON fallback engages
on the first chunk and drops every unparseable line, missing the trip.
Reviewer addition for ranxianglei#6128.
Review follow-up for the frame-boundary fix (issue ranxianglei#6127): - Tolerate leading blank lines/whitespace before the first NDJSON line (gate /^[{\[]/ -> /^\s*[{\[]/): an NDJSON stream opening with a stray blank line would otherwise never engage the fallback and lose text-run detection for the whole stream. SSE field lines never open with whitespace, so oversized split SSE events stay protected by the gate. - Document the non-obvious framing invariants at their sites: the cursor re-anchor after each consumed frame, sticky NDJSON mode, retained partial tail, and why the JSON-token gate exists. Adds a regression test: leading-blank-line NDJSON trips once its repeated delta completes across chunks (fails on the pre-change gate).
|
Landed via batch PR #6439 (merged) — closing as superseded. |
The existing split-SSE case passes on unpatched source too (its large
frame carries no trip-worthy run), so the /^[{\[]/ gate added alongside
the frame-boundary fix had no regression coverage. This frame is a single
>=64KB SSE event whose pretty-printed payload spans many data: lines and
ends in a 200-codepoint run: without the gate the NDJSON fallback engages
on the first chunk and drops every unparseable line, missing the trip.
Reviewer addition for ranxianglei#6128.
(cherry picked from commit b8e6d9d)
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Confirmed, verified live:
Nothing outstanding on this thread — the fix is on master, CI-verified by the batch merge. Closing is yours to execute per the note above. 结构化八问(评审结论归档)
收工判定:修复已经由批量 PR #6439 合入 master,本线程无遗留事项,可关。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Re-triggered after the infra retry — verified live, nothing changed since my last reply: PR #6128 is closed unmerged (superseded), batch PR #6439 remains merged on master (2026-11-12T14:01:25Z) carrying the fix plus the review-time gate test, and no new comments have landed. No work pending on this thread; the mirror row stays open for your close per your "closing as superseded" note. |
Problem
The text-run runaway guard misses repeated output when the transport batches several SSE frames into one chunk: its separator regex retains an offset into the old buffer after slicing. The NDJSON fallback also loses an incomplete final line and stops parsing subsequent small chunks.
Changes
Reset the SSE separator cursor after each consumed frame. Retain incomplete NDJSON events and the selected framing mode. Require a JSON opening token before selecting NDJSON so a large split SSE event retains SSE framing. Normal forwarded stream bytes are unchanged.
Validation
Checked prior text-run work #3289 and Google tool-argument exclusions #3357/#3362/#3375, plus previous Afloat16 contributions; these framing defects are separate.
Base: e1e33a9.
Closes #6127