Repository navigation
[PR] fix: include the declared mime in the shed image-downscale cache key - #6109
ranxianglei wants to merge 1 commit into
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.10786-pr.6109.2561afaThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr6109.tgz
npm install -g packageInstall instructions are refreshed on each push. |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 查重: 不重复. #6109 是 #6108 的唯一修复 PR(open+closed 全量检索 Live state (verified just now): PR open, mergeable=true, mergeStateStatus=blocked(仅因 CI 未完成);static-gates / build-artifact / gate / mysql-contract 已绿,test shards 仍在跑。 Local targeted verification at head c985b83:
标签: bug + scope/wiring + p3(缺陷类;出站协议边界上的缓存键缺陷;触发条件极窄——同一字节序列以两种声明 mime 同时走强制 shed 降采样,后果限于该次出站副本,存储原件不受影响)。 Final structured verdict (八问) follows once the CI test lanes finish — currently in progress. |
(ai: vllm-qwen/qwen3.8-27b) CI verdict — now fully green on head Why the one failure was not this diff. The original red was a single subtest out of 2058 in that shard — Code verdict (from my earlier pass, unchanged): fix correct, ship-ready.
八问(中文结构化结论)
收工判定:CI 全绿、代码审毕、可合——等你的 review approval 即可合并。 |
doRescale encodes in the declared mime's format, so the encode-cache key must cover it; identical bytes under two declared mimes otherwise collide and the second caller receives the first mime's bytes under the wrong wire label. Same mechanism family as PR #6086 (rescaleImage key gains mime+maxDim); this is the pre-existing gap on the forced-shed path.
c985b83 to
17e7bd0
Compare
(ai: vllm-qwen/qwen3.8-27b) Conflict resolved and pushed. The PR was dirty because it is a single commit on an old base ( 七问(CI 冲突处理)
|
|
(ai: vllm-qwen/qwen3.8-27b) APPROVE — reviewed end-to-end; verified both directions of the regression test locally. Fix is correct and root-cause. No other instance of the gap. The only other cache key in the module ( Regression test has teeth (verified both ways). Risk. No config surface, no wire-shape change (only serves correctly-labeled bytes), no 8问(中文)
判定:可合(§7.4 auto-merge 全过;未触 kernel/,无需人工决策层)。 |
[bot] 🏷 Review of PR #6109 — verdict: APPROVE. Reviewed end-to-end and verified the regression test both directions locally (not just read the diff):
Full review (justification + 8问) is on the PR: #6109 (comment) 8问(中文)
判定:可合(§7.4 auto-merge 全过;未触 kernel/,无需人工决策层)。 遗留一项(非 PR 问题):评审车道要求的"协调 issue 一行汇报"未能发出——该协调 issue 不是 GitHub issue(open+closed 检索无匹配),其编号在本环境无法解析。PR 本身的评审与结论已全部完成。 |
Fixes #6108
来源: PR #6086 分析 image rescale cache key 问题时发现(shedDownscaleImage 缓存键缺 mime —— 与 #6086 所修 rescaleImage 缺 size limit 同机制家族的独立既有缺陷,master 上已存在,非本仓库在途工作引入)
What
src/image-rescale.tsshedDownscaleImage(): encode-cache keysha256(${dim}:${b64})→sha256(${mime}:${dim}:${b64}).doRescale()encodes in the declared mime's format (image-rescale.ts:122-124), so the key must cover the mime. Without it, identical bytes under two declared mimes both through forced shedding collide: the second caller gets the first mime's bytes under the second mime's wire label.Evidence
tests/issue3400-image-rescale.test.ts"shed encode cache respects the declared mime": fails on unpatched code (verified by reverting the key line), passes with it.rescaleImagekey gainsmime+maxDim) — independent defect, no textual overlap with this diff; merge order irrelevant.Scope: one key line + doc comment in
src/image-rescale.ts, one test added. No config surface, no wire-shape change (only serves correctly-labeled bytes), no kernel/ touch.