Repository navigation
Conversation
|
The failed CI job is test (windows-latest, 22, 2). Its two failures are the existing The same two abort cases passed locally on this PR head Could a maintainer rerun this failed Windows job? No abort behavior or timeout threshold has been changed in this PR. |
(ai: vllm-qwen/qwen3.8-27b) Investigated before acting — this is a known flaky cell, not a regression from the PR. Reran the failed job; it's green now. What failed — only
Both are the client-abort → upstream-teardown cells. In the same run the sibling cells were green ( Not a regression from this PR. The diff touches only Known flake. The test header (lines 31–64) documents this exact signature as a repeat Windows flake — Action + result. Reran the failed job(s) of run 43728334421 ( 结构化八问
判定:非本 PR 回归,系已知 Windows flake,已重跑并转绿,可正常走合并流程。 |
|
Thanks for investigating and rerunning the Windows Node 22 job; the current head is green now. The merge panel still waits for three Required checks:
The plan job selected Could you apply the existing |
[ework] CI fix verified green ✓ |
|
Thanks for confirming the Windows Node 22 rerun. I checked the merge panel again after your update: it still shows 13 skipped, 3 expected, 37 successful checks on The remaining step is to create those missing check results, using the workflow's existing FULL matrix. Could you apply |
🔶 需要决策 Background (one line): the PR's code is reviewed and ready, but the merge panel is blocked by a pre-existing branch-protection mismatch — not a defect in this PR. What I verified (live, mirror check cache): the core-matrix run on The decision needed: master's required-status-check list is stale — it references windows/Node-24 shard 1/2/3 from the pre-#4351 3-shard era, while the current FULL matrix emits windows/Node-24 shards 1–5. This blocks 5 open PRs (#6848 plus #6843, #6845, #6853, #6854 — the four you confirmed are missing the same contexts), not just this one. Two ways out:
My recommendation: Option B is the correct root fix — the required-check list is stale infrastructure, and per-PR Default if no decision: the PR stays blocked on the three "expected" checks; nothing merges. I have not applied the label: per my operating rules I don't mutate the source PR's labels (that's a maintainer/owner action), and the branch-protection list is owner/admin territory. I also won't touch the 4 related PRs — they're separate threads outside this task's scope; Option B fixes them all at once. 代码评审(结构化八问)
质量:外部提交,按 ⑤b 从严过了一遍——命名达意、无死代码、无重复(还顺带消掉了重复的淘汰逻辑)、错误处理完整(陈旧完成/超大结果/负结果各有分支)、无魔法值、注释讲为什么、无新依赖、测试有真断言(字节数、读取次数、字节级重编码、并发/竞态)而非恒真。代码质量达标,无需对齐重构。 判定:代码正确、测试扎实、质量达标,可合;唯一阻塞是上面那条既有的分支保护 required-check 失配(非本 PR 缺陷),需 owner 在 A/B 中拍板。64 MiB 默认值属产品决策,按 §7.4 走人工合并。 |
Closing status (full review + decision request are in the comment above):
|
Match the issue3400 suite's BILI_CONFIG_FILE isolation so the admission/eviction tests run on the default (enabled) rescale posture regardless of any host config file.
Problem
Fixes #6846.
The process-wide image encode cache retains completed base64 output behind a 512-entry cap. Large image encodes can consume hundreds of MiB long before reaching that count, even after the originating request/session stops using them.
Changes
The resize engine, dimensions, quality, MIME keys, original-image storage, and annotations are unchanged. Evicted images can require another deterministic encode. This is a bound on retained cache payloads, not on codec working memory or total process RSS.
Reproduction and measured result
Tested from master 2e3cfc9 (0.1.215), the parent of this commit. Head: c39ace7.
The included benchmark runs twenty distinct 2400×1600 PNG images through the real rescale pass at the default 1600-pixel longest edge. It warms the codec first, then runs three garbage collections with event-loop turns before each memory snapshot. The fixture uses deterministic high-entropy pixels; it does not represent the size of every screenshot.
Reproduce with:
These are local measurements. CI uses deterministic cache-admission assertions, without timing/RSS thresholds or large image allocations.
Validation
53 focused tests passed, run with the repository preload, tsx, and test-concurrency=1:
The new tests cover shared byte eviction across normal and forced encodes, oversized-result admission, byte-identical re-encoding, concurrent requests, completion after cache reset, pending entries under byte pressure, negative-result count limits, and restoring the default test budget. The original controls include real image codecs and HTTP paths, original-image recovery exemptions, and WS oversize/1009 retries.
On unchanged master, the original large-payload regression fails; its in-flight-sharing control passes. The small-fixture regressions also fail for byte eviction and oversized retention while their three initial controls pass.
Also passed:
The live Codex four-phase E2E has not been run: the built distribution and Codex CLI are present, but E2E_CHECK=1 reports the configured http://127.0.0.1:8199/v1/models upstream unreachable. The real-codec and HTTP/WS tests listed above are hermetic.
Related changes checked: #6086 (resize-policy cache key) and open #6109 (shed MIME key) address different behavior.