Repository navigation
[PR] fix(proxy): honor equivalent IPv6 bypass addresses - #6708
Conversation
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Post-merge review — this PR was merged to master at 12:50Z (via batch6-wave6, merge commit Duplicate screening: no duplicate. Independent all-state search for NO_PROXY/IPv6 and Live state verified:
Independent verification (re-ran locally, did not take the PR's word for it):
Code review:
Behavior change (disclosed): NO_PROXY / Windows ProxyOverride entries written in an equivalent-but-non-canonical IPv6 spelling (expanded groups, leading zeros, alternate zero-compression, IPv4-embedded notation) now match — previously only the exact canonical spelling matched. Old → new, the intended fix; no other behavior change. 标签: bug + scope/wiring + p3(缺陷,出网代理边界,边缘场景可绕行) 结构化八问
判定: 审核通过,合入合理(已合入 master),无需后续动作。 |
Closes #6707.
Problem
matchesNoProxy()compares a URL-normalized IPv6 hostname against the original bypass token. Equivalent spellings therefore disagree:http://[::1]does not matchNO_PROXY=0:0:0:0:0:0:0:1, and::ffff:127.0.0.1does not match the URL-normalized::ffff:7f00:1. In auto proxy mode this sends a deliberately excluded upstream through the environment proxy. Exact IPv6 entries in Windows ProxyOverride have the same mismatch.Change
Canonicalize valid IPv6 literal tokens with the same URL parser used for the target, after the existing port check. This covers expanded groups, leading zeros, alternative zero-compression positions and IPv4-embedded notation. The IPv6 addressing specification, section 2.2 defines these equivalent representations.
Only IPv6 literal comparison changes. Existing DNS suffixes, IPv4 matching, wildcard modes, explicit proxy precedence and malformed-token fallback are covered by controls. IPv4 addresses are not equated with IPv4-mapped IPv6 addresses. No setting, dependency or protocol shape is added; the shared proxy resolver applies in both plugin and proxy modes.
Verification
9495c764d36909eec263f404d4802d68b608f23f. The ten new tests produce 8 failures and 2 passing controls on the unchanged source.startServer(): the baseline sends CONNECT and returns 502. With this fix the same HTTP request reaches the IPv6 upstream directly, returns 200 with the expected JSON, preserves its request body and sends no CONNECT.git diff --checkpassed. Hosted cross-platform CI remains the full-suite verdict.History check
Checked the complete cached Afloat16 PR file/patch index and all-state searches for NO_PROXY/IPv6 and
matchesNoProxy. Read the relevant actual patches: #73 introduced the existing literal-string comparison; #2505 and #6211 change Windows wildcard handling; #6092 changes socket host/CONNECT authority spelling. #6577, #6583 and #6595 modify connection lifecycle, TLS trust or buffered tunnel data. None canonicalizes bypass address tokens.