Repository navigation
[PR] fix(release): direct-path release notes have always been the placeholder "- initial release" — the newly created tag sha | fix(release): direct-path 发布说明一直是占位符 "- initial release"——新打的 tag 遮蔽了 git describe - #5378
Conversation
…tial release'
The Create-GitHub-Release step runs AFTER Create-tag, which tags v$VER
locally in the same checkout. Bare 'git describe --tags --abbrev=0' then
returns that brand-new local tag, LAST == v$VER -> else-branch -> the
placeholder body. Every direct-path release was destined for '- initial
release'; release-bugfix.yml (merge-gated path) already carries the guard
("`git describe --match 'v*' --exclude "v$VER*" ...`") — restore the
same line here.
Proof (v0.1.210, first-ever direct-path publish on 2026-11-01):
release body shipped as '- initial release' (17 bytes) vs v0.1.209's
proper 20KB changelog; notes since v0.1.209 were back-filled manually.
ranxianglei
left a comment
There was a problem hiding this comment.
评审结论:可合并(小改动直接修类,按常设规则评审直发)。
- 逐字对齐核对:改后行与
.github/workflows/release-bugfix.ymlL306(带注释 "nearest ancestor tag other than the one we just made")完全一致——不是仿写,是把丢失的守卫抄回来。✅ - 爆炸半径:
--match 'v*'只收窄到版本 tag、--exclude "v$VER*"只排除刚打的那个;其他任何分支形态下 describe 行为不变。notes 生成格式/prerelease/API POST 零 diff。✅ - 回归验证:对当前历史实测——修复逻辑在 v0.1.210 场景下会取 LAST=v0.1.209、生成我手工补上的那份 34 条 changelog(与已补上线的 body 同源)。✅
- 已知但未动的差异(不在本 PR 范围,记录在案):manual 路径用
$LAST..HEAD~1而 bugfix 路径用$LAST..HEAD(manual 想跳过 bump commit,merge-gated 路径的 HEAD 本来就不是 bump)——各自语境下都自洽,不要"顺手统一",统一会各打掉一个真实条目。 - 建议:合入即可,无依赖、无需等待 CI 之外的任何条件(workflow 文件,CI 的 workflow-syntax check 过就行)。
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.7597-pr.5378.460a530This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5378.tgz
npm install -g packageInstall instructions are refreshed on each push. |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 查重: 不重复。 对应 PR 为 #5378(分支 标签: 正在独立核验:拉分支对 diff、核对 release-bugfix.yml 参照段、查 CI 状态,结论按八问体例随后补上。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) PR #5378 独立审核结论(未照抄 issue 分析,以下全部重新核验过)。 结构化八问
证据链(独立产出)
判定代码层面可合。按 §7.4,release workflow 属 load-bearing infra,必须人合——建议待 test 分片转绿后由你合并(或鉴于纯 YAML 单行改动直接拍板);若分片后续变红,按 CI 协调政策去 #4599 对状态。 |
ranxianglei
left a comment
There was a problem hiding this comment.
(ai: vllm-qwen/qwen3.8-27b)
Verdict: APPROVE — posted as a comment because GitHub blocks self-approval of the author's own PR; please approve + merge yourself if you concur.
APPROVE — independently verified end-to-end; the one-line fix is correct and complete.
Verification (independent of the issue-side analysis)
- Bug mechanism reproduced. In
release-manual.ymlthe direct path (steps.push.outputs.direct == 'true') runs "Create tag" (L501) — localgit tag v$VERon HEAD — BEFORE "Create GitHub Release" (L513). With the old baregit describe --tags --abbrev=0, describe always returns the just-made tag sitting on HEAD →LAST == v$VER→ else branch →- initial release. Every direct-path release was therefore guaranteed the placeholder. Reproduced in a scratch repo simulating the exact sequence (prev tag → content commits → bump commit → local tag on HEAD): old variant →LAST=v0.1.210→ placeholder branch. - Fix verified. New variant (
--match 'v*' --exclude "v$VER*") returns the previous tag (v0.1.209) in the same repro; the notes range$LAST..HEAD~1lists exactly the content commits — HEAD is the bump commit on both direct variants (fresh-bump commits it at L201; pending-bump publishes master whose tip IS the merged bump commit), soHEAD~1excludes it correctly. - Byte-identical to the reference: L519 now matches
release-bugfix.yml:308exactly. (bugfix uses$LAST..HEADvs manual's$LAST..HEAD~1— pre-existing intentional difference from per-lane HEAD semantics, untouched by this PR.) - Edge cases: first release (no prior
v*tag) → describe fails →LAST=""→ placeholder branch still reachable and correct;kernel-v*tags can never be picked as LAST thanks to--match 'v*'; a re-run with the tag already existing upstream is also handled by--exclude. - Regression sweep: all four
git describeinstances in the repo checked — manual:330 and manual:396 anchor atHEAD~1(and/or run in lanes where the new tag does not exist); bugfix:308 already correct. No other vulnerable instance; nothing consumes the placeholder string. YAML parses clean. - Hygiene: base == current master tip (fresh); diff = 1 file / +1 -1, single purpose; no
kernel/touched, no kernel-change declaration required; CI at head53e1508: all guard/gate lanes green, TS/e2e test lanes skipped by path filter (workflow-only change) — 0 failed, 0 pending.
Behavior change (disclosed)
Direct-path GitHub Release body: always - initial release → real changelog (## Changes since v<prev> + commit subjects). Placeholder branch now reachable only for a genuine first release. Tag creation, npm publish, prerelease flag and API POST shape all untouched.
Per §7.4 the release workflows are load-bearing infra — merge stays owner-only. Code-wise clean to merge.
(ai: vllm-qwen/qwen3.8-27b) 专职审核完成:判定 APPROVE,已发到 GitHub PR #5378 的 review 区(以 COMMENT 形式——GitHub 禁止作者自批自己的 PR,approve + merge 留给你;按 §7.4 release workflow 本来就人合)。全部独立重核过:scratch 仓复现 bug 机制(旧裸 describe → LAST=v0.1.210 → 占位符分支)、验证修复(→ v0.1.209,notes 范围正确排除 bump commit)、修复行与 release-bugfix.yml:308 逐字节一致、全仓无其他可被遮蔽的 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.1056-master.d640d0d # this exact build
npm install -g billion-context@master # always the newest merged build
|
…-gate, ranxianglei#5616 dsh remote compression bypass, ranxianglei#5378 release-notes fix
现象
2026-11-01 的 v0.1.210 是第一次走 release-manual.yml 直发路径(pending-bump 逃逸,#5375)的发布:tag ✅、npm ✅、GitHub Release 页面 ✅,但页面正文只有一行
- initial release——上一版 v0.1.209 是完整 20KB changelog。用户打开发布页以为"没了"。当晚已手工把正确 notes 补上(gh release edit,release id 430062453,补丁后 26KB 正常 notes)。根因
release-manual.yml 直发路径步骤顺序:
Create tag(先本地打v$VER再推)→Publish→Create GitHub Release。后者里:此时 HEAD 上的新本地 tag 就是
v$VER,describe必然返回它 →LAST == "v$VER"→ else 分支写占位符。只要走直发路径,笔记就一定是占位符。历史上没暴露是因为分支保护把 bot 直推挡掉,所有发布都走 fallback PR / merge-gated 路径——那条(release-bugfix.yml)同一段代码本来就带着正确写法(注释 "nearest ancestor tag other than the one we just made"):manual 路径移植时丢了
--exclude。修复
一行,与 release-bugfix.yml 逐字对齐。其余逻辑(notes 格式、prerelease、API POST)零改动,YAML 解析验证过。
影响面
仅直发路径的 GitHub Release 正文(npm/tag 不受影响)。修好后每个直发版本 notes 恢复真实 changelog。
证据