Repository navigation
[PR] ci(test): Minor CI/test signal fixes, Part 2 — dispatch guard blind-spot coverage + golden snapshot encapsulation + base | ci(test): CI/test 信号小修合集第二辑 —— dispatch 守卫补盲 + 黄金快照封闭化 + 基线注释更正 - #5859
Merged
Conversation
Contributor
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.8539-pr.5859.60ca878This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5859.tgz
npm install -g packageInstall instructions are refreshed on each push. |
ranxianglei
pushed a commit
that referenced
this pull request
Nov 7, 2026
The workflow_dispatch rewrite dropped the closing double-quote on the kernel-change error line, so the generated step script died with 'unexpected EOF while looking for matching quote' before any guard logic ran (kernel-guard exit 2 on PR #5859's own run). One-character fix; all 27 run blocks re-validated with bash -n.
ranxianglei
force-pushed
the
2026-11-07_ci-test-signal-batch
branch
2 times, most recently
from
November 7, 2026 08:45
8613e45 to
b5b3d36
Compare
ranxianglei
force-pushed
the
2026-11-07_ci-test-signal-batch
branch
from
November 7, 2026 08:54
b5b3d36 to
d9459f1
Compare
Owner
Author
🔶 需要决策 (ai: vllm-qwen/qwen3.8-27b) 七问
选项(F3 语义裁决;F1/F2 黄金重生成与此选择独立)
本车道到此停手不再触碰该 PR;#4599 哨兵持有 ci-fixes 收敛。修复落地后重跑自愈。 |
added 2 commits
November 7, 2026 18:58
…ted-state shape #5860 added compress.requireUsageSampleForPressure; the resolved Config snapshot persisted in session.metadata["effectiveConfig"] (src/session.ts cloneSafe) grew by exactly that field, so the metadata section digest drifts deterministically on every lane (F1 of the #5860 born-red wave, signatures pinned in #4599). Regenerated all four snapshots at 5af5f9f with scripts/update-storage-render-goldens.ts; state/blockContents/stats sections unchanged, no behavior change - snapshot realignment only. Verified green under the CI preload env (BILI_MESSAGE_TIMESTAMMS=0 via tests/preload-test-env.mjs).
…ract kernel.json buildKernelGolden() serializes behavior.defaultConfig100k = defaultConfig(100_000); #5860's additive NudgeConfig field broke the canonicalized snapshot (F2 of the #5860 born-red wave). Regenerated with scripts/update-wire-contract-goldens.ts: diff is the single additive field requireUsageSampleForPressure: true in the nudge section - the ledger grows, nothing shrinks (Kernel Boundary rule 4).
This was referenced Nov 7, 2026
Merged
…-baseline (#4011 review) The header claimed the production default was still "shadow" (the interim #2815-era value). Since #3818 the default is "full", which made the comment mislead test authors about what the legacy baseline actually overrides. Add the lesson from PR #4011: suites whose assertions depend on a specific storage mode must pin BILI_STORAGE_UNIFIED themselves, because this baseline overrides the production default in CI. Picked up from PR #4374 for the CI/test-signal small-fixes batch.
…st files (#5402) The storage-render goldens are byte-stable snapshots of the outbound body. They were rendered with the #4313 display gate OFF, which is what tests/preload-test-env.mjs pins and what CI's preload chain provides — but a bare `node --import tsx --test tests/golden-storage-render.test.ts` has no preload, so BILI_MESSAGE_TIMESTAMPS sits at its production default (ON) and every digest drifts. Measured with #5579's regenerated goldens in place (so the byte drift from #5556 is out of the picture and only the gate is variable): bare : 1 pass / 4 fail bare + BILI_MESSAGE_TIMESTAMPS=0 : 5 pass / 0 fail CI preload chain : 5 pass / 0 fail Pin the gate inside each suite so the goldens are hermetic in both run modes, matching the regen script's Parity #3 and the CI preload chain. Scope note: this branch carries only the two test-file self-pins. The byte regeneration is #5579 (Closes #5578), and the regen-script Parity #3 block already landed on master in 6d6e29e — both were dropped here so the PR is a single focused invariant. Land #5579 first: without the regenerated bytes the goldens are still stale and every test shard stays red in either run mode. Co-authored-by: Louie0806 <Louie0806@users.noreply.github.com> Picked up from PR #5434 for the CI/test-signal small-fixes batch.
…ge gap) Picked up from PR #4428 for the CI/test-signal small-fixes batch. Resolved against current master (post-#5801/#4828): guards keep their new timeout-minutes; kernel-guard keeps the #4828 lockfile-exemption and now also skips only the PR-body declaration check on owner-fired workflow_dispatch.
…ernel-guard Rule-1 (#4428 piece) Follow-up to this branch's #4428 consolidation; caught by the kernel-guard job itself on the first CI run ('unexpected EOF while looking for matching quote'): - the ::error:: echo lost its closing double quote during the three-way resolution — pure syntax error, fixed by restoring it; - the dispatch exemption referenced ${GITHUB_EVENT_NAME}, an env var GitHub Actions does NOT define (only the github.event_name expression context). On every event it expanded empty, silently re-arming the body check for workflow_dispatch — defeating the exemption #4428 exists for. Inject EVENT_NAME via the step env (same idiom as PR_BODY) and compare that. Verified: yaml parse OK; bash -n clean on the full run script; all three Rule-1 branches simulated (dispatch+no-body passes exempt / PR without marker fails / PR with 'kernel-change:' passes).
ranxianglei
force-pushed
the
2026-11-07_ci-test-signal-batch
branch
from
November 7, 2026 14:22
454c438 to
4a2b490
Compare
added 2 commits
November 7, 2026 23:01
…0.0.185, #5867 ruling) supersedes sentinel golden realigns
Owner
Author
[bot] (ai: vllm-qwen/qwen3.8-27b) PR #5859 的 6 个红测试分片已修复并全绿。七问:
结论:PR #5859 当前全部检查绿,可等待人工合并。 |
Contributor
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.1095-master.848f59b # this exact build
npm install -g billion-context@master # always the newest merged build
|
This was referenced Nov 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这一辑收什么
CI/test 信号小修三件 —— 都是“让 CI 的红绿更可信、少假红少漂移”的方向,全部已评审通过(✅可合),合并到一次送人审:
fix(test): pin BILI_MESSAGE_TIMESTAMPS in the storage goldens…ci: run boundary guards on workflow_dispatch tooif:),发版分支漏了一道人类闸门之外的机器校验。补齐后守卫同时覆盖 dispatch,且只对 owner 手动触发的 dispatch 豁免 PR-body 声明检查(dispatch 没有 PR body,人工闸门已在带外发生)docs(tests): correct stale storage-default comment…冲突处理(一处,意图并集)
#4428 与当前 master 在 ci.yml 冲突:master 其后给各守卫加了
timeout-minutes: 20,并把 kernel-guard 的 Rule 1 演进成豁免 lockfile 抖动(#4828)。按双方意图合并:保留 timeout、保留 lockfile 豁免,dispatch 时只跳过 PR-body 声明检查、版本纪律规则照跑。YAML 解析校验通过。本地预检(master 295ba58)
npm ci/npm run build/tsc --noEmit✅tests/golden-storage-render.test.ts + tests/storage-engine-proofs.test.ts:未打 [PR] fix(test): pin BILI_MESSAGE_TIMESTAMPS in the storage goldens' own test files (#5402) #5434 补丁 9 过 8 挂 → 打上 17/17(即 storage-render golden suite is not hermetic: locally regenerated digests cannot be reproduced on CI runners #5402 修复的直接证据)tests/test-suite-lock.test.ts + tests/preload-sandbox-dirs.test.ts(preload 基线消费方):33/33 ✅明确不带进来的(附理由)
贡献者身份说明
#5434 来自外部贡献者 @Louie0806,以 cherry-pick 方式保留其原始作者信息(name/email)并附 Co-authored-by;其余两件均为仓库自有分支拾取。
Closes #5402
CI 修正补记(第二轮,2026-11-07 下午)
test 矩阵四线全红不是本辑代码问题,是上游漂移:master 在本分支 base(295ba58)之后合入 #5860(幻影压力守卫,kernel 0.0.184,新增
requireUsageSampleForPressure)+ #5842/#5862,改变了黄金快照会话的持久化形状。CI 跑 merge-ref(HEAD×最新 master)→ 旧快照过期。本机同环境 A/B 实证(各树独立 node_modules + 重建 kernel dist):base 树全绿;master df0a402 精确复现这 4 个失败、digest 与 CI 报错逐字节一致;wire 正文(turns sha)零变化,只有 stateDigest/metadata 段动。已按仓库规矩用自带脚本重生成并提交(b5b3d36,提交正文含完整证据链),本地 17/17 + 31/31 绿。注意:master 自身此刻也埋着同一颗雷(其定时 CI 最后一次运行早于 #5860)——已拆成独立的单提交 PR #5868(Closes #5867)送审,本辑不再携带该快照提交,保持一范围一 PR。