Skip to content

[PR] ci: converge master-CI fixes (register issue4982 spawning suite in LIVE_FILES) - #5017

Merged
ranxianglei merged 3 commits into
masterfrom
ci-fixes
Oct 28, 2026
Merged

ranxianglei merged 3 commits into
masterfrom
ci-fixes

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Sentinel convergence lane (#4599, owner strategy 2026-10-25). ci-fixes = master b08fbf361 + one fix:

Fleet branches merge origin/ci-fixes to inherit. Replaces the closed vehicle #4814; persists across incidents.

@ranxianglei ranxianglei changed the title ci: converge master-CI fixes (register issue4982 spawning suite in LIVE_FILES) [PR] ci: converge master-CI fixes (register issue4982 spawning suite in LIVE_FILES) Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: ci-fixes (02ef0d1)

Latest build — install this exact version

npm install -g billion-context@0.0.6602-pr.5017.8cd5810

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Recent builds (commit → version)

commit version build
02ef0d1 billion-context@0.0.6602-pr.5017.8cd5810 build

Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr5017.tgz
npm install -g package

Install instructions are refreshed on each push.

Two latent defects in tests/issue4982-draining-twin-ladder.test.ts shipped
with PR #5016, both on paths that only run once the fix under test works:

1. Self-contradictory assertion: the demotion warn added by the fix names
   "twin-collision" in its own text (src/server.ts), while test B asserts
   doesNotMatch(/twin-collision/) over the whole log — impossible to satisfy,
   so test B fails deterministically on every CI run. Pin the verdict by its
   unique log marker (shared by the early #4341 and late paths) instead of
   the substring; test A's parallel assertion gets the same marker.

2. Teardown deadlock: silentTcpListener accepted probe connections and held
   them; a socket with no data listener stays paused, so peer EOF is never
   delivered once the probing child dies, leaving CLOSE-WAIT sockets that pin
   squatter.close() forever (verified via ss during the hang) and the test
   ends by node:test cancellation. Drain each connection (sock.resume()) and
   destroy it on EOF.

Test-only change; no production behavior touched.
…e failure reports instead of hanging (#5017)

Follow-up on 499f69e (keeps its assertion markers and squatter listener):
- e2e A/B cleanup moves into finally — with cleanup after the assertions, an
  assertion failure leaked the P1/P2 children + squatter server and hung the
  whole runner instead of reporting the failure reason.
- waitForStatus fetch gets AbortSignal.timeout(2_000) — undici's default
  ~300s headers timeout would otherwise defeat the declared poll deadlines.

Verified both directions locally (Node v25.9.0): green path 6/6 in ~21s with
clean exit; a forced assertion failure now fails fast (~10s) with the real
AssertionError and leaves no sandbox/child behind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant