Repository navigation
[PR] ci: converge master-CI fixes (register issue4982 spawning suite in LIVE_FILES) - #5017
Merged
Merged
Conversation
…te in LIVE_FILES (#4982)
Contributor
📦 Built Package ArtifactBranch: Latest build — install this exact versionThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
Install instructions are refreshed on each push. |
Two latent defects in tests/issue4982-draining-twin-ladder.test.ts shipped with PR #5016, both on paths that only run once the fix under test works: 1. Self-contradictory assertion: the demotion warn added by the fix names "twin-collision" in its own text (src/server.ts), while test B asserts doesNotMatch(/twin-collision/) over the whole log — impossible to satisfy, so test B fails deterministically on every CI run. Pin the verdict by its unique log marker (shared by the early #4341 and late paths) instead of the substring; test A's parallel assertion gets the same marker. 2. Teardown deadlock: silentTcpListener accepted probe connections and held them; a socket with no data listener stays paused, so peer EOF is never delivered once the probing child dies, leaving CLOSE-WAIT sockets that pin squatter.close() forever (verified via ss during the hang) and the test ends by node:test cancellation. Drain each connection (sock.resume()) and destroy it on EOF. Test-only change; no production behavior touched.
…e failure reports instead of hanging (#5017) Follow-up on 499f69e (keeps its assertion markers and squatter listener): - e2e A/B cleanup moves into finally — with cleanup after the assertions, an assertion failure leaked the P1/P2 children + squatter server and hung the whole runner instead of reporting the failure reason. - waitForStatus fetch gets AbortSignal.timeout(2_000) — undici's default ~300s headers timeout would otherwise defeat the declared poll deadlines. Verified both directions locally (Node v25.9.0): green path 6/6 in ~21s with clean exit; a forced assertion failure now fails fast (~10s) with the real AssertionError and leaves no sandbox/child behind.
This was referenced Oct 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentinel convergence lane (#4599, owner strategy 2026-10-25). ci-fixes = master
b08fbf361+ one fix:fix(ci): register issue4982 draining-twin-ladder process-spawning suite in LIVE_FILES (#4982)(02ef0d170) — [PR] fix: draining proxy no longer claims its freed port — same-lane newcomer ladders instead of dying twin-collision (#4982) #5016 added tests/issue4982-draining-twin-ladder.test.ts without registering it in scripts/live-files.mjs, so the SPAWN_RE tripwire in scripts/run-ci-tests.mjs exited 1 before any test ran on all 11 shards (master red at b08fbf3, run 40621087792). Concurrency review per the tripwire note: all real binds use freePort()/listen(0); child health follows the port each child registers (ladder-tolerant); BASE=18861 is in-memory-only — entry is tripwire-purpose like the [Bug] Windows: Proxy falsely detects parent-gone and self-terminates on every forwarded request (same live PID triggered | [Bug] Windows:代理每转发一次请求就误判 parent-gone 自杀(同一存活 PID 在 2.5h 内触发 12 次) #3890/dsh lane: BUSY-drop → EADDRINUSE detour → adopt-twin race is silently lost ~half the time, and a one-shot bootstrap failure then becomes permanent #4811 entries.Fleet branches merge origin/ci-fixes to inherit. Replaces the closed vehicle #4814; persists across incidents.