Repository navigation
[PR] fix: clear stale membership and reject null billing prices - #5042
Conversation
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 查重:不重复 —— #5042 本身就是 #5040(无 ID 请求沿用旧 membership 判定)与 #5041(billing.prices null 抛异常)的修复 PR,两 issue 均为此 PR 而开,无并行重复工作。 进度汇报:会话曾因一次网络 git fetch 挂起被重启。已确认 PR head |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 查重:不重复(重申首条)—— #5042 就是 #5040 + #5041 的修复 PR,两 issue 专为本 PR 而开,无并行重复工作。 审核独立性:以下结论是我独立读 diff(base 结构化八问1. 是什么问题 —— 一个 PR 两个独立 commit:
2. 什么原因导致的
3. 影响范围与严重程度
4. 怎么修复的(机制层)
5. 是否有回归问题(逐路径清点既有行为)
6. 是否破坏缓存 7. 是否改了设计方向 8. 是否引入了新的配置 测试有效性(④)四套件断言都核过,是真测试非恒真:
diff 整洁度(⑤)6 文件 +174/-2 全部与目的相关:2 个 src 各改 1-3 行核心逻辑 + 4 个测试。无跑题文件、无生成物/锁文件连带、无大段空白重排。干净。 CI Windows Node 22 shard 1 失败失败的 合并判定两处修复都打到根因(非堵症状)、范围收得紧、测试有牙、无意外回归、无新配置。代码层面可合。唯一待办是 CI 那个 Windows 红 job——非本 PR 之过,建议对照 #4599 确认后 merge ci-fixes 重跑转绿,再走人工合并(PR 自身要求 human review、不 auto-merge,符合 §7.4:动了 membership/session 绑定逻辑,本就该人工合)。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 重启进度汇报(进程卡死 35min 被强杀后重启。卡死原因:早期一次无超时的网络 git fetch 挂起;本轮所有网络调用已加 ≤20s 硬超时,不再长轮询)。 已完成(阶段性成果)本 PR 审核已完整做完并 posted(见上楼层 10 的八问全文):两处修复(#5040 无 ID 请求清空残留 membership 判定 / #5041 重启后核实的当前状态
需要 owner 拍板的一件事代码就绪、人工合并即可;唯一挡路的是那个与本 PR 无关的 master 级 Windows flake。二选一:① 不等它,直接合本 PR(flake 归哨兵/ci-fixes 后续收敛);② 等 ci-fixes 把该 spawn 套件硬化后再合。选①的话请自行合并 #5042 ;我不代合。 |
(ai: vllm-qwen/qwen3.8-27b) CI 自动修复完成(ci-worker-r1,attempt 1/2):已把 master 合入 PR 分支并推送,新 head 修复方式:此红是继承性失败,不是 PR 代码问题。PR 分支 base(
八问:
结论:CI 绿,自动修复合拢;PR 继续等待人工 review + owner 合并(代码层面审核结论不变:可合)。 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.909-master.47f15f8 # this exact build
npm install -g billion-context@master # always the newest merged build
|
Fixes #5040
Fixes #5041
Summary
Follow-up to supplemental review of #4982. Two independent fixes, split into two commits:
billing.prices: nullthrough the existing invalid-configuration path instead of throwing fromObject.entries. Startup warns and ignores it; both WebUI save routes return 400 without changing stored configuration or active overrides.The kernel interval lookup optimization (review item 2) is explicitly deferred. This PR contains no kernel changes and does not contain the separate fork-persistence patch.
Reproduction and validation
Before the fix, the real HTTP sequence main(100000) → foreign(5000) → no-ID main(200000) retained the 100000-token anchor; after the fix it reaches 200000. The regression also covers member→no-ID and verifies later foreign usage still cannot rewrite the anchor. All 10 requests use a real proxy and loopback fake upstream; no model API calls.
Null billing prices reproduced TypeError in parser, config load, and WebUI tests before the fix. Regression coverage checks warning/fallback, stale override removal, and byte-preserving rejection for structured and raw-file saves.
npm run typecheck: passed.npm run build: passed, including dist import/external checks.git diff --check: passed.Boundaries
The membership fix establishes sequential-request correctness. Concurrent requests still share the existing session-level verdict; request-local concurrent attribution is not redesigned here. No new config fields, schema changes, persistence changes, wire-shape changes, kernel changes, or release/version changes. Human review requested; do not auto-merge.
Remote CI on 87f64d2
CI run completed with one failing job: Windows Node 22 shard 1. Its two failures are in the unchanged
issue4982-draining-twin-ladder.test.ts: a graceful-shutdown marker timeout afterchild.kill("SIGTERM"), and an uncaught socketECONNRESET. Source inspection and Windows signal semantics point to existing platform-specific test issues; a Windows base-only reproduction has not been run. No unrelated tests were changed. All other executed test shards, static gates and associated workflows passed. Windows Node 24 checks are outside this run’s CORE matrix; their Expected state is not a queued job. This PR is not fully CI-green.