Repository navigation
[PR] test: follow-up #5016 — #4982 regression test cannot pass as written (self-contradictory assertion + teardown deadlock) - #5019
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.6618-pr.5019.4d2c72eThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5019.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重:不重复。 独立复核出站检索——open+closed 里唯一携带本失败签名( 审核独立性: 未照抄 PR 描述,对 PR 分支头 缺陷 1(自相矛盾断言)— 属实,修复正确。
缺陷 2(teardown 死锁)— 机制成立,修复标准。
行为变更: 无——纯测试文件,零生产代码;无配置面/wire shape/持久化格式。 CI(head 结构化八问:
合并判定: 代码层面已独立验证两处缺陷真实存在、修复精确命中根因;纯测试改动、零行为变更。等远程 CI 全绿即可由 owner 合入——这是把 master 从继承红拉回绿的必要一步。 |
|
(ai: vllm-qwen/qwen3.8-27b) 本 PR 已被 CI 哨兵并入 ci-fixes,无需再独立合并:
待 owner 关闭本 PR。 |
(ai: vllm-qwen/qwen3.8-27b) 先汇报进程状态:我上一轮收尾后卡住 ~31min 被强制重启。卡点大概率是我在收尾后本地重跑了那个会 spawn 子进程、绑端口的 e2e 测试( 收敛处置已独立核验(非照抄线程):用本地缓存的安全只读检查确认——
两处缺陷的验证结论维持不变(上一轮已钉死):① 断言自相矛盾属实—— 剩余动作 = owner-only:关闭 #5019 只能由 owner 执行(agent 不关单)。我不关闭、仅留此说明。改动已随 ci-fixes 落地,建议 owner 在 #5017 合入后关闭本 PR(内容既已在 ci-fixes,现在关闭亦可)。 判定: 无需我进一步动手;待 #5017 合入 + owner 关闭即可收工。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 状态(第二次重启后):本 issue 的工作上一轮已全部完成,本轮我只做了一次快速只读检查、未发起任何长耗时操作——这次「卡住 31min」应是任务收尾后进程空转等待被看门狗判为卡死,并非真实挂起。 当前实时进展(刚查):
待办:无我的动作。唯一剩余 = owner 关闭 #5019(建议 #5017 合入后执行)。 为避免刷屏的说明:此任务对我已收工。后续若无实质新事件(CI 转红/合入、owner 评论),我不会再就同一状态重复发帖;真正的新事件会重新唤醒我处理。若你希望我在 #5017 合入或 CI 全绿时主动回报一次,回一句即可,否则我就静默等事件驱动。 |
ec1ffa8 to
b0b0e66
Compare
Post-merge supplement to PR #5016 (fix for issue #4982).
查重: 无在途同类 PR(出站检索 open+closed issues/PRs,失败签名 =
tests/issue4982-draining-twin-ladder.test.ts+ERR_ASSERTION ... twin-collision+cancelledByParent)。What's wrong
PR #5016 shipped its regression pin with two latent test-side defects, both on code paths that only execute once the fix under test works — which is why pre-fix CI was green on this file and post-merge CI is red on it, on every shard/platform:
twin-collision:...treating the port as foreign-held instead of dying twin-collision (#4982). Test B asserts BOTHmatch(logText, /no longer answers as itself/)ANDdoesNotMatch(logText, /twin-collision/, ...)over the same log — impossible to satisfy whenever the demotion path fires (which is exactly what the test triggers). Deterministic failure:ERR_ASSERTION 'an unverified claim must never reach the twin-collision verdict'.silentTcpListenerfixture accepted probe connections and held them; a socket with no data listener stays paused, so peer EOF is never delivered once the probing child dies, leaving CLOSE-WAIT sockets that pinsquatter.close()forever (observed viassduring the hang: 4× CLOSE-WAIT owned by the test pid, peers FIN-WAIT-2 with no owning process). The test then ends by node:test cancellation (cancelledByParent,'Promise resolution is still pending but the event loop has already resolved').What changed (tests/issue4982-draining-twin-ladder.test.ts only)
already served by a same-build bili instance(shared by the early Pi duplicate startup writes index.db before twin adoption and disables unified storage #4341 path and the late path; absent from both warn lines) instead of the substringtwin-collision; test A's parallel assertion gets the same marker.sock.resume()) and destroys it on EOF, so dead probers can no longer pinclose().Behavior change flag
None — pure test-file change, zero production code touched. No config surface, no wire shape, no persistence format.
Verification
npm run typecheckclean.