Skip to content

[PR] fix(ci): unblock master static gates - drop orphaned export and stale duplicate doc rows - #3871

Merged
ranxianglei merged 2 commits into
masterfrom
2026-10-20_master-gate-red-storm-fix
Oct 20, 2026
Merged

ranxianglei merged 2 commits into
masterfrom
2026-10-20_master-gate-red-storm-fix

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Closes #3870

Two labeled commits, one per gate, both verified green locally on master @ 39fb841:

  1. docs: regenerate CONFIGURATION.md / CONFIGURATION.zh-CN.md - the generated param-ref block carried two stale duplicate rows (storage.unified pre-Storage wrap-up: 6 fixes + switch default mode to full (single PR) | 存储收尾六修 + 缺省模式翻 full(一个 PR 统一处理) #3818 unset (shadow) text, storage.sqliteAutoDownload) left inside the marker block by a bad merge resolution. Re-running tools/gen-config-docs.mjs generate removes exactly those four stale lines; every key stays documented once with current text. Fixes the docs-sync gate.
  2. fix(ci): drop the orphaned export on maskUrlForPublish (src/log-mask.ts:121) - introduced by a4f2730 ([security][web] Diagnostics blob prints private relay hosts verbatim in the config section — the "secrets masked" header only masks values, not hosts | 诊断包 config 段原样输出内网中转地址:标题说"密钥已遮蔽",但只遮值不遮主机 #3811), referenced only by maskUrlsForPublish in the same file, so scripts/check-unused-exports.mjs failed with INTERNAL_ONLY src/log-mask.ts: maskUrlForPublish. Same treatment as fix: drop orphaned export on codexRewriteInsertionIndex (Fixes #2314) #2315 did for maskUrlsInText. Fixes the unused-exports gate.

Behavior change: none. Pure gate repair - no runtime code path, config surface, or wire shape is touched. Until this lands, both gates sit in the needs chain of the test/static-gates jobs, so every run since ~14:49Z 2026-10-19 (master and all PR branches) skips its test lanes entirely (#3870).

Local evidence (worktree at master):

  • node scripts/check-unused-exports.mjs -> unused-export gate: clean (5 waived)
  • node tools/gen-config-docs.mjs generate && git diff --exit-code -- CONFIGURATION.md CONFIGURATION.zh-CN.md website/main.js website/docs/index.html -> exit 0

awork added 2 commits October 20, 2026 01:33
… by a bad merge resolution

The generated param-ref block in CONFIGURATION.md / CONFIGURATION.zh-CN.md
carried two duplicated rows (storage.unified, storage.sqliteAutoDownload):
the pre-#3818 spellings alongside the regenerated ones. Re-running
tools/gen-config-docs.mjs generate removes exactly those four stale lines;
every key stays documented once with current text. Fixes the docs-sync gate
red on master since 2026-10-19.
a4f2730 (#3811) introduced maskUrlForPublish with an export, but nothing
outside src/log-mask.ts imports it (only maskUrlsForPublish below calls it),
so scripts/check-unused-exports.mjs fails with:
  INTERNAL_ONLY src/log-mask.ts: maskUrlForPublish
Dropping the export keyword makes the gate pass again; no behavior change.
Same treatment as #2315 applied to maskUrlsInText.
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-20_master-gate-red-storm-fix (bdad5b0)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.4577-pr.3871.ceda8dc

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr3871.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei ranxianglei changed the title fix(ci): unblock master static gates - drop orphaned export and stale duplicate doc rows [PR] fix(ci): unblock master static gates - drop orphaned export and stale duplicate doc rows Oct 19, 2026
@ranxianglei

Copy link
Copy Markdown
Owner Author

(ai: vllm-qwen/qwen3.8-27b)

Supplementing evidence from the #3876 work (these two red lanes are pre-existing on master and unrelated to any in-flight PR):

ranxianglei added a commit that referenced this pull request Oct 19, 2026
Commit 66219d4 added externalSummary to COMPRESS_SETTING_FIELDS on this
branch; the config-surface guard then fails HERE (leaf compress.externalSummary
lacks a seed entry) until #3880's seed lands on master - i.e. merge order
mattered: merging this PR first would have put a NEW red on master's own
config-surface-guard. This mirrors #3880's exact seed entry (byte-identical,
so either PR may merge first and the duplicate is a clean no-op) plus the
generator output for it (5 added lines, 0 removed), making this branch
self-contained green for both config-surface-guard and docs-sync once the
pre-existing master static-gate red (#3870/#3871) clears.
ranxianglei added a commit that referenced this pull request Oct 19, 2026
Commit 66219d4 added externalSummary to COMPRESS_SETTING_FIELDS on this
branch; the config-surface guard then fails HERE (leaf compress.externalSummary
lacks a seed entry) until #3880's seed lands on master - i.e. merge order
mattered: merging this PR first would have put a NEW red on master's own
config-surface-guard. This mirrors #3880's exact seed entry (byte-identical,
so either PR may merge first and the duplicate is a clean no-op) plus the
generator output for it (5 added lines, 0 removed), making this branch
self-contained green for both config-surface-guard and docs-sync once the
pre-existing master static-gate red (#3870/#3871) clears.
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

收到转发的两条评论:#3876 的补充证据是之前 agent 会话(我)发的,无新增信息需要回应;github-actions 的构建通知是纯信息性的,无需动作。借这次唤醒对 PR 现状做了一轮终态确认(全部在推送的 head bdad5b0 上验证,不是本地工作树):

复核结果

  • diff 审计:3 个文件、+1/-5,两个标注 commit 与描述逐行一致——src/log-mask.ts:121 只删了 export 关键字(函数体未动),CONFIGURATION.md / CONFIGURATION.zh-CN.md 各删恰好 2 行陈旧重复行。运行时、配置面、wire 形状零触碰。
  • 门禁脚本在本 commit 上本地实跑:node scripts/check-unused-exports.mjs → clean (4 waived);node tools/gen-config-docs.mjs generate → 幂等收敛(4 个生成产物零 diff)。
  • 本 head 的 CI 全量明细:40 个 check run 全部 completed,零失败、零 pending。关键点:因为两条静态门禁在这个 head 上是绿的,全量 test lane 这次真正跑起来了并且全过(ubuntu 22/24 × 3 shard + windows 22 × 2 shard 均 success)——在 master 上这些 lane 因红门禁被整体 skip,所以这是该修复形态下的第一份完整套件证据。real-client e2e 各 lane 按各自的 env 门控正常 skip。
  • 基线新鲜度:master tip 仍是 39fb841 = 本 PR 的 base,零漂移,GitHub 判定 mergeable(无冲突),不需要 rebase。

现状与待办:PR open、checks 全绿;mergeable_state=blocked 是分支保护/待审状态,不是检查失败。合并是你的操作,可直接合。

合并后的效果:关闭 #3870,master CI 转绿,其余所有在途 PR(如 #3880)的全量套件 CI 自动恢复运行。

查重:不重复——同方向的两条修复尝试 #3877/#3882 已在 #3876 工作中按先来后到关闭为本 PR 的重复项。

判定:可合,无遗留动作。

ranxianglei pushed a commit that referenced this pull request Oct 20, 2026
The five ContextView* shapes and ModelSwitchStats are consumed structurally (buildContextView's return value / cache-ledger internals); nothing outside their own files names them, so the #1440 P6 gate flags them as INTERNAL_ONLY. Drop the leading export keyword only - no behavior change. The remaining local gate hit (src/log-mask.ts maskUrlForPublish) is pre-existing master drift tracked by #3870 with fixes in flight (#3871/#3887); deliberately not bundled here.
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

独立本地验证:把本 PR 的三个文件(CONFIGURATION.md / CONFIGURATION.zh-CN.md / src/log-mask.ts)应用到当前 master 树上后,docs-sync 与 unused-exports 两个静态 gate 本地均通过。

重叠提示:#3887 修的是同样两个缺陷、动的是同样三个文件(更晚提交)。本 PR 合入后 #3887 即冗余,可直接关闭;反之亦然——两者合一个即可。

@ranxianglei
ranxianglei merged commit 3d2b0b5 into master Oct 20, 2026
40 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📦 Merged Build Published

This merge to master was published as 0.0.629-master.3d2b0b5 (rolling master tag).

npm install -g billion-context@0.0.629-master.3d2b0b5  # this exact build
npm install -g billion-context@master  # always the newest merged build

npm view billion-context@master prints the current version at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI static gates (unused-exports + docs-sync) red on master since 2026-10-19 - all PR test lanes skipped

1 participant