Skip to content

[PR] fix: repair red CI guards on master (unused-exports + docs-sync) - #3877

Closed
ranxianglei wants to merge 2 commits into
masterfrom
2026-10-20_master-ci-gates-repair
Closed

ranxianglei wants to merge 2 commits into
masterfrom
2026-10-20_master-ci-gates-repair

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

What this is

Two tier-1 guard jobs fail on master itself (reproduced locally on pristine master 39fb841d3, before any PR content):

  1. unused-exports flags src/log-mask.ts: maskUrlForPublish is exported but has zero external importers — it is only called internally by maskUrlsForPublish (same file). The export was introduced by [security][web] Diagnostics blob prints private relay hosts verbatim in the config section — the "secrets masked" header only masks values, not hosts | 诊断包 config 段原样输出内网中转地址:标题说"密钥已遮蔽",但只遮值不遮主机 #3811 (fix: mask private endpoint hosts in the publish-boundary diagnostics blob).
  2. docs-sync fails because the committed CONFIGURATION.md / CONFIGURATION.zh-CN.md contain stale duplicated rows the generator no longer emits: an old storage.unified row (pre-Storage wrap-up: 6 fixes + switch default mode to full (single PR) | 存储收尾六修 + 缺省模式翻 full(一个 PR 统一处理) #3818 default flip) sitting next to the current one, and an old storage.sqliteAutoDownload row missing the SQLite unified storage degraded to legacy-only (bili v0.1.201, node v20.19.5, win32-x64) #3788 cooldown sentence — merge-resolution residue from recent storage merges.

Why it matters

.github/workflows/ci.yml gates static-gates and the full test matrix behind !failure() of the earlier jobs, so these two red guards make every PR's merge-ref run skip its entire test suite — no PR can get a full-suite verdict while master carries them. This is what blocked the test lanes of #3867.

Changes (5 lines across 3 files)

  • src/log-mask.ts: drop the export keyword from maskUrlForPublish (one word; no importers anywhere in src/, tests/, scripts/, tools/).
  • CONFIGURATION.md / CONFIGURATION.zh-CN.md: commit the output of node tools/gen-config-docs.mjs generate (4 deletions total — only the stale duplicate rows; no key added, renamed or re-semanticed, so no config-surface change).

Verification

Discovered during review of #3867 (its CI showed both guards failing on the merge ref while passing on the bare head).

@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-20_master-ci-gates-repair (4c77716)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.4590-pr.3877.cc0cb05

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr3877.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

(ai: vllm-qwen/qwen3.8-27b)

Closing: duplicate of #3871 — same symptom/mechanism/root cause, byte-equivalent changeset (CONFIGURATION.md -2, CONFIGURATION.zh-CN.md -2, src/log-mask.ts +1/-1), same base 39fb841. First-come-first-served: #3871 (opened 2026-10-19T17:43Z) predates this one (21:12Z), and its CI already shows docs-sync ✓ + unused-exports ✓ on head bdad5b0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant