Skip to content

[PR] fix: green the two red CI static gates (unused-exports + docs-sync) #3870 - #3887

Merged
ranxianglei merged 3 commits into
masterfrom
2026-10-20_fix-ci-static-gates-3870
Oct 20, 2026
Merged

ranxianglei merged 3 commits into
masterfrom
2026-10-20_fix-ci-static-gates-3870

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Closes #3870

What

Two independent defects left master's unused-exports and docs-sync static gates red since 2026-10-19 ~14:49Z. Because the test/static-gates jobs list both gates in their needs, every PR's test lanes were skipped wholesale — no full-regression evidence was obtainable for any in-flight PR, and master stayed red. Both gates are verified green locally after this change (run exactly as CI).

Three labeled commits — no behavior change:

  1. fix: drop the orphan export on maskUrlForPublish (src/log-mask.ts:121). [security][web] Diagnostics blob prints private relay hosts verbatim in the config section — the "secrets masked" header only masks values, not hosts | 诊断包 config 段原样输出内网中转地址:标题说"密钥已遮蔽",但只遮值不遮主机 #3811 exported it but only maskUrlsForPublish in the same file calls it → an INTERNAL_ONLY orphan the gate flags. No external importer exists (AST gate + repo-wide grep); tests/log-mask.test.ts does not import it either. Made module-local.
  2. docs: regenerate CONFIGURATION (+zh) to drop 4 stale duplicate rows in the generated param-ref block — bad-merge residue where storage.unified (pre-Storage wrap-up: 6 fixes + switch default mode to full (single PR) | 存储收尾六修 + 缺省模式翻 full(一个 PR 统一处理) #3818 unset (shadow) text) and storage.sqliteAutoDownload (missing the SQLite unified storage degraded to legacy-only (bili v0.1.201, node v20.19.5, win32-x64) #3788 cooldown sentence) each appeared twice (new + old row coexisting). Seeds are correct, so regeneration converges to a pure deletion; no key description lost.
  3. docs: correct the hand-written long env description of BILI_STORAGE_UNIFIED, which still ended "Default off." / "默认关闭。" — stale since the Storage wrap-up: 6 fixes + switch default mode to full (single PR) | 存储收尾六修 + 缺省模式翻 full(一个 PR 统一处理) #3818 storage-full flip made unset default to full. Same root cause as fix: address all code review findings (condense, routing, session-id, dead code) #2, flagged during the [PR] feat: add supported session cleanup (bili sessions ls/rm/prune + VACUUM) #3860 audit. This line sits OUTSIDE the generated blocks, so it neither broke nor was fixed by the docs-sync gate; corrected to state the real default.

Verification (local, mirrors the CI gates)

  • node scripts/check-unused-exports.mjs → ✓ clean (5 waived), exit 0
  • node tools/gen-config-docs.mjs generate && git diff --exit-code -- CONFIGURATION.md CONFIGURATION.zh-CN.md website/main.js website/docs/index.html → clean, working tree pristine
  • diff = 3 files (src/log-mask.ts 1 line; each CONFIGURATION −3/+1); every line in scope

Behavior change: none — pure gate repair plus a doc wording fix that merely catches up to code whose default is already full.

awork added 3 commits October 20, 2026 08:14
…s gate (#3870)

#3811 exported maskUrlForPublish but only maskUrlsForPublish in the same
file calls it — an orphan export the unused-exports gate flags as
INTERNAL_ONLY. Make it module-local; no external importer exists.
…#3870)

The generated param-ref block carried a bad-merge residue: storage.unified
(pre-#3818 'unset (shadow)' text) and storage.sqliteAutoDownload (missing the
#3788 cooldown sentence) each appeared twice — new + old row coexisting. The
seeds are correct, so regenerating converges to a pure deletion of the 4
stale duplicate rows; no key description is lost.
…ow full (#3870)

The hand-written long env description of BILI_STORAGE_UNIFIED still ended
'Default off.' / '默认关闭。' — stale since the #3818 storage-full flip that
made unset default to full (the generated rows already say 'unset (full)').
Same root cause as the dedup above, flagged during the #3860 audit. Correct
the trailing sentence to state the real default.
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-20_fix-ci-static-gates-3870 (2cbb851)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.4601-pr.3887.cfdeba8

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr3887.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei ranxianglei changed the title fix: green the two red CI static gates (unused-exports + docs-sync) #3870 [PR] fix: green the two red CI static gates (unused-exports + docs-sync) #3870 Oct 20, 2026
ranxianglei pushed a commit that referenced this pull request Oct 20, 2026
The five ContextView* shapes and ModelSwitchStats are consumed structurally (buildContextView's return value / cache-ledger internals); nothing outside their own files names them, so the #1440 P6 gate flags them as INTERNAL_ONLY. Drop the leading export keyword only - no behavior change. The remaining local gate hit (src/log-mask.ts maskUrlForPublish) is pre-existing master drift tracked by #3870 with fixes in flight (#3871/#3887); deliberately not bundled here.
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

独立本地验证:把本 PR 的三个文件(CONFIGURATION.md / CONFIGURATION.zh-CN.md / src/log-mask.ts)应用到当前 master 树上后,docs-sync 与 unused-exports 两个静态 gate 本地均通过。

重叠提示:更早提交的 #3871 修的是同样两个缺陷、动的是同样三个文件。两者合入任意一个即可,另一个即冗余可直接关闭(先来后到建议优先 #3871);合入后我的 #3886 会 rebase 到修复后的 master,届时其测试矩阵才会真正跑起来。

@ranxianglei
ranxianglei merged commit ed635f7 into master Oct 20, 2026
40 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📦 Merged Build Published

This merge to master was published as 0.0.628-master.ed635f7 (rolling master tag).

npm install -g billion-context@0.0.628-master.ed635f7  # this exact build
npm install -g billion-context@master  # always the newest merged build

npm view billion-context@master prints the current version at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI static gates (unused-exports + docs-sync) red on master since 2026-10-19 - all PR test lanes skipped

1 participant