Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs/skills/validation/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,16 @@ Do not run the full application suite for documentation-only changes.
8. For live-data cache updates, keep the cached file path list identical in order and content across `update-content.yml` (restore and save), `deploy.yml` (restore), and `preview.yml` (restore).
9. When modifying a Vue component under `src/components/`, check `src/tests/` for existing component unit tests and keep test assertions aligned with the runtime contract.
10. For CI concurrency changes, keep pull-request runs grouped by PR and non-PR runs unique; `scripts/tests/workflow-concurrency.test.ts` checks cancellation and group isolation. Assert the parsed YAML expressions directly instead of executing them as JavaScript.
11. Renovate's npm pin (`constraints.npm` in `renovate.json`) must match the npm CI runs, which is the one bundled with Node (`node-version: '26'` → npm 11). With npm 12, Renovate's lock-file updates failed (#1009, `EALLOWREMOTE`). Renovate doesn't offer updates to the pin, so a Node major PR that brings a newer npm fails `scripts/tests/npm-constraint.test.ts` with the exact value to set. Fix it by raising `constraints.npm` in that same PR, not by editing or skipping the test.
11. For an ESLint or `@antfu/eslint-config` upgrade, move both packages in one
change (each major of the config pins the ESLint major it accepts), and
check that `npm run lint:fix` changed only layout: compare each touched
file with all whitespace stripped against `HEAD`. Turn off a new rule
whose auto-fix rewrites code (for example `e18e/prefer-object-has-own`,
which needs a newer `lib` than `tsconfig.json` sets) instead of letting
the reformat carry it. Lore bodies render Markdown heading markers as
literal text, so a `markdown/heading-increment` fix changes what the
audience reads; keep it to the marker itself.
12. Renovate's npm pin (`constraints.npm` in `renovate.json`) must match the npm CI runs, which is the one bundled with Node (`node-version: '26'` → npm 11). With npm 12, Renovate's lock-file updates failed (#1009, `EALLOWREMOTE`). Renovate doesn't offer updates to the pin, so a Node major PR that brings a newer npm fails `scripts/tests/npm-constraint.test.ts` with the exact value to set. Fix it by raising `constraints.npm` in that same PR, not by editing or skipping the test.

Documentation-only check:

Expand Down
23 changes: 20 additions & 3 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,29 @@ export default antfu({
yaml: false,
markdown: true,
rules: {
'no-console': ['error', {
allow: ['info', 'warn', 'trace', 'error', 'group', 'groupEnd'],
}],
'no-console': [
'error',
{
allow: [
'info',
'warn',
'trace',
'error',
'group',
'groupEnd'
],
}
],
'style/comma-dangle': 'off',
'curly': ['error', 'all'],
'node/prefer-global/process': ['error', 'always'],
// @antfu/eslint-config v10 adds these e18e rules with auto-fixes that
// change code, not just layout. Object.hasOwn is outside the ES2020 `lib`
// in tsconfig.json, and `Array.from({ length }).fill(x)` widens the
// result to unknown[]. Keep them off so the v10 upgrade stays
// behaviour-neutral; enable them deliberately in a separate change.
'e18e/prefer-array-fill': 'off',
'e18e/prefer-object-has-own': 'off',
},
formatters: {
/**
Expand Down
Loading
Loading