Repository navigation
Conversation
Enable what upstream presets turn on and a booted Dakota runs, in the preset, configure-services.sh and the desktop contract: nvme-cli's NVMe-oF boot connections (condition-gated on config or FC hardware), systemd-imdsd.socket, the system speech-dispatcherd.service, podman.service, and netavark's DHCP proxy and firewall-reload hooks. mdadm's mdcheck_start, mdcheck_continue and mdmonitor-oneshot timers stay off and are asserted disabled: Utah keeps raid-check.timer (#1268), which the mdcheck pair would duplicate, and Fedora's always-on mdmonitor.service would pull the oneshot reminder in daily on every machine, where it exits 1 without an mdadm.conf alert address. systemd-homed-firstboot belongs to #1238. Closes #1271 Closes #1272 Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danathar, hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Withdrawn: this PR is not back in your court after all. The failing checks ( |
Danathar
left a comment
There was a problem hiding this comment.
Stand-in review (the hive's reviewers are out of quota). Approving. It only adds enablements Dakota runs (the NVMe-oF units, skipped by their own conditions; systemd-imdsd.socket; speech-dispatcherd; podman/netavark), keeps the mdadm timers off with tests, and doesn't touch homed. systemd-homed-firstboot stays for #1238. systemd-imdsd.socket is a Varlink socket (Accept=yes) that starts systemd-imdsd@.service only per connection. The units that fetch metadata over the network are pulled in by the imds generator on cloud, not by this socket, so a desktop makes no requests. The red contract is the stack's. Before merge: none of these units is in the testsuite's "No failed systemd units at boot" VM allowlist, so a review-VM run should confirm systemd-imdsd.socket (SELinux under Fedora 44 policy) and speech-dispatcherd start cleanly.
|
Folded into the part-2 landing PR (fold/dakota-sq) with this change unchanged apart from rebase and conflict resolution. Closing here; review continues there. |
What
Units are wired in
85-utah-desktop.preset,scripts/configure-services.shandcontracts/bluefin-desktop.toml[services].ServiceMaskParityTestsgets two new tests that check all three places agree, and the reference isdocs/skills/desktop-contract/references/dakota-services.md.Enabled, as on Dakota (measured:
ghcr.io/projectbluefin/dakota:testing/etc/systemd/system/*.wants):nvmf-autoconnect.service,nvmefc-boot-connections.servicedefault.target.wantssystemd-imdsd.socketsockets.target.wantsspeech-dispatcherd.servicemulti-user.target.wantspodman.servicedefault.target.wantsnetavark-dhcp-proxy.socket/.servicesockets.target.wants/default.target.wantsnetavark-firewalld-reload.servicefirewalld.service.wantsnetavark-nftables-reload.servicenftables.service.wantsThe two NVMe-oF units are each skipped by their own
ConditionPathExists=unless/etc/nvme/{config.json,discovery.conf}exists (autoconnect) or/sys/class/fc/fc_udev_device/nvme_discoveryexists (FC).netavark-firewalld-reload.serviceisn't named in #1272, but Dakota enables it and Utah runs firewalld, so it belongs with the rest of the netavark set.Kept off, asserted in
[services].disabled:mdcheck_start.timer,mdcheck_continue.timer,mdmonitor-oneshot.timer.raid-check.timer(parity(dakota): Utah-only system services Dakota doesn't run #1268 owner decision), which scrubs every array weekly. The mdcheck pair is a second scrub scheduler for the same arrays.WantedBy=mdmonitor.service. On Dakota that service is static and starts only when udev assembles an array (63-md-raid-arrays.rules). On Utah, Fedora's preset enables it at boot on every machine, so the timers would be pulled in everywhere. Infedora:44,mdadm --monitor --oneshot --scanwith nomdadm.confprints "No mail address or alert command - not monitoring." and exits 1, so the oneshot reminder would fail daily on non-RAID machines.systemd-homed-firstboot.service(#1272) belongs to #1238, which carries the homed decision.Stacked on #1283.
Closes #1271
Closes #1272
Verification
utah:testing(/tmp/dakota-scan/utah/system-units.tsv). The enabled ones are listed asdisabledthere, and the mdadm timers as well.fedora:44and ran themdadm --monitor --oneshot --scancheck above.just checkpasses (1332 tests).