Skip to content

fix: enable storage checks and network drive discovery - #1276

Closed
Karibhou wants to merge 3 commits into
projectbluefin:mainfrom
Karibhou:fix/1271-storage-units
Closed

Karibhou wants to merge 3 commits into
projectbluefin:mainfrom
Karibhou:fix/1271-storage-units

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Summary: This enables the same storage health checks and network drive discovery used by Dakota. It also avoids running two overlapping checks on the same array.


Enables the mdadm timers and NVMe-over-Fabrics services in the image and first-boot preset, disables Fedora’s raid-check timer, and checks their states in the image contract.

Closes #1271

Validation: not run locally; CI verifies the image contract.

— hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra

Align storage maintenance and discovery with Dakota.

Hive-Run: projectbluefin#1271
Hive-Plan: storage-unit parity
Hive-Spec: issue-1271#storage-units
Assisted-by: openai-codex/gpt-6.1-terra via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@Karibhou

Copy link
Copy Markdown
Contributor Author

Summary: The proposed storage changes are ready for review. Automated checks will verify the image before it can merge.


hive/awaiting-ci: CI pending — sweep will merge when green.

— hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra

@github-actions
github-actions Bot requested review from Danathar and hanthor November 16, 2026 03:57
@github-actions

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ahmedadan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmedadan in a comment when ready.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Karibhou

Copy link
Copy Markdown
Contributor Author

hive-base-moved: merged main at cee0b7a into this PR branch.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/ok-to-test

@github-actions

Copy link
Copy Markdown
Contributor

Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • contract

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

/ok-to-test

@github-actions

Copy link
Copy Markdown
Contributor

Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hanthor

hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member

Owner decision (2026-11-16, delegated): closing as superseded by #1285, which covers #1271/#1272 on the Dakota stack. mdadm's mdcheck_* and mdmonitor-oneshot timers stay off by design: #1268 keeps Fedora's raid-check.timer, and running both would double-scrub arrays. mdmonitor-oneshot also exits 1 when no alert address is configured. Thanks for the quick turnaround.

@hanthor hanthor closed this Nov 16, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stand-in review (the hive's reviewers are out of quota). Approving. It enables Dakota's storage units (mdcheck_start/mdcheck_continue/mdmonitor-oneshot timers, nvmf-autoconnect and nvmefc-boot-connections) and disables Fedora's raid-check.timer, so two array checks don't overlap. From the upstream units: nvmf-autoconnect runs only if /etc/nvme/config.json or discovery.conf exists, nvmefc-boot-connections runs only if the FC sysfs node exists, and the mdcheck timers are WantedBy=mdmonitor.service, which udev pulls in only for RAID1+ arrays. So a plain desktop shouldn't gain failed units. nfs-client.target isn't touched (still disabled with the gssproxy note; #1269 owns that). The preset, configure-services.sh and the contract agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parity(dakota): mdadm check timers and NVMe-oF units

4 participants