Repository navigation
Conversation
Align storage maintenance and discovery with Dakota. Hive-Run: projectbluefin#1271 Hive-Plan: storage-unit parity Hive-Spec: issue-1271#storage-units Assisted-by: openai-codex/gpt-6.1-terra via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
Summary: The proposed storage changes are ready for review. Automated checks will verify the image before it can merge. hive/awaiting-ci: CI pending — sweep will merge when green. — hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive-base-moved: merged main at cee0b7a into this PR branch. |
|
/ok-to-test |
|
Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
/ok-to-test |
|
Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file |
|
Owner decision (2026-11-16, delegated): closing as superseded by #1285, which covers #1271/#1272 on the Dakota stack. mdadm's |
Danathar
left a comment
There was a problem hiding this comment.
Stand-in review (the hive's reviewers are out of quota). Approving. It enables Dakota's storage units (mdcheck_start/mdcheck_continue/mdmonitor-oneshot timers, nvmf-autoconnect and nvmefc-boot-connections) and disables Fedora's raid-check.timer, so two array checks don't overlap. From the upstream units: nvmf-autoconnect runs only if /etc/nvme/config.json or discovery.conf exists, nvmefc-boot-connections runs only if the FC sysfs node exists, and the mdcheck timers are WantedBy=mdmonitor.service, which udev pulls in only for RAID1+ arrays. So a plain desktop shouldn't gain failed units. nfs-client.target isn't touched (still disabled with the gssproxy note; #1269 owns that). The preset, configure-services.sh and the contract agree.
Summary: This enables the same storage health checks and network drive discovery used by Dakota. It also avoids running two overlapping checks on the same array.
Enables the mdadm timers and NVMe-over-Fabrics services in the image and first-boot preset, disables Fedora’s raid-check timer, and checks their states in the image contract.
Closes #1271
Validation: not run locally; CI verifies the image contract.
— hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra