Repository navigation
Conversation
…ent.target nfs-client.target pulls in gssproxy.service through auth-rpcgss-module.service, whose Wants= applies even without a keytab. gssproxy's StateDirectory=gssproxy/clients gssproxy/rcache failed with 238/STATE_DIRECTORY: clean-stage strips /var, so systemd has to create the directories, and the SELinux policy gives init_t no add_name on gssproxy_var_lib_t. Ship tmpfiles.d/utah-gssproxy.conf with the RPM's three directories and modes; systemd-tmpfiles may create and label them. With gssproxy fixed, enable nfs-client.target as Dakota's elements/bluefin/nfs-utils.bst presets it, in the preset, configure-services.sh and the desktop contract. Closes #1269 Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danathar, hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hanthor this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (13 waiting): fixes are handed out before new work as soon as you have capacity. |
Danathar
left a comment
There was a problem hiding this comment.
Stand-in review (the hive's reviewers are out of quota). Approving. The cause and the fix check out independently. Cause: Fedora's gssproxy 0.9.2 (the same as the factory recipe) has StateDirectory=gssproxy/clients gssproxy/rcache with StateDirectoryMode=0700. In Hummingbird's selinux-policy-targeted 45.24, sesearch shows init_t has create/setattr/write on gssproxy_var_lib_t dirs but no add_name, so systemd can create /var/lib/gssproxy but not clients/ and rcache/ inside it. That matches the review VM's 238/STATE_DIRECTORY, Permission denied. systemd_tmpfiles_t has add_name and create, so the new tmpfiles lines, which match the RPM's directories and modes, are the right fix. Why it matters: nfs-client.target → auth-rpcgss-module.service → Wants=gssproxy.service, and a failed ConditionPathExists doesn't cancel the Wants, so gssproxy starts every boot. Risk to watch: gssproxy.service isn't in the smoke "No failed systemd units" allowlist, so if it still fails for a reason not visible here, the first booted :testing build goes red. Check systemctl status gssproxy there.
|
Folded into the part-2 landing PR (fold/dakota-sq) with this change unchanged apart from rebase and conflict resolution. Closing here; review continues there. |
What
system_files/shared/usr/lib/tmpfiles.d/utah-gssproxy.confcreates gssproxy's directories with the owner and modes from its RPM's%files:nfs-client.targetis enabled in85-utah-desktop.preset,configure-services.shand[services].enabled. This replaces thedisablelines and their "cause not diagnosed" comments. Note: the contract'sdisabledlist never named the target, so there was nothing to remove there.dakota-services.md,factory-consumption.md, and thepackages/utah.tomlcomment.ServiceMaskParityTestsgets a test that checks the three-way wiring and the tmpfiles lines.Root cause
nfs-client.target→auth-rpcgss-module.service→Wants=gssproxy.service rpc-gssd.service. ThatWants=applies even thoughauth-rpcgss-moduleitself is skipped byConditionPathExists=/etc/krb5.keytab, so gssproxy starts on every boot.StateDirectory=gssproxy/clients gssproxy/rcachewithStateDirectoryMode=0700. On Fedora the RPM ships those directories, so systemd never creates them.clean-stage.shstrips all of/varexcept caches. The only gssproxy tmpfiles line is the RPM'sL /var/lib/gssproxy/default.sock. So at boot systemd itself has to createclients/andrcache/inside/var/lib/gssproxy./var/lib/gssproxyis labelledgssproxy_var_lib_t. In Hummingbird'sselinux-policy-targeted-45.24(policy.35),sesearch -A -s init_t -t gssproxy_var_lib_t -c dirgives init_tcreate,setattrandwrite(theinit_create_dirsboolean), but noadd_name. Creating an entry in that directory is denied, which matches thestatus=238/STATE_DIRECTORY, Permission denied the review VM saw.systemd_tmpfiles_thasadd_name create … relabeltoonnon_auth_file_typedirs, and tmpfiles runs before services. Once the directories exist with the right mode and owner,StateDirectory=has nothing to create.Dakota builds nfs-utils
--disable-gss(elements/bluefin/nfs-utils.bst), so it runs no gssproxy at all. Utah keeps the factory's GSS-capable build, as Fedora does, and fixes the state directory instead.Stacked on #1285.
Closes #1269
Verification
sesearchagainst Hummingbird's own policy RPM, as described above. Fedora 44's policy gives the same result.nfs-client.target,auth-rpcgss-module,rpc-gssd,rpc-statd-notifyandgssproxyunits infedora:44.just checkpasses (1333 tests).gssproxy.serviceis active andsystemctl --failedis empty.