Skip to content

feat(packages): install opensc with GNOME OS's opensc.module, as on Dakota - #1281

Closed
hanthor wants to merge 1 commit into
feat/dakota-ifusefrom
feat/dakota-opensc
Closed

hanthor wants to merge 1 commit into
feat/dakota-ifusefrom
feat/dakota-opensc

Conversation

@hanthor

@hanthor hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member

What

  • Install opensc from the factory: add it to [parity] and [factory].parity.
  • Ship GNOME OS's opensc.module as system_files/shared/etc/pkcs11/modules/opensc.module, and assert it plus its disable-in line in contracts/bluefin-desktop.toml.
  • Document it in docs/skills/desktop-contract/references/dakota-system-defaults.md.

Why

Dakota ships opensc 0.27.1 (freedesktop-sdk-extra.bst:components/opensc.bst). The pinned factory publishes opensc-0.27.1-1.hum1.bfin (element audit utah-packages#1017: aligned). GNOME OS adds files/opensc/opensc.module (gnome-build-meta 8a89846df11e):

module: opensc-pkcs11.so
disable-in: goa-daemon gsd-smartcard evolution-source-registry evolution-calendar-factory gnome-shell

Smart cards grant exclusive access while a PIN is unlocked. If those user daemons hold the card, GnuPG can't get exclusive access. The factory RPM's own /usr/share/p11-kit/modules/opensc.module has no disable-in. p11-kit reads a module config in /etc/pkcs11/modules/ in place of the same-named package file. Utah can't overlay /usr/share: system_files is copied before the package transaction, which would overwrite it.

pcscd.socket is already enabled (#1254). pam-pkcs11 decision: Dakota ships it with a preset that disables it. Fedora retired it, so the factory needs a new spec (projectbluefin/utah-packages#1030). Utah adopts it once it's published. Until then its planned triage entry under #1236 stays.

Stacked on #1280.

Closes #1257

Verification

  • fedora:44 with opensc and p11-kit: stock p11-kit list-modules shows opensc. An /etc/pkcs11/modules/opensc.module with disable-in: p11-kit hides it, which proves /etc overrides /usr/share. With this PR's file, opensc is listed again, because p11-kit isn't in the list.
  • Pinned factory repodata (sha256:523507b8) has opensc and opensc-libs 0.27.1 .bfin.
  • just check passes (1330 tests).

…akota

Dakota ships opensc 0.27.1 (freedesktop-sdk-extra components/opensc.bst)
and GNOME OS's files/opensc/opensc.module, whose disable-in list keeps
goa-daemon, gsd-smartcard, the Evolution data-server factories and
gnome-shell from holding a smart card open. The factory builds the same
opensc; Utah ships the module config in /etc/pkcs11/modules, which p11-kit
reads in place of the RPM's same-named /usr/share/p11-kit/modules copy.

pam-pkcs11, which Dakota ships preset-disabled, follows once the factory
publishes it (projectbluefin/utah-packages#1030).

Closes #1257

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danathar, hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Withdrawn: this PR is not back in your court after all. The failing checks (contract) are red on the base branch too; this change did not break them. There is nothing to fix here: the PR is back on the normal path, and the hive checks it again once the base branch is green.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Superseded by #1274 (earlier fix for #1257). The merge queue carries one PR per issue, so this PR is held out of it and returned to its author; close it if #1274 covers the change, or let the delegate decide.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hanthor

hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

More verification: I ran scripts/check-repo-availability.py (the real install-packages.py --resolve transaction on the pinned os-minimal@sha256:a98c8cf5 base) against a scratch copy of the series tip. It resolves git-lfs-3.8.1-0.2.hum1 (Hummingbird), plus ifuse-1.2.1-1.hum1.bfin, opensc-0.27.1-1.hum1.bfin and opensc-libs (utah-packages). Two caveats about that copy: it uses the latest factory digest sha256:b4fce6cd, and it drops gnome-os-config-*, which the base stack (#1273) adds but no factory image publishes yet. The currently pinned factory sha256:523507b8 stops on the stack's own unpublished names (power-profiles-daemon, gnome-os-config-*) before it gets to these.

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
@Danathar

Copy link
Copy Markdown
Contributor

The hive's "Superseded by #1274" hold is a false duplicate: #1274 is the input-methods PR and has no opensc, pkcs11 or smartcard change. It only linked #1257 through a mistaken Fixes #1257 line, which I've asked its author to remove. This PR is the real fix for #1257.

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stand-in review (the hive's reviewers are out of quota). Approving. opensc.module (module: opensc-pkcs11.so plus the disable-in: goa-daemon gsd-smartcard evolution-source-registry evolution-calendar-factory gnome-shell line) is identical to freedesktop-sdk-extra 26.08.4's files/opensc/opensc.module, apart from an SPDX header. p11-kit reads user, then /etc/pkcs11/modules, then package configs, and the first config with a name wins, so shipping it in /etc overrides the RPM's copy without being overwritten by it. Nit: gnome-build-meta moved this element to freedesktop-sdk-extra on 2026-10-03 (1100ec066727), so the header and docs should cite freedesktop-sdk-extra rather than gnome-build-meta@8a89846. The red contract is the stack's.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hivecommons-hive hivecommons-hive Bot linked an issue Nov 16, 2026 that may be closed by this pull request
@hanthor

hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Folded into the part-2 landing PR (fold/dakota-sq) with this change unchanged apart from rebase and conflict resolution. Closing here; review continues there.

@hanthor hanthor closed this Nov 16, 2026
@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parity(dakota): install opensc for smart cards

2 participants