Repository navigation
Conversation
The Containerfile removed /etc/dconf/db/distro.d/05-bluefin-searchlight- extension, which the pinned Common (sha256:9faad517) no longer ships, so the rm and its comment were dead. Utah's copy of pipewire-pulse.conf.d/50-bluefin-bt-switch.conf only added `pulse.cmd = [ ]`, which Common's copy now carries itself; drop the override and pin Common's line in the desktop contract so a Common regression fails the build. Utah keeps tracking Common's latest digest through Renovate rather than Dakota's release tag; the containerfile skill records why. Closes #1267 Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danathar, hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Withdrawn: this PR is not back in your court after all. The failing checks ( |
Danathar
left a comment
There was a problem hiding this comment.
Stand-in review (the hive's reviewers are out of quota). Approving. Checked against the actual pinned Common layer (sha256:9faad517…): distro.d/05-bluefin-searchlight-extension no longer exists (Common removed it in #1356), so the rm -f was a no-op. 50-bluefin-bt-switch.conf in Common is byte-identical to Utah's copy, including pulse.cmd = [ ]. The Containerfile copies Common's tree before Utah's, so deleting Utah's copy leaves Common's in place and the image unchanged. The new contract entries make a Common regression fail the build.
|
Folded into the part-2 landing PR (fold/dakota-sq) with this change unchanged apart from rebase and conflict resolution. Closing here; review continues there. |
What
Containerfile: droprm -f /etc/dconf/db/distro.d/05-bluefin-searchlight-extensionand its comment. The line sat inside the existing first RUN, so no layer is added or removed.system_files/shared/usr/share/pipewire/pipewire-pulse.conf.d/50-bluefin-bt-switch.conf.contracts/bluefin-desktop.toml: require Common's50-bluefin-bt-switch.confand itspulse.cmd = [ ]line, so a Common regression fails the image build instead of bringing back PipeWire's "Invalid argument" on every login.tests/test_boot_noise.pynow checks that Utah ships no override and that the contract pins the line.desktop-contract.md, and aCOMMON_IMAGE_SHAnote incontainerfile.md.Why (verified against the pinned Common)
I pulled the only layer of
ghcr.io/projectbluefin/common@sha256:9faad517…(the Containerfile'sCOMMON_IMAGE_SHA):system_files/bluefin/etc/dconf/db/distro.d/contains01–04,06,07and08pluslocks/. There is no05-bluefin-searchlight-extension, so therm -fdid nothing.system_files/shared/usr/share/pipewire/pipewire-pulse.conf.d/50-bluefin-bt-switch.confalready haspulse.cmd = [ ](comment: "Keep an empty command list: PipeWire rejects comment-only drop-ins."). Utah's copy only existed to add that line.Version-skew decision (third checklist item): no change. Utah keeps tracking Common's latest digest through Renovate. Dakota builds Common at tag
v2026.11(07d6b3e). Pinning the tag would hold back Common fixes Utah relies on, like this one, until the next Common release, and every digest bump already passes the desktop contract. Recorded indocs/skills/containerfile.md.Stacked on #1281.
Closes #1267
Verification
just checkpasses (1330 tests).