Skip to content

chore(common): drop overrides Common no longer needs - #1283

Closed
hanthor wants to merge 1 commit into
feat/dakota-openscfrom
chore/common-stale-overrides
Closed

hanthor wants to merge 1 commit into
feat/dakota-openscfrom
chore/common-stale-overrides

Conversation

@hanthor

@hanthor hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member

What

  • Containerfile: drop rm -f /etc/dconf/db/distro.d/05-bluefin-searchlight-extension and its comment. The line sat inside the existing first RUN, so no layer is added or removed.
  • Delete system_files/shared/usr/share/pipewire/pipewire-pulse.conf.d/50-bluefin-bt-switch.conf.
  • contracts/bluefin-desktop.toml: require Common's 50-bluefin-bt-switch.conf and its pulse.cmd = [ ] line, so a Common regression fails the image build instead of bringing back PipeWire's "Invalid argument" on every login. tests/test_boot_noise.py now checks that Utah ships no override and that the contract pins the line.
  • Docs: the boot-noise bullet in desktop-contract.md, and a COMMON_IMAGE_SHA note in containerfile.md.

Why (verified against the pinned Common)

I pulled the only layer of ghcr.io/projectbluefin/common@sha256:9faad517… (the Containerfile's COMMON_IMAGE_SHA):

  • system_files/bluefin/etc/dconf/db/distro.d/ contains 01–04, 06, 07 and 08 plus locks/. There is no 05-bluefin-searchlight-extension, so the rm -f did nothing.
  • system_files/shared/usr/share/pipewire/pipewire-pulse.conf.d/50-bluefin-bt-switch.conf already has pulse.cmd = [ ] (comment: "Keep an empty command list: PipeWire rejects comment-only drop-ins."). Utah's copy only existed to add that line.

Version-skew decision (third checklist item): no change. Utah keeps tracking Common's latest digest through Renovate. Dakota builds Common at tag v2026.11 (07d6b3e). Pinning the tag would hold back Common fixes Utah relies on, like this one, until the next Common release, and every digest bump already passes the desktop contract. Recorded in docs/skills/containerfile.md.

Stacked on #1281.

Closes #1267

Verification

  • Listed and read the pinned Common layer as described above.
  • just check passes (1330 tests).

The Containerfile removed /etc/dconf/db/distro.d/05-bluefin-searchlight-
extension, which the pinned Common (sha256:9faad517) no longer ships, so the
rm and its comment were dead. Utah's copy of
pipewire-pulse.conf.d/50-bluefin-bt-switch.conf only added `pulse.cmd = [ ]`,
which Common's copy now carries itself; drop the override and pin Common's
line in the desktop contract so a Common regression fails the build.

Utah keeps tracking Common's latest digest through Renovate rather than
Dakota's release tag; the containerfile skill records why.

Closes #1267

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danathar, hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Withdrawn: this PR is not back in your court after all. The failing checks (contract) are red on the base branch too; this change did not break them. There is nothing to fix here: the PR is back on the normal path, and the hive checks it again once the base branch is green.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hivecommons-hive hivecommons-hive Bot linked an issue Nov 16, 2026 that may be closed by this pull request
3 tasks

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stand-in review (the hive's reviewers are out of quota). Approving. Checked against the actual pinned Common layer (sha256:9faad517…): distro.d/05-bluefin-searchlight-extension no longer exists (Common removed it in #1356), so the rm -f was a no-op. 50-bluefin-bt-switch.conf in Common is byte-identical to Utah's copy, including pulse.cmd = [ ]. The Containerfile copies Common's tree before Utah's, so deleting Utah's copy leaves Common's in place and the image unchanged. The new contract entries make a Common regression fail the build.

@hanthor

hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Folded into the part-2 landing PR (fold/dakota-sq) with this change unchanged apart from rebase and conflict resolution. Closing here; review continues there.

@hanthor hanthor closed this Nov 16, 2026
@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(common): drop stale overrides of projectbluefin/common files

2 participants