Repository navigation
feat: add more language input methods - #1274
hivecommons-hive[bot] merged 5 commits into
Conversation
|
Summary: The change is ready for automated checks. The checks will show whether the new typing options can be included safely. hive/awaiting-ci: CI pending — sweep will merge when green. — hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file |
|
Summary: The published package list now includes the added language input methods. This keeps the package information consistent with the image. hive/awaiting-ci: CI pending — sweep will merge when green. — hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra |
|
/ok-to-test |
|
Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file |
|
Fixed the reported contract failure in acee647: updated both documented Utah-addition counts to 262. The package data and documentation count checks pass locally; CI will verify the new head. |
|
/ok-to-test |
|
Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file |
Danathar
left a comment
There was a problem hiding this comment.
Stand-in review (the hive's reviewers are out of quota). Approving. It adds the input methods Dakota ships that the factory or Hummingbird already build (ibus-anthy, ibus-hangul, ibus-libpinyin, ibus-typing-booster, plus libhangul, libpinyin, m17n-db and m17n-lib). It keeps Bluefin's Mozc and Unikey, and the new test pins all ten in the install contract. Rime, anthy and fcitx5-gtk are correctly left for the factory imports (utah-packages#1019), and the PR uses Refs #1256, not Closes. The red contract was from an earlier commit: at 40b12d9, check-doc-counts.py passes ("61 Bluefin contract, 262 Utah additions, 7 genuinely unavailable"), and the running build will confirm the packages resolve.
|
/ok-to-test |
|
Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file |
|
hive-base-moved: merged current main at 1b3bb9b into this branch. |
There was a problem hiding this comment.
Looks correct to me. The red contract check is infrastructure, not this diff — it needs a re-run.
What I verified (at 5c63d15):
- The six packages land in
[parity]ofpackages/utah.toml(line 196 sits under[parity]), whichcontract()inscripts/install-packages.py:127adds to the install set.ibus-mozc/ibus-unikeystay inpackages/base.toml:67-68[fedora], so nothing existing is dropped. test_input_methods_remain_in_the_install_contractfails onmain'sutah.toml(all six missing) and passes with this change; theParityContractTestsgroup passes (4 tests).scripts/check-doc-counts.pypasses: 61 / 266 / 6, consistent with the README,package-contract.mdandsite/data/packages.json(321 → 327).Refs #1256is the right keyword: the body names what stays open (ibus-anthy, ibus-typing-booster, Rime, anthy, fcitx5-gtk) and why.
CI: contract (run 44251328611) failed in Checkout: Could not resolve host: codeberg.org while cloning the fuzzy-application-search@mkhl.codeberg.page submodule. It never reached the package check. A re-run is needed before merge: that job is the only thing that proves ibus-hangul, ibus-libpinyin, libhangul, libpinyin, m17n-db and m17n-lib resolve in the pinned repositories. I could not verify resolution locally. #1191 addresses this transient Codeberg failure class.
Minor: the PR carries no-dco. If this repository enforces sign-off, the commits need Signed-off-by before landing.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326
|
The latest |
|
@Karibhou the hive has adopted this PR ( |
|
The failing "contract" check cannot fetch a Codeberg submodule (DNS failure on the runner). It is failing across many open PRs, tracked in #1336; deferring until that closes. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-sonnet-5.5 copilot=1.0.88 |
The image adds available Korean and Chinese input methods and language libraries while keeping Bluefin’s Mozc and Unikey engines. A regression test covers the installed package set.
Refs #1256 — ibus-anthy and ibus-typing-booster are deferred because the pinned repositories lack kasumi-unicode and cldr-emoji-annotation, respectively. Rime, anthy and fcitx5-gtk also remain pending package factory import and publication.
Validation: package resolution unit tests, generated site data and documentation counts pass locally. CI must verify repository dependency resolution and the image build.
— hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra