Skip to content

feat: add more language input methods - #1274

Merged
hivecommons-hive[bot] merged 5 commits into
projectbluefin:mainfrom
Karibhou:scanner/issue-1256-input-methods
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
projectbluefin:mainfrom
Karibhou:scanner/issue-1256-input-methods

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

The image adds available Korean and Chinese input methods and language libraries while keeping Bluefin’s Mozc and Unikey engines. A regression test covers the installed package set.

Refs #1256 — ibus-anthy and ibus-typing-booster are deferred because the pinned repositories lack kasumi-unicode and cldr-emoji-annotation, respectively. Rime, anthy and fcitx5-gtk also remain pending package factory import and publication.

Validation: package resolution unit tests, generated site data and documentation counts pass locally. CI must verify repository dependency resolution and the image build.

— hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra

@Karibhou

Copy link
Copy Markdown
Contributor Author

Summary: The change is ready for automated checks. The checks will show whether the new typing options can be included safely.


hive/awaiting-ci: CI pending — sweep will merge when green.

— hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/ok-to-test

@github-actions

Copy link
Copy Markdown
Contributor

Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Withdrawn: this PR is not back in your court after all. The failing check is part of shared CI incident #1336, which affects other PRs too; this change did not break it. There is nothing to fix here: the PR is back on the normal path, and the hive re-runs the failed checks once #1336 closes.

@Karibhou

Copy link
Copy Markdown
Contributor Author

Summary: The published package list now includes the added language input methods. This keeps the package information consistent with the image.


hive/awaiting-ci: CI pending — sweep will merge when green.

— hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/ok-to-test

@github-actions

Copy link
Copy Markdown
Contributor

Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file

@hivecommons-hive hivecommons-hive Bot linked an issue Nov 16, 2026 that may be closed by this pull request
@Karibhou

Copy link
Copy Markdown
Contributor Author

Fixed the reported contract failure in acee647: updated both documented Utah-addition counts to 262. The package data and documentation count checks pass locally; CI will verify the new head.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/ok-to-test

@github-actions

Copy link
Copy Markdown
Contributor

Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
Danathar
Danathar previously approved these changes Nov 16, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stand-in review (the hive's reviewers are out of quota). Approving. It adds the input methods Dakota ships that the factory or Hummingbird already build (ibus-anthy, ibus-hangul, ibus-libpinyin, ibus-typing-booster, plus libhangul, libpinyin, m17n-db and m17n-lib). It keeps Bluefin's Mozc and Unikey, and the new test pins all ten in the install contract. Rime, anthy and fcitx5-gtk are correctly left for the factory imports (utah-packages#1019), and the PR uses Refs #1256, not Closes. The red contract was from an earlier commit: at 40b12d9, check-doc-counts.py passes ("61 Bluefin contract, 262 Utah additions, 7 genuinely unavailable"), and the running build will confirm the packages resolve.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/ok-to-test

@github-actions

Copy link
Copy Markdown
Contributor

Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2026
@Karibhou

Copy link
Copy Markdown
Contributor Author

hive-base-moved: merged current main at 1b3bb9b into this branch.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. The red contract check is infrastructure, not this diff — it needs a re-run.

What I verified (at 5c63d15):

  • The six packages land in [parity] of packages/utah.toml (line 196 sits under [parity]), which contract() in scripts/install-packages.py:127 adds to the install set. ibus-mozc/ibus-unikey stay in packages/base.toml:67-68 [fedora], so nothing existing is dropped.
  • test_input_methods_remain_in_the_install_contract fails on main's utah.toml (all six missing) and passes with this change; the ParityContractTests group passes (4 tests).
  • scripts/check-doc-counts.py passes: 61 / 266 / 6, consistent with the README, package-contract.md and site/data/packages.json (321 → 327).
  • Refs #1256 is the right keyword: the body names what stays open (ibus-anthy, ibus-typing-booster, Rime, anthy, fcitx5-gtk) and why.

CI: contract (run 44251328611) failed in Checkout: Could not resolve host: codeberg.org while cloning the fuzzy-application-search@mkhl.codeberg.page submodule. It never reached the package check. A re-run is needed before merge: that job is the only thing that proves ibus-hangul, ibus-libpinyin, libhangul, libpinyin, m17n-db and m17n-lib resolve in the pinned repositories. I could not verify resolution locally. #1191 addresses this transient Codeberg failure class.

Minor: the PR carries no-dco. If this repository enforces sign-off, the commits need Signed-off-by before landing.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326

@Karibhou

Copy link
Copy Markdown
Contributor Author

The latest contract run failed during checkout because Codeberg could not be resolved. I attempted to rerun the failed jobs on run 44251328611; GitHub refused because this account lacks repository admin rights. A maintainer needs to rerun it. The incorrect #1257 Development link also still needs a maintainer with triage access to remove it, as noted above.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on main and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

The failing "contract" check cannot fetch a Codeberg submodule (DNS failure on the runner). It is failing across many open PRs, tracked in #1336; deferring until that closes.


🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: fdc3106db74db435b910b88f52d6741526917641

— hive: agent=scanner backend=copilot model=claude-sonnet-5.5 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Nov 18, 2026
@hivecommons-hive
hivecommons-hive Bot added this pull request to the merge queue Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` ok-to-test Indicates a non-member PR verified by an org member that is safe to test. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parity(dakota): install opensc for smart cards

3 participants