Skip to content

test: replace Search Light checks with Compass launcher - #1076

Closed
castrojo wants to merge 8 commits into
mainfrom
feat/compass-launcher
Closed

castrojo wants to merge 8 commits into
mainfrom
feat/compass-launcher

Conversation

@castrojo

@castrojo castrojo commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

What

Replaces the Search Light checks with Compass launcher coverage (projectbluefin/common#1599).

  • tests/smoke/features/compass_launcher.feature (@smoke_suite @compass):
    • The flatpak is preinstalled: polls flatpak info --system org.tunaos.compass for up to 600 s, and skips when flatpak-preinstall.service is masked.
    • Super+Space toggles the launcher. compass.service is wanted by graphical-session.target. Stop leaves no engine and ping fails. Start and restart each leave exactly one serve --no-hotkey engine, with NRestarts=0. Then Super+Space shows the window and pressing it again hides it (window checked via Shell.Eval). Compass diagnostics are logged after the first key press and on any timeout.
  • common_dconf.feature: the Searchlight scenario is replaced by the Compass keybinding checks: path registered, <Super>space, command runs org.tunaos.compass toggle.
  • Search Light scenarios, the unit-test fixture UUID and skill-doc references are removed.

Verification

Ghost Lab dakota-qa-pipeline / run-container-tests (--tags=@compass) against a Dakota image built with common#1599 pinned: both Compass scenarios pass, and the common keybinding scenario passes. Other smoke/common failures match an unmodified dakota:testing baseline run on main.

Local: ruff, pytest (2461 passed), skill index in sync. audit-steps fails only on the bazzite suite, the same as on main.

Merge after common#1599 lands and dakota:testing picks it up automatically; earlier, the Compass scenarios fail against dakota:testing.

Assisted-by: Claude Opus 5.5 via GitHub Copilot

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 23.07692% with 70 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tests/smoke/features/steps/steps.py 22.22% 70 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

@castrojo this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 072-returned-to-contributor: conflicting

castrojo and others added 6 commits October 31, 2026 12:22
Assert the Compass Super+Space custom keybinding in common dconf, add a
pending check for the preinstalled org.tunaos.compass Flatpak, drop the
Search Light extension scenario, and refresh skill docs and coverage.

Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Wait for the FlatPark preinstall of org.tunaos.compass (skipped where
flatpak-preinstall.service is masked), press Super+Space via dogtail and
assert the Compass window appears, then hides on the second press.

Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assert compass.service is wanted by graphical-session.target, restart it
after the late preinstall, and require it active and answering
'flatpak run org.tunaos.compass ping' before the keybinding toggle checks.

Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Tag the Compass feature @Compass for targeted runs, log process, unit,
journal, session environment, doctor and logs output after the first
Super+Space, and append them plus a manual toggle to the window-state
timeout failure.

Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stop must kill the sandboxed engine (ping fails, no serve process);
start and restart must leave the unit active, answering ping, with
exactly one 'compass serve --no-hotkey' engine and NRestarts=0 after
restart, before the Super+Space toggle checks.

Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@castrojo

Copy link
Copy Markdown
Collaborator Author

/hold until common#1599 merges and dakota:testing picks up the Compass change

Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@castrojo
castrojo force-pushed the feat/compass-launcher branch from fefac5c to d9ecdcd Compare October 31, 2026 16:24
@castrojo

Copy link
Copy Markdown
Collaborator Author

/hold
Waiting for common#1599 to merge and dakota:testing to pick up Compass.

@castrojo
castrojo marked this pull request as draft October 31, 2026 16:26
@castrojo
castrojo marked this pull request as ready for review October 31, 2026 16:26
hivecommons-hive Bot added a commit that referenced this pull request Nov 1, 2026
Counting Utah as Bluefin-family makes common_dconf.feature run there,
including "Searchlight extension is configured", which Utah's newer
common pin no longer ships. Add a Utah-scoped @skip_utah gate (ported
from castrojo's fix/coverage-family-gates) so Bluefin keeps the
coverage while Utah gates stay green. Drop the tag when #1076 replaces
the scenario.

Hive-Fix-Attempt: 2/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Nov 1, 2026
…ed runs (#1083)

* fix(e2e): select Bluefin-family scenarios for Utah, common and composed runs

The common suite treated only image names containing "bluefin" or
"bazzite" as Bluefin-family, so Utah release gates and common's PR e2e
image skipped every @bluefin common scenario and reported green. The
smoke suite read only IMAGE, which composed runs replace with a
run-scoped testsuite ref, so smoke skipped @bluefin and @dakota_only
scenarios there.

Both suites now use one image-family helper that prefers BASE_IMAGE,
then IMAGE, then `-D image=`, and treats bluefin, bazzite, utah and
common image names as Bluefin-family. Dakota stays separate.

Co-authored-by: castrojo <castrojo@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* docs(e2e): state image_under_test precedence accurately

The smoke docstring claimed BASE_IMAGE then -D image=, but the shared
helper resolves BASE_IMAGE, then IMAGE, then -D image= (the order the
common suite has always used). Document the real precedence in both
places.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* fix(e2e): skip the Searchlight dconf scenario on Utah

Counting Utah as Bluefin-family makes common_dconf.feature run there,
including "Searchlight extension is configured", which Utah's newer
common pin no longer ships. Add a Utah-scoped @skip_utah gate (ported
from castrojo's fix/coverage-family-gates) so Bluefin keeps the
coverage while Utah gates stay green. Drop the tag when #1076 replaces
the scenario.

Hive-Fix-Attempt: 2/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: castrojo <castrojo@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@castrojo this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (4 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change swaps the old Search Light launcher checks for checks of the new Compass launcher: that it is preinstalled, that its background service behaves on stop/start/restart, and that Super+Space shows and hides its window. Since the last review the whole Super+Space scenario and its helper code are new; they read correctly and match what the description promises. One small gap: the new helper code has no unit tests, unlike the rest of this file.


Delta reviewed: fefac5c → d9ecdcd (rebase onto main pulled in #1074/#1075; only the eight PR-owned files were judged). No prior findings to re-check.

correctness (low, advisory)

  • tests/smoke/features/steps/steps.py:947-1059 adds ~165 lines of step logic (_compass_engine_ps argv parsing, stop/start/restart polling, NRestarts check) with no unit coverage, while every other helper in this file is covered in tests/unit/test_smoke_steps.py via patch.object(m, "_run_host", ...) (e.g. lines 125-160). The parsing in _compass_engine_ps (line.split()[3:], basename == compass, serve/--no-hotkey) is pure and cheap to pin down; a minimal test:
class TestCompassEnginePs:
    def test_counts_only_sandboxed_serve_engines(self):
        m = _import_smoke_steps()
        ps = "\n".join([
            "100 1 u /usr/bin/flatpak run org.tunaos.compass serve --no-hotkey",
            "101 100 u bwrap --args 40 compass serve --no-hotkey",
            "102 101 u /app/extra/compass/usr/bin/compass serve --no-hotkey",
            "103 1 u /app/extra/compass/usr/bin/compass ping",
        ])
        with patch.object(m, "_run_host", return_value=(ps, 0, "")):
            engines, listing = m._compass_engine_ps()
        assert len(engines) == 1 and engines[0].startswith("102")
        assert listing.count("\n") == 3

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@castrojo this PR has been waiting on you for a while (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

This is the last automatic reminder for this head. If you are unavailable the hive may adopt the PR to finish it (your commits are preserved).

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/stalled In its current stage longer than expected and removed stage/stalled In its current stage longer than expected labels Nov 5, 2026
@Danathar Danathar added the hold Prevent merge. Use `/hold` or `/hold cancel`. label Nov 5, 2026
@Danathar

Danathar commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Adding a real hold label: testsuite has no Prow, so the earlier /hold comments set nothing. This PR must wait for projectbluefin/common#1599 (Compass) to land, or the Compass scenarios fail against dakota:testing.

@hivecommons-hive hivecommons-hive Bot added stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/stalled In its current stage longer than expected stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/stalled In its current stage longer than expected stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 11, 2026
@hivecommons-hive hivecommons-hive Bot added stage/stalled In its current stage longer than expected stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/stalled In its current stage longer than expected stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 12, 2026
Danathar added a commit that referenced this pull request Nov 14, 2026
…p elsewhere

common#1599 reaches images at different times: utah takes common's image
digest, while dakota pins common as a BuildStream junction and needs its own
bump. Without a gate, the Compass scenarios would fail on every image built
before its pin moves.

- Smoke: the install step skips when /usr/share/flatpak/preinstall.d/
  compass.preinstall is absent. Where it ships, Compass must install, and the
  rest of each scenario runs.
- Common: a shared step `Skip unless the image ships "<path>"` gates the
  keybinding scenario on the same file.
- @skip_utah is removed: it gated only the Searchlight scenario this change
  replaces. Its hook, unit tests and docs go with it.

Refs #1076

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@Danathar

Copy link
Copy Markdown
Contributor

Closing as superseded by #1213, which carries this same change onto current main with signed commits (this branch has no Signed-off-by and conflicts with main). The hold condition here, projectbluefin/common#1599, can't be met anymore: #1599 was closed without merging on 11-14. #1213 says where Compass's preinstall is going now. Thanks @castrojo, the scenarios live on in #1213.

@Danathar Danathar closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login hold Prevent merge. Use `/hold` or `/hold cancel`. no-dco A commit is missing Signed-off-by — run `git rebase --signoff` stage/stalled In its current stage longer than expected stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants