Repository navigation
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@castrojo this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: conflicting |
Assert the Compass Super+Space custom keybinding in common dconf, add a pending check for the preinstalled org.tunaos.compass Flatpak, drop the Search Light extension scenario, and refresh skill docs and coverage. Assisted-by: Claude Opus 5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Wait for the FlatPark preinstall of org.tunaos.compass (skipped where flatpak-preinstall.service is masked), press Super+Space via dogtail and assert the Compass window appears, then hides on the second press. Assisted-by: Claude Opus 5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assert compass.service is wanted by graphical-session.target, restart it after the late preinstall, and require it active and answering 'flatpak run org.tunaos.compass ping' before the keybinding toggle checks. Assisted-by: Claude Opus 5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Tag the Compass feature @Compass for targeted runs, log process, unit, journal, session environment, doctor and logs output after the first Super+Space, and append them plus a manual toggle to the window-state timeout failure. Assisted-by: Claude Opus 5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stop must kill the sandboxed engine (ping fails, no serve process); start and restart must leave the unit active, answering ping, with exactly one 'compass serve --no-hotkey' engine and NRestarts=0 after restart, before the Super+Space toggle checks. Assisted-by: Claude Opus 5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: Claude Opus 5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/hold until common#1599 merges and dakota:testing picks up the Compass change |
Assisted-by: Claude Opus 5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fefac5c to
d9ecdcd
Compare
|
/hold |
Counting Utah as Bluefin-family makes common_dconf.feature run there, including "Searchlight extension is configured", which Utah's newer common pin no longer ships. Add a Utah-scoped @skip_utah gate (ported from castrojo's fix/coverage-family-gates) so Bluefin keeps the coverage while Utah gates stay green. Drop the tag when #1076 replaces the scenario. Hive-Fix-Attempt: 2/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…ed runs (#1083) * fix(e2e): select Bluefin-family scenarios for Utah, common and composed runs The common suite treated only image names containing "bluefin" or "bazzite" as Bluefin-family, so Utah release gates and common's PR e2e image skipped every @bluefin common scenario and reported green. The smoke suite read only IMAGE, which composed runs replace with a run-scoped testsuite ref, so smoke skipped @bluefin and @dakota_only scenarios there. Both suites now use one image-family helper that prefers BASE_IMAGE, then IMAGE, then `-D image=`, and treats bluefin, bazzite, utah and common image names as Bluefin-family. Dakota stays separate. Co-authored-by: castrojo <castrojo@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * docs(e2e): state image_under_test precedence accurately The smoke docstring claimed BASE_IMAGE then -D image=, but the shared helper resolves BASE_IMAGE, then IMAGE, then -D image= (the order the common suite has always used). Document the real precedence in both places. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * fix(e2e): skip the Searchlight dconf scenario on Utah Counting Utah as Bluefin-family makes common_dconf.feature run there, including "Searchlight extension is configured", which Utah's newer common pin no longer ships. Add a Utah-scoped @skip_utah gate (ported from castrojo's fix/coverage-family-gates) so Bluefin keeps the coverage while Utah gates stay green. Drop the tag when #1076 replaces the scenario. Hive-Fix-Attempt: 2/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: castrojo <castrojo@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@castrojo this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (4 waiting): fixes are handed out before new work as soon as you have capacity. |
There was a problem hiding this comment.
Summary: This change swaps the old Search Light launcher checks for checks of the new Compass launcher: that it is preinstalled, that its background service behaves on stop/start/restart, and that Super+Space shows and hides its window. Since the last review the whole Super+Space scenario and its helper code are new; they read correctly and match what the description promises. One small gap: the new helper code has no unit tests, unlike the rest of this file.
Delta reviewed: fefac5c → d9ecdcd (rebase onto main pulled in #1074/#1075; only the eight PR-owned files were judged). No prior findings to re-check.
correctness (low, advisory)
tests/smoke/features/steps/steps.py:947-1059adds ~165 lines of step logic (_compass_engine_psargv parsing, stop/start/restart polling,NRestartscheck) with no unit coverage, while every other helper in this file is covered intests/unit/test_smoke_steps.pyviapatch.object(m, "_run_host", ...)(e.g. lines 125-160). The parsing in_compass_engine_ps(line.split()[3:], basename ==compass,serve/--no-hotkey) is pure and cheap to pin down; a minimal test:
class TestCompassEnginePs:
def test_counts_only_sandboxed_serve_engines(self):
m = _import_smoke_steps()
ps = "\n".join([
"100 1 u /usr/bin/flatpak run org.tunaos.compass serve --no-hotkey",
"101 100 u bwrap --args 40 compass serve --no-hotkey",
"102 101 u /app/extra/compass/usr/bin/compass serve --no-hotkey",
"103 1 u /app/extra/compass/usr/bin/compass ping",
])
with patch.object(m, "_run_host", return_value=(ps, 0, "")):
engines, listing = m._compass_engine_ps()
assert len(engines) == 1 and engines[0].startswith("102")
assert listing.count("\n") == 3No findings from: security, intent-alignment, style, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@castrojo this PR has been waiting on you for a while ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. This is the last automatic reminder for this head. If you are unavailable the hive may adopt the PR to finish it (your commits are preserved). |
|
Adding a real |
…p elsewhere common#1599 reaches images at different times: utah takes common's image digest, while dakota pins common as a BuildStream junction and needs its own bump. Without a gate, the Compass scenarios would fail on every image built before its pin moves. - Smoke: the install step skips when /usr/share/flatpak/preinstall.d/ compass.preinstall is absent. Where it ships, Compass must install, and the rest of each scenario runs. - Common: a shared step `Skip unless the image ships "<path>"` gates the keybinding scenario on the same file. - @skip_utah is removed: it gated only the Searchlight scenario this change replaces. Its hook, unit tests and docs go with it. Refs #1076 Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
Closing as superseded by #1213, which carries this same change onto current main with signed commits (this branch has no |
What
Replaces the Search Light checks with Compass launcher coverage (projectbluefin/common#1599).
tests/smoke/features/compass_launcher.feature(@smoke_suite @compass):flatpak info --system org.tunaos.compassfor up to 600 s, and skips whenflatpak-preinstall.serviceis masked.compass.serviceis wanted bygraphical-session.target. Stop leaves no engine and ping fails. Start and restart each leave exactly oneserve --no-hotkeyengine, withNRestarts=0. Then Super+Space shows the window and pressing it again hides it (window checked via Shell.Eval). Compass diagnostics are logged after the first key press and on any timeout.common_dconf.feature: the Searchlight scenario is replaced by the Compass keybinding checks: path registered,<Super>space, command runsorg.tunaos.compass toggle.Verification
Ghost Lab
dakota-qa-pipeline/run-container-tests(--tags=@compass) against a Dakota image built with common#1599 pinned: both Compass scenarios pass, and the common keybinding scenario passes. Other smoke/common failures match an unmodifieddakota:testingbaseline run onmain.Local: ruff, pytest (2461 passed), skill index in sync.
audit-stepsfails only on thebazzitesuite, the same as onmain.Merge after common#1599 lands and
dakota:testingpicks it up automatically; earlier, the Compass scenarios fail againstdakota:testing.Assisted-by: Claude Opus 5.5 via GitHub Copilot