Skip to content

test: replace Search Light checks with Compass launcher - #1213

Closed
Danathar wants to merge 3 commits into
mainfrom
test/compass-launcher-signed
Closed

Danathar wants to merge 3 commits into
mainfrom
test/compass-launcher-signed

Conversation

@Danathar

@Danathar Danathar commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary: Replaces the Search Light checks with Compass launcher checks. This is castrojo's #1076, carried onto current main as signed commits. #1076's commits have no Signed-off-by, and its branch conflicts with main. The Compass scenarios run wherever the image ships Compass (projectbluefin/common#1599) and skip elsewhere, so this can merge once one image proves them. Draft until utah's first testing image with common#1599 runs them.

What it tests

  • tests/smoke/features/compass_launcher.feature (@smoke_suite @compass):
    • the Compass flatpak (org.tunaos.compass) is preinstalled;
    • compass.service runs exactly one engine across stop, start and restart;
    • Super+Space shows the launcher, and pressing it again hides it.
  • common_dconf.feature: the Searchlight keybinding scenario becomes the Compass one (<Super>space runs org.tunaos.compass toggle).
  • Search Light scenarios, the unit-test fixture UUID and the skill-doc references are removed.

Changes from #1076

  • Gated on the image shipping Compass. utah takes common by image digest, while dakota pins common as a BuildStream junction and needs its own bump, so images get Compass at different times.
    • The smoke install step skips when /usr/share/flatpak/preinstall.d/compass.preinstall is absent. Where the file ships, Compass must install.
    • The common keybinding scenario uses a new shared step, Skip unless the image ships "<path>", on the same file.
  • @skip_utah removed. It only gated the Searchlight scenario this replaces; its hook, unit tests and docs are gone.
  • Rebased onto current main. The only conflict was the generated coverage snapshot in suite-map/SKILL.md, regenerated with scripts/update_coverage_snapshot.py.
  • One signed commit. The test content is test: replace Search Light checks with Compass launcher #1076's as written.

Checks so far

  • ruff clean; docs validate; skill index and coverage snapshot in sync.
  • Unit tests for the gate in both suites. test_smoke_steps, test_common_steps, test_offline_boot_steps, test_gnome_extensions_steps and the new test_ssh_skip_unless_ships: all pass.
  • test: replace Search Light checks with Compass launcher #1076's own proof was a Dakota image built with common#1599 pinned, where both Compass scenarios and the keybinding scenario passed.

Before this leaves draft

Run manual.yml (suites=smoke,common) against the first image that actually installs Compass (org.tunaos.compass): the Compass scenarios must pass there, and they must skip on the current dakota:testing.

(Updated 11-16. The original gate, a utah:testing built with common#1599, can't happen: common#1599 was closed without merging on 11-14. Common has shipped Compass since common#1356 (10-30), but through a Homebrew preinstall, and the E2E images have no Homebrew, so no tested image installs it yet. castrojo said the preinstall moves to chairlift.)

Supersedes #1076.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn

Carries #1076 (castrojo's work, unchanged in substance) onto current main as
one signed commit: #1076's commits lack Signed-off-by, and its branch
conflicts with main in the generated suite map, which is regenerated here.

- compass_launcher.feature (@smoke_suite @Compass): the Compass flatpak is
  preinstalled; compass.service owns exactly one engine across stop, start
  and restart; Super+Space shows and hides the launcher.
- common_dconf.feature: the Searchlight keybinding scenario becomes the
  Compass one (<Super>space runs org.tunaos.compass toggle).
- Search Light scenarios, the unit-test fixture UUID and skill references go.

Needs projectbluefin/common#1599 in the tested image; until then the Compass
scenarios fail.

Refs #1076

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added the author/clanker A contributor's own hive authored this PR under their login label Nov 14, 2026
@codecov-commenter

codecov-commenter commented Nov 14, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 57.71812% with 63 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tests/smoke/features/steps/steps.py 33.68% 63 Missing ⚠️

📢 Thoughts on this report? Let us know!

…p elsewhere

common#1599 reaches images at different times: utah takes common's image
digest, while dakota pins common as a BuildStream junction and needs its own
bump. Without a gate, the Compass scenarios would fail on every image built
before its pin moves.

- Smoke: the install step skips when /usr/share/flatpak/preinstall.d/
  compass.preinstall is absent. Where it ships, Compass must install, and the
  rest of each scenario runs.
- Common: a shared step `Skip unless the image ships "<path>"` gates the
  keybinding scenario on the same file.
- @skip_utah is removed: it gated only the Searchlight scenario this change
  replaces. Its hook, unit tests and docs go with it.

Refs #1076

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Regenerate the suite-map coverage snapshot rather than pick a side:
this branch adds the Compass feature file, and main lifted the dakota
quarantines (#1216).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@Danathar

Copy link
Copy Markdown
Contributor Author

hive-base-moved: merged main at 261ca3b into this branch to clear the conflict. Regenerated the suite-map coverage snapshot; snapshot and skill-index checks pass.


🐝 Hive Agent: contributor | SHA: 6353ce67

@Danathar

Copy link
Copy Markdown
Contributor Author

Note for whoever picks this up: the gate in the body, projectbluefin/common#1599 (preinstall Compass), was closed without merging on 11-14, and castrojo said it would be done in chairlift instead. So "draft until utah's first testing image with common#1599" can't happen as written. The gate should become whichever image first ships org.tunaos.compass by the new route.

@Danathar

Copy link
Copy Markdown
Contributor Author

Closing (Doug's call). The gate this draft waited for will not be met: projectbluefin/common#1599 was closed unmerged on 2026-11-14 ("Going to do this in chairlift"), common ships no compass.preinstall (Compass comes through Homebrew, homebrew/preinstall.d/compass.Brewfile), and projectbluefin/chairlift#773 binds Super+Space on demand instead. The @compass scenarios here key on compass.preinstall, so they would skip on every image.

@Danathar Danathar closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants