Repository navigation
Conversation
Carries #1076 (castrojo's work, unchanged in substance) onto current main as one signed commit: #1076's commits lack Signed-off-by, and its branch conflicts with main in the generated suite map, which is regenerated here. - compass_launcher.feature (@smoke_suite @Compass): the Compass flatpak is preinstalled; compass.service owns exactly one engine across stop, start and restart; Super+Space shows and hides the launcher. - common_dconf.feature: the Searchlight keybinding scenario becomes the Compass one (<Super>space runs org.tunaos.compass toggle). - Search Light scenarios, the unit-test fixture UUID and skill references go. Needs projectbluefin/common#1599 in the tested image; until then the Compass scenarios fail. Refs #1076 Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…p elsewhere common#1599 reaches images at different times: utah takes common's image digest, while dakota pins common as a BuildStream junction and needs its own bump. Without a gate, the Compass scenarios would fail on every image built before its pin moves. - Smoke: the install step skips when /usr/share/flatpak/preinstall.d/ compass.preinstall is absent. Where it ships, Compass must install, and the rest of each scenario runs. - Common: a shared step `Skip unless the image ships "<path>"` gates the keybinding scenario on the same file. - @skip_utah is removed: it gated only the Searchlight scenario this change replaces. Its hook, unit tests and docs go with it. Refs #1076 Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Regenerate the suite-map coverage snapshot rather than pick a side: this branch adds the Compass feature file, and main lifted the dakota quarantines (#1216). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
hive-base-moved: merged 🐝 Hive Agent: |
|
Note for whoever picks this up: the gate in the body, projectbluefin/common#1599 (preinstall Compass), was closed without merging on 11-14, and castrojo said it would be done in chairlift instead. So "draft until utah's first |
|
Closing (Doug's call). The gate this draft waited for will not be met: projectbluefin/common#1599 was closed unmerged on 2026-11-14 ("Going to do this in chairlift"), common ships no |
Summary: Replaces the Search Light checks with Compass launcher checks. This is castrojo's #1076, carried onto current main as signed commits. #1076's commits have no
Signed-off-by, and its branch conflicts with main. The Compass scenarios run wherever the image ships Compass (projectbluefin/common#1599) and skip elsewhere, so this can merge once one image proves them. Draft until utah's firsttestingimage with common#1599 runs them.What it tests
tests/smoke/features/compass_launcher.feature(@smoke_suite @compass):org.tunaos.compass) is preinstalled;compass.serviceruns exactly one engine across stop, start and restart;common_dconf.feature: the Searchlight keybinding scenario becomes the Compass one (<Super>spacerunsorg.tunaos.compass toggle).Changes from #1076
/usr/share/flatpak/preinstall.d/compass.preinstallis absent. Where the file ships, Compass must install.Skip unless the image ships "<path>", on the same file.@skip_utahremoved. It only gated the Searchlight scenario this replaces; its hook, unit tests and docs are gone.suite-map/SKILL.md, regenerated withscripts/update_coverage_snapshot.py.Checks so far
test_smoke_steps,test_common_steps,test_offline_boot_steps,test_gnome_extensions_stepsand the newtest_ssh_skip_unless_ships: all pass.Before this leaves draft
Run
manual.yml(suites=smoke,common) against the first image that actually installs Compass (org.tunaos.compass): the Compass scenarios must pass there, and they must skip on the currentdakota:testing.(Updated 11-16. The original gate, a
utah:testingbuilt with common#1599, can't happen: common#1599 was closed without merging on 11-14. Common has shipped Compass since common#1356 (10-30), but through a Homebrew preinstall, and the E2E images have no Homebrew, so no tested image installs it yet. castrojo said the preinstall moves to chairlift.)Supersedes #1076.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn