Skip to content

fix(e2e): select Bluefin-family scenarios for Utah, common and composed runs - #1083

Merged
hivecommons-hive[bot] merged 3 commits into
mainfrom
scanner/fix-1073
Nov 1, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
mainfrom
scanner/fix-1073

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Summary: Common and smoke now choose @bluefin/@dakota_only scenarios from one shared image-family helper. The helper reads BASE_IMAGE before IMAGE and counts Utah and common as Bluefin-family.


Before this change, Utah release gates and common's PR e2e image skipped every @bluefin common scenario and still reported green. Smoke only read IMAGE, which composed runs replace with a run-scoped testsuite ref, so it skipped family-tagged scenarios there. #1075 fixed only the software suite.

  • New tests/shared/image_family.py, adapted from castrojo's fix/coverage-family-gates branch. Common and smoke environment.py both use it.
  • Unit tests cover family names, the org-name false positive, and source precedence.
  • Updated docs: the cross-image skipping reference and the suite-map tag table.

Caveat: Utah now runs @bluefin common scenarios. castrojo's run needed @skip_utah on the Searchlight dconf scenario, but #1076 replaces that scenario, so this PR leaves it alone to avoid a conflict.

Refs #1073 — the workflow half still needs an owner push: passing BASE_IMAGE/-D image into the GUI runner, the common pass gate, and not splitting common on Dakota. The diff is posted on the issue. Smoke detection does nothing in CI until that lands.

— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 requested_by=@castrojo

…ed runs

The common suite treated only image names containing "bluefin" or
"bazzite" as Bluefin-family, so Utah release gates and common's PR e2e
image skipped every @bluefin common scenario and reported green. The
smoke suite read only IMAGE, which composed runs replace with a
run-scoped testsuite ref, so smoke skipped @bluefin and @dakota_only
scenarios there.

Both suites now use one image-family helper that prefers BASE_IMAGE,
then IMAGE, then `-D image=`, and treats bluefin, bazzite, utah and
common image names as Bluefin-family. Dakota stays separate.

Co-authored-by: castrojo <castrojo@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: a05d26a14c1e57194574789b7a970fca3b45a5c0

— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 1, 2026
@codecov-commenter

codecov-commenter commented Nov 1, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 98.98990% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tests/smoke/features/environment.py 90.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change makes the test harness recognise Utah and common-layer images as members of the Bluefin family, so Bluefin-specific checks run on them instead of being silently skipped. The logic is sound, but one of those newly-enabled checks is already known to fail on Utah, so merging this before the replacement for that check lands would turn the Utah release gate red. A smaller note: one of the documented fallback paths for naming the image under test can never trigger in CI.

What I need from you: Land #1076 first (or rebase on it), then merge this.


correctness

  • medium — Utah release gates will now execute the known-failing Searchlight scenario. tests/shared/image_family.py:4 adds utah to the family, and the common job already receives BASE_IMAGE (.github/workflows/e2e.yml:214), so tests/common/features/common_dconf.feature:87 ("Searchlight extension is configured", under feature-level @bluefin) runs on Utah the moment this merges. The PR body says castrojo's run needed @skip_utah on exactly that scenario and that #1076 replaces it; #1076 is still open and tests/common/features/environment.py:190-215 has no @skip_utah handling. Requested: sequence this after #1076 (rebase once merged) so the gate goes from false-green to green rather than to red.
  • low — -D image= fallback is unreachable in CI, and the docstring says otherwise. tests/shared/image_family.py:14-18 orders BASE_IMAGE > IMAGE > userdata, but the GUI runner always sets -e IMAGE (.github/workflows/e2e.yml:1483), so userdata["image"] is never consulted there; tests/smoke/features/environment.py:321-322 ("BASE_IMAGE and then -D image=") describes a different order. The software suite (tests/software/features/environment.py:65-70) and docs/skills/test-authoring/behave/SKILL.md:252 use BASE_IMAGE > -D image= > IMAGE. Suggest matching that order in the helper (and updating test_image_then_userdata_are_fallbacks), or correcting the docstring if IMAGE-before-userdata is intended.

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

The smoke docstring claimed BASE_IMAGE then -D image=, but the shared
helper resolves BASE_IMAGE, then IMAGE, then -D image= (the order the
common suite has always used). Document the real precedence in both
places.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 1, 2026
Counting Utah as Bluefin-family makes common_dconf.feature run there,
including "Searchlight extension is configured", which Utah's newer
common pin no longer ships. Add a Utah-scoped @skip_utah gate (ported
from castrojo's fix/coverage-family-gates) so Bluefin keeps the
coverage while Utah gates stay green. Drop the tag when #1076 replaces
the scenario.

Hive-Fix-Attempt: 2/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: Re-review of the latest revision. The only change since last time is clearer wording in two code comments, which resolves the earlier note about the helper describing a different lookup order than it uses. The remaining concern stands: once this merges, Utah release gates start running a check that is already known to fail on Utah, so those gates would go red until the follow-up that replaces that check lands.

What I need from you: Either quarantine the Searchlight dconf scenario for Utah in this PR, or land #1076 first.


correctness

  • Still present: tests/common/features/common_dconf.feature:1 tags the whole feature @bluefin, so tests/shared/image_family.py:4 adding "utah" to _BLUEFIN_FAMILY_NAMES makes tests/common/features/environment.py:200-201 stop skipping it on Utah. The scenario at common_dconf.feature:87 ("Searchlight extension is configured") is the one the PR body says needed @skip_utah in castrojo's run. environment.py:195 already honours skip_quarantine, so a quarantine entry for that scenario (removed when #1076 merges) avoids the conflict the PR body is worried about. PR #1076 is still open at this head.
  • Fixed: tests/shared/image_family.py:15-17 and tests/smoke/features/environment.py:320-324 now state the actual BASE_IMAGE → IMAGE → -D image= precedence and that -D image= is only reachable without IMAGE set.

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 1, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit e06a534 into main Nov 1, 2026
6 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#108384909de` sha256:548c9464894d162ada46ebbb808a695d4ff5d9aa403b65b87e4f4c9b89f22395 — download from the dashboard or `hivectl review evidence #1083`.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant