Repository navigation
fix(ci): pin just tool version in CI workflows - #190
2 commits merged into
Conversation
taiki-e/install-action resolves just@latest at run time when no version is supplied, so the build tool that drives every job (just validate, just test-unit, DDI/kernel export recipes) was unpinned while every GitHub Action in the repo is SHA-pinned. Pin just to 1.58.0, the version CI already installs, so this changes no runtime behavior. Signed-off-by: hive-agent <hive-agent@users.noreply.github.com>
There was a problem hiding this comment.
docs-currency
docs/skills/ci-tooling.md:43-48— the "Installingjust" section documents the canonical snippet as unpinnedtool: just. This PR changes the repo convention at all four call sites totool: just@1.58.0but leaves the skill doc showing the old pattern, so the next workflow copied from the doc reintroduces exactly what #188 removed. Update the snippet totool: just@1.58.0(or note that a version pin is required).
No findings from: security, intent-alignment, style. Diff covers all four sites named in #188 (build.yml:42/80, kernel.yml:42, unit-tests.yml:44) with no scope creep; reviewed at a13e40a.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
The skill doc's install snippet still showed an unpinned 'tool: just', which is the form issue projectbluefin#188 removed from the workflows. A workflow copied from the doc would have reintroduced it, undoing this PR on the next new job. Update the snippet to 'tool: just@1.58.0', matching all four call sites, and explain that without a version install-action resolves just@latest at run time. Note that the version is repeated per call site so a bump has to change all of them in one commit. Add the half-done pin to Red Flags, add a checklist item for it under Verification, and record the 'tool: just always installs a working version' rationalization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Reviewed and approved for merge — blocked only on an OAuth token scope, not on content.
The maintainer token currently carries Merge order matters here, because these four collide in
After that sequence the merged tree passes: A direct push of that merge is refused by the |
c3bd1fe
|
Landed via #217, which is why this shows as closed rather than merged — the content changed in the conflict resolution so GitHub could not match the commits. Your change was correct and is in Resolved by keeping the deletion and applying your intent to the file you could not have known about — Thanks — and apologies for the round trip. |
Problem
Every GitHub Action in this repository is pinned to a full commit SHA, but the one build tool that drives every job —
just— was installed unpinned. With no version specifier,taiki-e/install-actionresolvesjust@latestat run time, so the CI contract (just validate,just test-unit, the DDI/kernel export recipes) executes ajustbinary whose version is decided by an upstream release rather than by a commit in this repo.Fixed in four call sites across three workflows:
.github/workflows/build.yml(lines 42 and 80).github/workflows/kernel.yml(line 42).github/workflows/unit-tests.yml(line 44)Fix
Pin the tool to the version CI already resolves today:
This changes no runtime behavior — run 35379640734 shows CI installing
just 1.58.0.Closes #188.
— hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K
🐝 Hive Agent:
contributor| SHA:a13e40a