Skip to content

fix(ci): pin just tool version in CI workflows - #190

Merged
2 commits merged into
projectbluefin:mainfrom
kylerankin:fix/just-tool-version
Sep 20, 2026
Merged

2 commits merged into
projectbluefin:mainfrom
kylerankin:fix/just-tool-version

Conversation

@kylerankin

Copy link
Copy Markdown
Contributor

Problem

Every GitHub Action in this repository is pinned to a full commit SHA, but the one build tool that drives every job — just — was installed unpinned. With no version specifier, taiki-e/install-action resolves just@latest at run time, so the CI contract (just validate, just test-unit, the DDI/kernel export recipes) executes a just binary whose version is decided by an upstream release rather than by a commit in this repo.

Fixed in four call sites across three workflows:

  • .github/workflows/build.yml (lines 42 and 80)
  • .github/workflows/kernel.yml (line 42)
  • .github/workflows/unit-tests.yml (line 44)

Fix

Pin the tool to the version CI already resolves today:

with:
  tool: just@1.58.0

This changes no runtime behavior — run 35379640734 shows CI installing just 1.58.0.

Closes #188.

— hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K


🐝 Hive Agent: contributor | SHA: a13e40a

taiki-e/install-action resolves just@latest at run time when no version
is supplied, so the build tool that drives every job (just validate,
just test-unit, DDI/kernel export recipes) was unpinned while every
GitHub Action in the repo is SHA-pinned. Pin just to 1.58.0, the
version CI already installs, so this changes no runtime behavior.

Signed-off-by: hive-agent <hive-agent@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency

  • docs/skills/ci-tooling.md:43-48 — the "Installing just" section documents the canonical snippet as unpinned tool: just. This PR changes the repo convention at all four call sites to tool: just@1.58.0 but leaves the skill doc showing the old pattern, so the next workflow copied from the doc reintroduces exactly what #188 removed. Update the snippet to tool: just@1.58.0 (or note that a version pin is required).

No findings from: security, intent-alignment, style. Diff covers all four sites named in #188 (build.yml:42/80, kernel.yml:42, unit-tests.yml:44) with no scope creep; reviewed at a13e40a.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78

The skill doc's install snippet still showed an unpinned 'tool: just', which is
the form issue projectbluefin#188 removed from the workflows. A workflow copied from the doc
would have reintroduced it, undoing this PR on the next new job.

Update the snippet to 'tool: just@1.58.0', matching all four call sites, and
explain that without a version install-action resolves just@latest at run time.
Note that the version is repeated per call site so a bump has to change all of
them in one commit.

Add the half-done pin to Red Flags, add a checklist item for it under
Verification, and record the 'tool: just always installs a working version'
rationalization.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78

@castrojo castrojo added the blocked Waiting on something outside this repository. Use `/label blocked` or `/remove-label blocked`. label Sep 20, 2026
@castrojo

Copy link
Copy Markdown
Contributor

Reviewed and approved for merge — blocked only on an OAuth token scope, not on content.

gh pr merge refuses this PR with:

refusing to allow an OAuth App to create or update workflow .github/workflows/... without workflow scope

The maintainer token currently carries admin:public_key, gist, read:org, repo. One command unblocks it:

gh auth refresh -s workflow

Merge order matters here, because these four collide in build.yml and unit-tests.yml. Verified locally by merging all four in sequence into a scratch main:

  1. fix(ci): move junction ref tracking out of the pull_request path #180 — biggest restructure; deletes the track-refs job and adds track-junctions.yml.
  2. fix(ci): pin just tool version in CI workflows #190 — conflicts with fix(ci): move junction ref tracking out of the pull_request path #180 on the deleted track-refs job. Resolution: keep the deletion, and pin tool: just@1.58.0 in the new track-junctions.yml as well, which fix(ci): pin just tool version in CI workflows #190 could not know about.
  3. ci: expand unit-tests workflow paths trigger #189 — clean.
  4. fix(renovate): match the freedesktop-sdk series the junction actually tracks #84 — clean.

After that sequence the merged tree passes: actionlint clean, pytest tests/unit 284 passed / 1 xfailed, bats tests/unit 91 passed, docs-checks.py, check-release-version.py, check-renovate-series.py, and just validate. All four taiki-e/install-action call sites end up pinned.

A direct push of that merge is refused by the main ruleset (pull_request required), which is correct — so these have to go through the API with the right scope.

@castrojo

Copy link
Copy Markdown
Contributor

Landed via #217, which is why this shows as closed rather than merged — the content changed in the conflict resolution so GitHub could not match the commits.

Your change was correct and is in main now. It just predated #180, which deleted the track-refs job from build.yml and replaced it with the scheduled track-junctions.yml; the pin you added lived inside the job that no longer exists.

Resolved by keeping the deletion and applying your intent to the file you could not have known about — track-junctions.yml was installing just unpinned, so it had reintroduced exactly the gap #188 describes. All four call sites are pinned now:

track-junctions.yml:58   tool: just@1.58.0
build.yml:39             tool: just@1.58.0
kernel.yml:42            tool: just@1.58.0
unit-tests.yml:58        tool: just@1.58.0

Thanks — and apologies for the round trip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Waiting on something outside this repository. Use `/label blocked` or `/remove-label blocked`.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci-maintainer] just is installed unpinned (just@latest) in build.yml, kernel.yml and unit-tests.yml while every action is SHA-pinned

2 participants