Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Set up just
uses: taiki-e/install-action@7b8d4719ee4aaa279bdf55df38dacb9ebfe12a6c # v2
with:
tool: just
tool: just@1.58.0

- name: Track and Resolve BuildStream Refs
env:
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
- name: Set up just
uses: taiki-e/install-action@7b8d4719ee4aaa279bdf55df38dacb9ebfe12a6c # v2
with:
tool: just
tool: just@1.58.0

- name: Validate Element Graph
run: just validate
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kernel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Set up just
uses: taiki-e/install-action@7b8d4719ee4aaa279bdf55df38dacb9ebfe12a6c # v2
with:
tool: just
tool: just@1.58.0

- name: Validate Element Graph
run: just validate
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Set up just
uses: taiki-e/install-action@7b8d4719ee4aaa279bdf55df38dacb9ebfe12a6c # v2
with:
tool: just
tool: just@1.58.0

- name: Run unit tests
run: just test-unit
15 changes: 14 additions & 1 deletion docs/skills/ci-tooling.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,21 @@ before adding an action.

### Installing `just` — taiki-e/install-action, not snap/cargo/apt

Pin the tool version too, not only the action SHA. Without `@<version>`,
`install-action` resolves `just@latest` at run time, so the CI contract
(`just validate`, `just test-unit`, the DDI/kernel export recipes) runs against
a binary chosen by an upstream release rather than by a commit in this repo.

```yaml
- uses: taiki-e/install-action@b6b84cf49ebfe0176417bdce007c624f0db37f20 # v2
with:
tool: just
tool: just@1.58.0
```

The version is repeated at each call site — currently `build.yml` (two jobs),
`kernel.yml` and `unit-tests.yml`. Bumping `just` means changing all of them in
one commit, so CI never runs two versions at once.

### Workflow permissions

`.github/workflows/build.yml` defaults to a read-only token:
Expand Down Expand Up @@ -130,17 +139,21 @@ uploaded to a GitHub Release tagged `installer-v<FSDK-RELEASE>`.
|---|---|
| "It's just a minor version tag, supply-chain risk is low." | One compromised tag push owns every repo using it. Pin to SHA. |
| "I'll check what SHA other repos use later." | Check now — it's one `gh api` call and takes a few seconds. |
| "`tool: just` always installs a working version." | It installs whatever is latest that day. A `just` release can change recipe parsing or `--fmt` output and break CI with no commit in this repo. |

## Red Flags

- Any `uses:` line with a mutable ref (`@v2`, `@main`, `@latest`).
- An `install-action` step whose `tool:` has no `@<version>` — the pin is half
done, since the action is fixed but the binary it installs is not.
- `sudo podman` in one step and plain `podman` in another step doing the same
operation.
- A new action not present in any sibling repo — check upstream first.

## Verification

- [ ] Every `uses:` line has a full 40-character SHA and a `# vX` comment.
- [ ] Every `install-action` `tool:` names an explicit version (`just@1.58.0`).
- [ ] `just validate` passes after workflow changes.
- [ ] No new mutable action refs introduced.
- [ ] The release signing step uploads detached `.gpg` signatures for every
Expand Down
Loading