Skip to content

ci: expand unit-tests workflow paths trigger - #189

Merged
1 commit merged into
projectbluefin:mainfrom
mrbobbytables:ci/unit-tests-paths-filter
Sep 20, 2026
Merged

1 commit merged into
projectbluefin:mainfrom
mrbobbytables:ci/unit-tests-paths-filter

Conversation

@mrbobbytables

Copy link
Copy Markdown
Contributor

Why

.github/workflows/unit-tests.yml (Unit tests) previously fired only on changes to .github/scripts/**, .github/workflows/unit-tests.yml, files/**, tests/unit/**, and Justfile.

However, the unit test suite (just test-unit running pytest and bats) directly inspects and asserts on inputs in:

  • elements/** (e.g. elements/freedesktop-sdk.bst read by test_repart_layout.py, test_build_depends.py, test_installer_contract.py, test_sysupdate_transfers.py)
  • include/** (include/k0s.yml read by test_k0s_version.py)
  • .pre-commit-config.yaml (read by test_k0s_version.py)
  • .github/workflows/build.yml (read by test_sysupdate_transfers.py)
  • project.conf (release version invariant)

Without these in the paths: trigger lists for pull_request and push, PRs modifying these files (such as automated Renovate junction ref updates) skip the Unit tests workflow entirely.

What changed

Added the missing tracked inputs to both pull_request.paths and push.paths in .github/workflows/unit-tests.yml:

  • .github/workflows/build.yml
  • .pre-commit-config.yaml
  • elements/**
  • include/**
  • project.conf

Verification

  • just test-unit passes (207 passed, 1 xfailed in pytest; 62 passed/skipped in bats).
  • actionlint .github/workflows/*.yml passes.
  • Verified all added paths appear twice (under pull_request and push).
  • .github/scripts/docs-checks.py, check-release-version.py, and check-k0s-version.py pass.

Closes #187

— hive: backend=copilot model=gemini-3.8-flash

🐝 Hive Agent: contributor | SHA: 45ca29e

Trigger unit tests on changes to elements/**, include/**,
project.conf, .pre-commit-config.yaml, and .github/workflows/build.yml,
which are read and asserted by the unit test suite.

Fixes projectbluefin#187

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
@castrojo castrojo added the blocked Waiting on something outside this repository. Use `/label blocked` or `/remove-label blocked`. label Sep 20, 2026
@castrojo

Copy link
Copy Markdown
Contributor

Reviewed and approved for merge — blocked only on an OAuth token scope, not on content.

gh pr merge refuses this PR with:

refusing to allow an OAuth App to create or update workflow .github/workflows/... without workflow scope

The maintainer token currently carries admin:public_key, gist, read:org, repo. One command unblocks it:

gh auth refresh -s workflow

Merge order matters here, because these four collide in build.yml and unit-tests.yml. Verified locally by merging all four in sequence into a scratch main:

  1. fix(ci): move junction ref tracking out of the pull_request path #180 — biggest restructure; deletes the track-refs job and adds track-junctions.yml.
  2. fix(ci): pin just tool version in CI workflows #190 — conflicts with fix(ci): move junction ref tracking out of the pull_request path #180 on the deleted track-refs job. Resolution: keep the deletion, and pin tool: just@1.58.0 in the new track-junctions.yml as well, which fix(ci): pin just tool version in CI workflows #190 could not know about.
  3. ci: expand unit-tests workflow paths trigger #189 — clean.
  4. fix(renovate): match the freedesktop-sdk series the junction actually tracks #84 — clean.

After that sequence the merged tree passes: actionlint clean, pytest tests/unit 284 passed / 1 xfailed, bats tests/unit 91 passed, docs-checks.py, check-release-version.py, check-renovate-series.py, and just validate. All four taiki-e/install-action call sites end up pinned.

A direct push of that merge is refused by the main ruleset (pull_request required), which is correct — so these have to go through the API with the right scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Waiting on something outside this repository. Use `/label blocked` or `/remove-label blocked`.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci-maintainer] Unit tests never fire on elements/, include/, project.conf or build.yml — .github/workflows/unit-tests.yml paths filter

2 participants