Repository navigation
Load short expression CSV and TSV tables consistently - #487
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid expression CSV tables with a header and one patient measurement were parsed as TSV because delimiter inference required three lines. Infer from the available informative lines instead; skip comments and blank lines, and retain an explicit error for files without any header/data lines. Header-only tables work with declared value columns; inferred numeric columns still require measurements.
Both file and CLI-spec loaders run the same CSV/TSV battery with zero, one and multiple rows. A composed regression loads one expression feature, joins it to predictions, changes selection with abundance, and saves/replays the selection decision. Bumps Topiary 5.94.2 to 5.94.3.
Fixes #486. Unblocks openvax/vaxrank#585 without a consumer-specific delimiter workaround.
Validation:
./lint.shpassed; 17 focused regressions passed; the complete./test.shpassed 5,469 tests with 20 optional skips in 709.91 seconds. All exact-head GitHub CI checks passed, including Python/pandas matrices and Isovar/PirlyGenes integration. Local HTTP retry tests required localhost networking outside the sandbox.The full gate also exposed high-depth RNA support-processing cost in an existing mitochondrial fixture; recorded separately at openvax/isovar#463. No Isovar behavior, read limits or consumer workaround changed in this PR.