Repository navigation
Admit patient CTA expression with source provenance and configurable MAGE exclusions - #585
Merged
Merged
Conversation
This was referenced Oct 7, 2026
iskandr
marked this pull request as ready for review
October 7, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patient CTA design currently requires callers to assemble antigens themselves. This starts the expression-first workflow in #584 with an adapter that intersects declared patient gene/transcript expression with direct OncoRef CTA admission and returns auditable
VaccineAntigensources, without VCF/BAM.The adapter uses Topiary's expression loader, retains original feature IDs and input SHA-256, and records missing values, non-CTA features, excluded targets, unresolved transcripts and held-out admission decisions. Gene measurements select the OncoRef canonical reference transcript without assigning abundance to that isoform; transcript measurements select only the measured isoform and reject version mismatches. Identical proteins remain separate source occurrences. Default target eligibility excludes
MAGE*exceptMAGEA4; this never changes the full CTA negative-self-reference exclusions.Policies, expression measurements, OncoRef reference resolutions, source sequences and decisions persist through allowlisted native JSON. Saved admission replay needs no upstream queries or expression file. Existing peptide and mRNA builders consume the admitted antigen in a synthetic integration smoke. Requires Topiary >=5.94.3, which fixes short expression tables at the shared loader. Bumps Vaxrank to 3.39.0; the OncoRef pin is unchanged.
Related: #584. This PR does not close the complete workflow issue.
Validation
./lint.sh: passed../test.sh: 2,213 passed, 349.23 seconds; no expected failures.pip check: passed.Remaining workflow in #584
Scientific semantics follow Salmon's transcript-abundance model (https://doi.org/10.1038/nmeth.4197) and Ensembl's representative-transcript definition (https://www.ensembl.org/info/genome/genebuild/canonical.html). The example expression threshold in the design document is a caller choice, not a universal cutoff.
Prerequisite: openvax/topiary#487 fixes openvax/topiary#486. The full prerequisite gate passed 5,469 tests with 20 optional skips. A separate high-depth RNA performance concern found during that gate is tracked at openvax/isovar#463. No read cap or Isovar workaround is part of this PR.